Remove ADP tests
RFC PATCH 1/1 Remove ADP tests
They're not used in any runtest, not using shell API.
---
Hi,
I know I cannot delete everything, but I don't see much value in these tests.
Kind regards,
Petr
--- testscripts/adp.sh | 89 ------------------------------------- testscripts/adp_children.sh | 11 ----- testscripts/adp_test.sh | 6 --- 3 files changed, 106 deletions(-) delete mode 100755 testscripts/adp.sh delete mode 100755 testscripts/adp_children.sh delete mode 100755 testscripts/adp_test.sh
testscripts/adp.sh deleted +0 -89
@@ -1,89 +0,0 @@ -#!/bin/bash -# -# adp.sh -- run ADP's stress test on /proc/[0-9]*/cmdline -# -# - -usage() -{ - cat << EOF - usage: $0 options - - This script runs ADP's stress test on /proc/[0-0]*/cmdline. - - OPTIONS - -h display this message and exit - -d delay for top, in seconds - -n number of iterations for top -EOF -} - - -checkvar() -{ - VAR=$1 - eval VALUE='$'$VAR - if [ "x$VALUE" = "x" ]; then - echo "`basename $0`: $VAR is not set." - return 1 - else - return 0 - fi -} - - -while getopts hd:n: OPTION -do - case $OPTION in - h) - usage - exit 1 - ;; - d) - delay=$OPTARG - ;; - n) - iterations=$OPTARG - ;; - ?) - usage - exit 1 - ;; - esac -done - - -#check all vars -checkvar delay && checkvar iterations || { - usage - exit 2 -} - -echo "-------------------------------------------------------------------------" -date -echo "Starting tests..." - -for i in 1 2 3 4 5 -do - ./adp_children.sh & -done - -echo "Stressing /proc/[0-9]*/cmdline..." - -for i in 1 2 3 4 5 -do - ./adp_test.sh & -done - -echo "Starting 'top', redirecting output to 'adp.log'..." -top -b -d $delay -n $iterations > adp.log & - -echo "LTP ADP Test done. Killing processes..." -killall adp_test.sh -killall adp_children.sh - -echo "Done. Please check adp.log." -date - -echo "-------------------------------------------------------------------------" -
testscripts/adp_children.sh deleted +0 -11
@@ -1,11 +0,0 @@ -#!/bin/bash - -while : -do - for i in 1 2 3 4 5 6 7 8 9 0 - do - sleep 1 & - done - - wait -done
testscripts/adp_test.sh deleted +0 -6
@@ -1,6 +0,0 @@ -#!/bin/bash - -while : -do - cat /proc/[0-9]*/cmdline > /dev/null 2>/dev/null -done
Signature · 1 line
2.19.2
RFC PATCH 1/1 Remove ADP tests
Quoted 2 lines · Petr Vorel
They're not used in any runtest, not using shell API.
Agree, and there is no real update for more than 10 years.
Signature · 2 lines
Regards, Li Wang
RFC PATCH 1/1 Remove ADP tests
Hi!
Quoted 3 lines
Quoted 1 line
They're not used in any runtest, not using shell API.
Agree, and there is no real update for more than 10 years.
And we have at least two maintained tests that stress proc filesystem, so there is no value in keeping these scripts.
Acked, Peter go ahead and push this.
Signature · 2 lines
Cyril Hrubis [email protected]
RFC PATCH 1/1 Remove ADP tests
Hi Cyril, Li,
Quoted 6 lines
Quoted 1 line
Agree, and there is no real update for more than 10 years.
And we have at least two maintained tests that stress proc filesystem, so there is no value in keeping these scripts.
Acked, Peter go ahead and push this.
Thanks for your review, pushed.
Kind regards,
Petr