lib/igt_edid_template: Fix parenthesis for vertical pulse coding
PATCH 1/1 lib/igt_edid_template: Fix parenthesis for vertical pulse coding
Add missing parenthesis in the macro coding the vertical pulse high bits. Without them, the shift takes precedence over the logical and operation, which is not how these bits should be coded according to the spec.
--- lib/igt_edid_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_edid_template.h +1 -1
@@ -8,7 +8,7 @@#define op (ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \ (((vo) & 0xf) << 4) | ((vp) & 0xf), \ (((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \ - | (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4) + | (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)static unsigned char EDID_NAME [EDID_LENGTH ] = {0x00 ,0xff ,0xff ,0xff ,0xff ,0xff ,0xff ,0x00 ,/* header */
Signature · 6 lines
2.20.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_edid_template: Fix parenthesis for vertical pulse coding
== Series Details ==
== Series Details ==
Series: lib/igt_edid_template: Fix parenthesis for vertical pulse coding
URL : https://patchwork.freedesktop.org/series/54704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5361 -> IGTPW_2183
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54704/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2183 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362] +1
#### Possible fixes ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
Participating hosts (52 -> 36)
------------------------------
Missing (16): fi-kbl-7567u fi-ilk-m540 fi-bdw-samus fi-bdw-5557u fi-bsw-n3050 fi-byt-j1900 fi-hsw-4200u fi-glk-dsi fi-byt-squawks fi-cfl-8700k fi-bsw-cyan fi-ctg-p8600 fi-cfl-8109u fi-bsw-kefka fi-kbl-7560u fi-skl-6600u
Build changes
-------------
* IGT: IGT_4756 -> IGTPW_2183
CI_DRM_5361: 076417527f6abadb519f6d5e7cec575973888607 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2183: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2183/
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2183/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_edid_template: Fix parenthesis for vertical pulse coding
In reply to Paul Kocialkowski== Series Details ==
== Series Details ==
Series: lib/igt_edid_template: Fix parenthesis for vertical pulse coding
URL : https://patchwork.freedesktop.org/series/54704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5361_full -> IGTPW_2183_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54704/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2183_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@bcs0-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665] +1
* igt@i915_suspend@shrink:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#108784]
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145] +1
- shard-kbl: PASS -> FAIL [fdo#107725] / [fdo#108145]
* igt@kms_color@pipe-b-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-glk: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_crc@cursor-64x64-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-kbl: PASS -> FAIL [fdo#103166]
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS +2
* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +2
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: DMESG-WARN [fdo#103313] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-kbl: DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#103665] / [fdo#106886]
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4756 -> IGTPW_2183
* Piglit: piglit_4509 -> None
CI_DRM_5361: 076417527f6abadb519f6d5e7cec575973888607 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2183: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2183/
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2183/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 6 lines · Paul Kocialkowski
Add missing parenthesis in the macro coding the vertical pulse high bits. Without them, the shift takes precedence over the logical and operation, which is not how these bits should be coded according to the spec.
Signed-off-by Paul Kocialkowski <[email protected]>
Quoted 19 lines
--- lib/igt_edid_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/igt_edid_template.h +1
-1@@ -8,7 +8,7 @@#define op (ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \ (((vo) & 0xf) << 4) | ((vp) & 0xf), \ (((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \ - | (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4) + | (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)static unsigned char EDID_NAME [EDID_LENGTH ] = {0x00 ,0xff ,0xff ,0xff ,0xff ,0xff ,0xff ,0x00 ,/* header */ Signature · 1 line
2.20.1
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Hi,
Quoted 6 lines · Paul Kocialkowski
Add missing parenthesis in the macro coding the vertical pulse high bits. Without them, the shift takes precedence over the logical and operation, which is not how these bits should be coded according to the spec.
Signed-off-by Paul Kocialkowski <[email protected]>
Looks like this patch was reviewed and CI-tested, so it should be ready for inclusion. Would someone like to pick it up?
Thanks in advance!
Cheers,
Paul
Quoted 17 lines
--- lib/igt_edid_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/igt_edid_template.h +1
-1@@ -8,7 +8,7 @@#define op (ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \ (((vo) & 0xf) << 4) | ((vp) & 0xf), \ (((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \ - | (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4) + | (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)static unsigned char EDID_NAME [EDID_LENGTH ] = {0x00 ,0xff ,0xff ,0xff ,0xff ,0xff ,0xff ,0x00 ,/* header */
Signature · 8 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Antonio Argenziano
AppliedQuoted 8 lines · Paul Kocialkowski
Hi,
Quoted 5 lines · Paul Kocialkowski
Add missing parenthesis in the macro coding the vertical pulse high bits. Without them, the shift takes precedence over the logical and operation, which is not how these bits should be coded according to the spec.
Quoted 6 lines
Quoted 1 line
Signed-off-by Paul Kocialkowski <[email protected]>Looks like this patch was reviewed and CI-tested, so it should be ready for inclusion. Would someone like to pick it up?
Thanks in advance!
Merged, thanks for the patch and the review!
Antonio
Quoted 20 lines
Cheers,
Paul
Quoted 15 lines
--- lib/igt_edid_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/igt_edid_template.h +1
-1@@ -8,7 +8,7 @@#define op (ho, hp, vo, vp) ((ho) & 0xff), ((hp) & 0xff), \ (((vo) & 0xf) << 4) | ((vp) & 0xf), \ (((ho) & 0x300) >> 2) | (((hp) & 0x300) >> 4) \ - | (((vo) & 0x30) >> 2) | ((vp) & 0x30 >> 4) + | (((vo) & 0x30) >> 2) | (((vp) & 0x30) >> 4)
Quoted 2 lines
lib/igt_edid_template.h line 14
Quoted 2 lines
lib/igt_edid_template.h +0
-0static unsigned char EDID_NAME [EDID_LENGTH ] = {0x00 ,0xff ,0xff ,0xff ,0xff ,0xff ,0xff ,0x00 ,/* header */
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 2 lines · Paul Kocialkowski
Looks like this patch was reviewed and CI-tested, so it should be ready for inclusion. Would someone like to pick it up?
For future reference, you could ask for commit rights, and push your own patches after review and CI. See CONTRIBUTING.md.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Hi,
Quoted 6 lines · Jani Nikula
Quoted 2 lines · Paul Kocialkowski
Looks like this patch was reviewed and CI-tested, so it should be ready for inclusion. Would someone like to pick it up?
For future reference, you could ask for commit rights, and push your own patches after review and CI. See CONTRIBUTING.md.
Yes, given that we have been working with IGT quite a lot recently, that would make sense. I'll be discussing this with Maxime soon then!
Cheers,
Paul
Signature · 8 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev