Skip to contentSkip to conversation

tests/amdgpu: Add test for Adaptive Backlight Management

PATCH In review David Francis 3 participants 4 messages Jan 3, 2019 – Jan 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/amdgpu: Add test for Adaptive Backlight Management

Adaptive Backlight Management (ABM) is a power-saving feature on AMD ASICs that reduces backlight while increasing pixel contrast and luminance. This test confirms that ABM is present and enabled, and that backlight performance is sane. It uses AMD-specific debugfs entries to read the backlight PWM values.

It has 5 subtests:

dpms_cycle
Sets brightness to half, then confirms that value is restored after dpms off and then on.

backlight_monotonic_basic
Sets brightness to ten different values, confirming that higher brightness values are brighter.

backlight_monotonic_abm
Same as backlight_monotonic_basic, but with abm enabled.

abm_enabled
Sets abm to its four intensity levels, confirming that abm reduces the backlight, and the reduction is greater for higher abm level.

abm_gradual
Sets abm to off and then maximum intensity, confirming that brightness decreases continually over the first second and eventually reaches the target value. This test takes 30s to run.

v2: make sure that dpms is cycled on the eDP display

---
 tests/Makefile.sources |   1 +
 tests/amdgpu/amd_abm.c | 363 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 364 insertions(+)
 create mode 100644 tests/amdgpu/amd_abm.c
tests/Makefile.sources +1 -0
index 5620c1d6..3d560bee 100644
@@ -19,6 +19,7 @@ AMDGPU_TESTS = \
 	amdgpu/amd_basic \
 	amdgpu/amd_cs_nop \
 	amdgpu/amd_prime \
+	amdgpu/amd_abm \
 	$(NULL)
 
 TESTS_progs = \
tests/amdgpu/amd_abm.c new file +363 -0

363 lines not on this page · raw message

Signature · 6 lines
2.17.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/amdgpu: Add test for Adaptive Backlight Management (rev2)

== Series Details ==

== Series Details ==

Series: tests/amdgpu: Add test for Adaptive Backlight Management (rev2)
URL : https://patchwork.freedesktop.org/series/53186/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5361 -> IGTPW_2184
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53186/revisions/2/mbox/

Known issues
------------

Here are the changes found in IGTPW_2184 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@i915_selftest@live_execlists:
- fi-apl-guc: PASS -> DMESG-WARN [fdo#108622]

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@prime_vgem@basic-fence-flip:
- fi-gdg-551: PASS -> FAIL [fdo#103182]

#### Possible fixes ####

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: FAIL [fdo#108767] -> PASS

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767

Participating hosts (52 -> 36)
------------------------------

Missing (16): fi-kbl-7567u fi-ilk-m540 fi-bsw-n3050 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-cfl-8700k fi-ilk-650 fi-ctg-p8600 fi-whl-u fi-cfl-8109u fi-kbl-7560u fi-byt-n2820 fi-bdw-samus fi-snb-2600

Build changes
-------------

* IGT: IGT_4756 -> IGTPW_2184

CI_DRM_5361: 076417527f6abadb519f6d5e7cec575973888607 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2184: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2184/
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2184/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests/amdgpu: Add test for Adaptive Backlight Management (rev2)

In reply to David Francis
== Series Details ==

== Series Details ==

Series: tests/amdgpu: Add test for Adaptive Backlight Management (rev2)
URL : https://patchwork.freedesktop.org/series/53186/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5361_full -> IGTPW_2184_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with IGTPW_2184_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_2184_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/53186/revisions/2/mbox/

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_2184_full:

### IGT changes ###

#### Warnings ####

* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: SKIP -> PASS

Known issues
------------

Here are the changes found in IGTPW_2184_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_suspend@shrink:
- shard-snb: NOTRUN -> DMESG-WARN [fdo#108784]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145] +2

* igt@kms_color@pipe-b-degamma:
- shard-apl: PASS -> FAIL [fdo#104782]

* igt@kms_cursor_crc@cursor-128x42-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +2

* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232] +2
- shard-kbl: PASS -> FAIL [fdo#103232] +1

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-glk: PASS -> FAIL [fdo#102887] / [fdo#105363]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
- shard-glk: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +2
- shard-kbl: PASS -> FAIL [fdo#103167]

* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-glk: PASS -> FAIL [fdo#103166] +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-apl: PASS -> FAIL [fdo#103166] +4

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-kbl: PASS -> FAIL [fdo#103166]

* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
- shard-kbl: PASS -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]

* igt@prime_busy@wait-hang-blt:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

#### Possible fixes ####

* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-kbl: DMESG-WARN [fdo#107956] -> PASS +1

* igt@kms_color@pipe-b-ctm-max:
- shard-apl: FAIL [fdo#108147] -> PASS

* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS +1

* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-glk: FAIL [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: FAIL [fdo#103060] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: FAIL [fdo#103167] -> PASS +2

* igt@kms_plane@pixel-format-pipe-c-planes-source-clamping:
- shard-glk: FAIL [fdo#108948] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:

    - shard-apl:          FAIL [fdo#103166] -> PASS +3
    - shard-kbl:          FAIL [fdo#103166] -> PASS +1
    - shard-glk:          FAIL [fdo#103166] -> PASS +2

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-kbl: DMESG-WARN [fdo#103313] -> PASS

[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (7 -> 5)
------------------------------

Missing (2): shard-skl shard-iclb

Build changes
-------------

* IGT: IGT_4756 -> IGTPW_2184
* Piglit: piglit_4509 -> None

CI_DRM_5361: 076417527f6abadb519f6d5e7cec575973888607 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2184: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2184/
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2184/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v2 1/1
#3 lore raw
In reply to David Francis
Quoted 31 lines · David Francis

Adaptive Backlight Management (ABM) is a power-saving feature on AMD ASICs that reduces backlight while increasing pixel contrast and luminance. This test confirms that ABM is present and enabled, and that backlight performance is sane. It uses AMD-specific debugfs entries to read the backlight PWM values.

It has 5 subtests:

dpms_cycle
Sets brightness to half, then confirms that value is restored after dpms off and then on.

backlight_monotonic_basic
Sets brightness to ten different values, confirming that higher brightness values are brighter.

backlight_monotonic_abm
Same as backlight_monotonic_basic, but with abm enabled.

abm_enabled
Sets abm to its four intensity levels, confirming that abm reduces the backlight, and the reduction is greater for higher abm level.

abm_gradual
Sets abm to off and then maximum intensity, confirming that brightness decreases continually over the first second and eventually reaches the target value. This test takes 30s to run.

Quoted 3 lines

v2: make sure that dpms is cycled on the eDP display

Thanks,

Quoted 378 lines
---
  tests/Makefile.sources |   1 +
  tests/amdgpu/amd_abm.c | 363 +++++++++++++++++++++++++++++++++++++++++
  2 files changed, 364 insertions(+)

create mode 100644 tests/amdgpu/amd_abm.c

tests/Makefile.sources +1 -0
index 5620c1d6..3d560bee 100644
@@ -19,6 +19,7 @@ AMDGPU_TESTS = \
  	amdgpu/amd_basic \
  	amdgpu/amd_cs_nop \
  	amdgpu/amd_prime \
+	amdgpu/amd_abm \
  	$(NULL)
 
  TESTS_progs = \
tests/amdgpu/amd_abm.c new file +353 -0
new file mode 100644
index 00000000..363b1e90
@@ -0,0 +1,363 @@
+/*
+ * Copyright 2018 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "igt.h"
+#include "drmtest.h"
+#include "igt_kms.h"
+#include <limits.h>
+#include <errno.h>
+#include <stdbool.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <time.h>
+
+#define BACKLIGHT_PATH "/sys/class/backlight/amdgpu_bl0"
+
+static int read_current_backlight_pwm(int debugfs_dir)
+{
+	char buf[20];
+
+	igt_debugfs_simple_read(debugfs_dir, "amdgpu_current_backlight_pwm",
+			 buf, sizeof(buf));
+
+	return strtol(buf, NULL, 0);
+}
+
+static int read_target_backlight_pwm(int debugfs_dir)
+{
+	char buf[20];
+
+	igt_debugfs_simple_read(debugfs_dir, "amdgpu_target_backlight_pwm",
+			 buf, sizeof(buf));
+
+	return strtol(buf, NULL, 0);
+}
+
+static int backlight_write_brightness(int value)
+{
+	int fd;
+	char full[PATH_MAX];
+	char src[64];
+	int len;
+
+	igt_assert(snprintf(full, PATH_MAX, "%s/%s", BACKLIGHT_PATH, "brightness") < PATH_MAX);
+	fd = open(full, O_WRONLY);
+	if (fd == -1)
+		return -errno;
+
+	len = snprintf(src, sizeof(src), "%i", value);
+	len = write(fd, src, len);
+	close(fd);
+
+	if (len < 0)
+		return len;
+
+	return 0;
+}
+
+static void set_abm_level(igt_display_t *display, int level)
+{
+	int i, ret;
+	int output_id;
+	drmModeObjectPropertiesPtr props;
+	uint32_t prop_id;
+	drmModePropertyPtr prop;
+	uint32_t type = DRM_MODE_OBJECT_CONNECTOR;
+
+	for (i = 0; i < display->n_outputs; i++) {
+		output_id = display->outputs[i].id;
+		props = drmModeObjectGetProperties(display->drm_fd, output_id, type);
+
+		for (i = 0; i < props->count_props; i++) {
+			prop_id = props->props[i];
+			prop = drmModeGetProperty(display->drm_fd, prop_id);
+
+			igt_assert(prop);
+
+			if (strcmp(prop->name, "abm level") == 0) {
+				ret = drmModeObjectSetProperty(display->drm_fd, output_id, type, prop_id, level);
+
+				igt_assert_eq(ret, 0);
+			}
+
+			drmModeFreeProperty(prop);
+		}
+	}
+
+}
+
+static int backlight_read_max_brightness(int *result)
+{
+	int fd;
+	char full[PATH_MAX];
+	char dst[64];
+	int r, e;
+
+	igt_assert(snprintf(full, PATH_MAX, "%s/%s", BACKLIGHT_PATH, "max_brightness") < PATH_MAX);
+
+	fd = open(full, O_RDONLY);
+	if (fd == -1)
+		return -errno;
+
+	r = read(fd, dst, sizeof(dst));
+	e = errno;
+	close(fd);
+
+	if (r < 0)
+		return -e;
+
+	errno = 0;
+	*result = strtol(dst, NULL, 10);
+	return errno;
+}
+
+static void skip_if_incompatible(igt_display_t *display, int debugfs_dir)
+{
+	int ret, i;
+	char buf[20];
+	bool abm_prop_exists;
+	int output_id;
+	drmModeObjectPropertiesPtr props;
+	uint32_t type = DRM_MODE_OBJECT_CONNECTOR;
+	uint32_t prop_id;
+	drmModePropertyPtr prop;
+
+	ret = igt_debugfs_simple_read(debugfs_dir, "amdgpu_current_backlight_pwm",
+			 buf, sizeof(buf));
+
+	if (ret < 0)
+		igt_skip("No current backlight debugfs entry.\n");
+
+	ret = igt_debugfs_simple_read(debugfs_dir, "amdgpu_target_backlight_pwm",
+			 buf, sizeof(buf));
+
+	if (ret < 0)
+		igt_skip("No target backlight debugfs entry.\n");
+
+	abm_prop_exists = false;
+
+	for (i = 0; i < display->n_outputs; i++) {
+		output_id = display->outputs[i].id;
+		props = drmModeObjectGetProperties(display->drm_fd, output_id, type);
+
+		for (i = 0; i < props->count_props; i++) {
+			prop_id = props->props[i];
+			prop = drmModeGetProperty(display->drm_fd, prop_id);
+
+			if (strcmp(prop->name, "abm level") == 0)
+				abm_prop_exists = true;
+
+			drmModeFreeProperty(prop);
+		}
+	}
+
+	if (!abm_prop_exists)
+		igt_skip("No abm level property on any connector.\n");
+}
+
+
+static void backlight_dpms_cycle(igt_display_t *display, int debugfs, igt_output_t *output)
+{
+	int ret;
+	int max_brightness;
+	int pwm_1, pwm_2;
+
+	ret = backlight_read_max_brightness(&max_brightness);
+	igt_assert_eq(ret, 0);
+
+	set_abm_level(display, 0);
+	backlight_write_brightness(max_brightness / 2);
+	usleep(100000);
+	pwm_1 = read_target_backlight_pwm(debugfs);
+
+	kmstest_set_connector_dpms(display->drm_fd, output->config.connector, DRM_MODE_DPMS_OFF);
+	kmstest_set_connector_dpms(display->drm_fd, output->config.connector, DRM_MODE_DPMS_ON);
+	usleep(100000);
+	pwm_2 = read_target_backlight_pwm(debugfs);
+	igt_assert_eq(pwm_1, pwm_2);
+}
+
+static void backlight_monotonic_basic(igt_display_t *display, int debugfs)
+{
+	int ret;
+	int max_brightness;
+	int prev_pwm, pwm;
+	int brightness_step;
+	int brightness;
+
+	ret = backlight_read_max_brightness(&max_brightness);
+	igt_assert_eq(ret, 0);
+
+	brightness_step = max_brightness / 10;
+
+	set_abm_level(display, 0);
+	backlight_write_brightness(max_brightness);
+	usleep(100000);
+	prev_pwm = read_target_backlight_pwm(debugfs);
+	for (brightness = max_brightness - brightness_step;
+	     brightness > 0;
+	     brightness -= brightness_step) {
+		backlight_write_brightness(brightness);
+		usleep(100000);
+		pwm = read_target_backlight_pwm(debugfs);
+		igt_assert(pwm < prev_pwm);
+		prev_pwm = pwm;
+	}
+
+}
+
+static void backlight_monotonic_abm(igt_display_t *display, int debugfs)
+{
+	int ret, i;
+	int max_brightness;
+	int prev_pwm, pwm;
+	int brightness_step;
+	int brightness;
+
+	ret = backlight_read_max_brightness(&max_brightness);
+	igt_assert_eq(ret, 0);
+
+	brightness_step = max_brightness / 10;
+	for (i = 1; i < 5; i++) {
+		set_abm_level(display, i);
+		backlight_write_brightness(max_brightness);
+		usleep(100000);
+		prev_pwm = read_target_backlight_pwm(debugfs);
+		for (brightness = max_brightness - brightness_step;
+		     brightness > 0;
+		     brightness -= brightness_step) {
+			backlight_write_brightness(brightness);
+			usleep(100000);
+			pwm = read_target_backlight_pwm(debugfs);
+			igt_assert(pwm < prev_pwm);
+			prev_pwm = pwm;
+		}
+	}
+}
+
+static void abm_enabled(igt_display_t *display, int debugfs)
+{
+	int ret, i;
+	int max_brightness;
+	int pwm, prev_pwm, pwm_without_abm;
+
+	ret = backlight_read_max_brightness(&max_brightness);
+	igt_assert_eq(ret, 0);
+
+	set_abm_level(display, 0);
+	backlight_write_brightness(max_brightness);
+	usleep(100000);
+	prev_pwm = read_target_backlight_pwm(debugfs);
+	pwm_without_abm = prev_pwm;
+
+	for (i = 1; i < 5; i++) {
+		set_abm_level(display, i);
+		usleep(100000);
+		pwm = read_target_backlight_pwm(debugfs);
+		igt_assert(pwm <= prev_pwm);
+		igt_assert(pwm < pwm_without_abm);
+		prev_pwm = pwm;
+	}
+
+}
+
+static void abm_gradual(igt_display_t *display, int debugfs)
+{
+	int ret, i;
+	int convergence_delay = 15;
+	int prev_pwm, pwm, curr;
+	int max_brightness;
+
+	ret = backlight_read_max_brightness(&max_brightness);
+
+	igt_assert_eq(ret, 0);
+
+	set_abm_level(display, 0);
+	backlight_write_brightness(max_brightness);
+
+	sleep(convergence_delay);
+	prev_pwm = read_target_backlight_pwm(debugfs);
+	curr = read_current_backlight_pwm(debugfs);
+
+	igt_assert_eq(prev_pwm, curr);
+	set_abm_level(display, 4);
+	for (i = 0; i < 10; i++) {
+		usleep(100000);
+		pwm = read_current_backlight_pwm(debugfs);
+		igt_assert(pwm < prev_pwm);
+		prev_pwm = pwm;
+	}
+
+	sleep(convergence_delay - 1);
+
+	prev_pwm = read_target_backlight_pwm(debugfs);
+	curr = read_current_backlight_pwm(debugfs);
+
+	igt_assert_eq(prev_pwm, curr);
+}
+
+igt_main
+{
+	igt_display_t display;
+	int debugfs;
+	enum pipe pipe;
+	igt_output_t *output;
+
+	igt_skip_on_simulation();
+
+	igt_fixture {
+		display.drm_fd = drm_open_driver_master(DRIVER_AMDGPU);
+
+		if (display.drm_fd == -1)
+			igt_skip("Not an amdgpu driver.\n");
+
+		debugfs = igt_debugfs_dir(display.drm_fd);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&display, display.drm_fd);
+
+		skip_if_incompatible(&display, debugfs);
+
+		for_each_pipe_with_valid_output(&display, pipe, output) {
+			if (output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP)
+				break;
+		}
+	}
+
+	igt_subtest("dpms_cycle")
+		backlight_dpms_cycle(&display, debugfs, output);
+	igt_subtest("backlight_monotonic_basic")
+		backlight_monotonic_basic(&display, debugfs);
+	igt_subtest("backlight_monotonic_abm")

tests/amdgpu/amd_abm.c line 363

Quoted 10 lines
tests/amdgpu/amd_abm.c new file +10 -0
+		backlight_monotonic_abm(&display, debugfs);
+	igt_subtest("abm_enabled")
+		abm_enabled(&display, debugfs);
+	igt_subtest("abm_gradual")
+		abm_gradual(&display, debugfs);
+
+	igt_fixture {
+		igt_display_fini(&display);
+	}
+}

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev