Skip to contentSkip to conversation

hv_netvsc: fix typos in code comments

PATCH Applied Adrian Vladu 4 participants 4 messages Jan 3, 2019 – Jan 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hv_netvsc: fix typos in code comments

Fix all typos from hyperv netvsc code comments.

Cc "K. Y. Srinivasan" <[email protected]>
Cc Haiyang Zhang <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc Sasha Levin <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc "Alessandro Pilotti" <[email protected]>
---
 drivers/net/hyperv/hyperv_net.h   | 2 +-
 drivers/net/hyperv/netvsc.c       | 2 +-
 drivers/net/hyperv/netvsc_drv.c   | 6 +++---
 drivers/net/hyperv/rndis_filter.c | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)
drivers/net/hyperv/hyperv_net.h +1 -1
index ef6f766f6389..eabed1dd9606 100644
@@ -1177,7 +1177,7 @@ enum ndis_per_pkt_info_type {
 
 enum rndis_per_pkt_info_interal_type {
 	RNDIS_PKTINFO_ID = 1,
-	/* Add more memebers here */
+	/* Add more members here */
 
 	RNDIS_PKTINFO_MAX
 };
drivers/net/hyperv/netvsc.c +1 -1
index 922054c1d544..9a3ad94aa4dc 100644
@@ -1331,7 +1331,7 @@ void netvsc_channel_cb(void *context)
 	prefetch(hv_get_ring_buffer(rbi) + rbi->priv_read_index);
 
 	if (napi_schedule_prep(&nvchan->napi)) {
-		/* disable interupts from host */
+		/* disable interrupts from host */
 		hv_begin_read(rbi);
 
 		__napi_schedule_irqoff(&nvchan->napi);
drivers/net/hyperv/netvsc_drv.c +3 -3
index 91ed15ea5883..d1a7ea76aa88 100644
@@ -370,7 +370,7 @@ static u32 fill_pg_buf(struct page *page, u32 offset, u32 len,
 {
 	int j = 0;
 
-	/* Deal with compund pages by ignoring unused part
+	/* Deal with compound pages by ignoring unused part
 	 * of the page.
 	 */
 	page += (offset >> PAGE_SHIFT);
@@ -2088,7 +2088,7 @@ static int netvsc_register_vf(struct net_device *vf_netdev)
 	if (!netvsc_dev || rtnl_dereference(net_device_ctx->vf_netdev))
 		return NOTIFY_DONE;
 
-	/* if syntihetic interface is a different namespace,
+	/* if synthetic interface is a different namespace,
 	 * then move the VF to that namespace; join will be
 	 * done again in that context.
 	 */
@@ -2236,7 +2236,7 @@ static int netvsc_probe(struct hv_device *dev,
 	 * netvsc_probe() can't get rtnl lock and as a result vmbus_onoffer()
 	 * -> ... -> device_add() -> ... -> __device_attach() can't get
 	 * the device lock, so all the subchannels can't be processed --
-	 * finally netvsc_subchan_work() hangs for ever.
+	 * finally netvsc_subchan_work() hangs forever.
 	 */
 	rtnl_lock();
 
drivers/net/hyperv/rndis_filter.c +1 -1
index 8b537a049c1e..40fda5c441e0 100644
@@ -1161,7 +1161,7 @@ int rndis_set_subchannel(struct net_device *ndev, struct netvsc_device *nvdev)
 	wait_event(nvdev->subchan_open,
 		   atomic_read(&nvdev->open_chn) == nvdev->num_chn);
 
-	/* ignore failues from setting rss parameters, still have channels */
+	/* ignore failures from setting rss parameters, still have channels */
 	rndis_filter_set_rss_param(rdev, netvsc_hash_key);
 
 	netif_set_real_num_tx_queues(ndev, nvdev->num_chn);
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines

-----Original Message-----
From: Adrian Vladu <[email protected]>
Sent: Thursday, January 3, 2019 2:43 PM
To: [email protected]
Cc: Adrian Vladu <[email protected]>; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Stephen Hemminger <[email protected]>; Sasha Levin <[email protected]>; David S. Miller <[email protected]>; apilotti <[email protected]>
Subject: [PATCH] hv_netvsc: fix typos in code comments

Fix all typos from hyperv netvsc code comments.

Quoted 7 lines
Cc "K. Y. Srinivasan" <[email protected]>
Cc Haiyang Zhang <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc Sasha Levin <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc "Alessandro Pilotti" <[email protected]>

---

Thanks.

#2 lore raw
Quoted 22 lines · Haiyang Zhang
Quoted 14 lines

From: Adrian Vladu <[email protected]>
Sent: Thursday, January 3, 2019 2:43 PM
To: [email protected]
Cc: Adrian Vladu <[email protected]>; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Stephen Hemminger <[email protected]>; Sasha Levin <[email protected]>; David S. Miller <[email protected]>; apilotti <[email protected]>
Subject: [PATCH] hv_netvsc: fix typos in code comments

Fix all typos from hyperv netvsc code comments.

Quoted 7 lines
Cc "K. Y. Srinivasan" <[email protected]>
Cc Haiyang Zhang <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc Sasha Levin <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc "Alessandro Pilotti" <[email protected]>

---

Quoted 3 lines

Thanks.

Looks good to me.

Thanks,
-- Dexuan

Applied
#3 lore raw
Quoted 23 lines · Dexuan-Linux Cui
Quoted 22 lines · Haiyang Zhang
Quoted 21 lines

From: Adrian Vladu <[email protected]>
Sent: Thursday, January 3, 2019 2:43 PM
To: [email protected]
Cc: Adrian Vladu <[email protected]>; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; Stephen Hemminger <[email protected]>; Sasha Levin <[email protected]>; David S. Miller <[email protected]>; apilotti <[email protected]>
Subject: [PATCH] hv_netvsc: fix typos in code comments

Fix all typos from hyperv netvsc code comments.

Cc "K. Y. Srinivasan" <[email protected]>
Cc Haiyang Zhang <[email protected]>
Cc Stephen Hemminger <[email protected]>
Cc Sasha Levin <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc "Alessandro Pilotti" <[email protected]>

---

Quoted 5 lines
Quoted 3 lines

Thanks.

Looks good to me.

Queued for hyperv-fixes, thank you.

--
Thanks,
Sasha