Skip to contentSkip to conversation

Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

PATCH New Philipp Tomsich 4 participants 5 messages Jan 3, 2019 – Jan 28, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture. This wraps an 'if ARCH_IMX8M' around these.

---

 drivers/ddr/imx/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/ddr/imx/Kconfig +2 -0
index 7e06fb2..09a35e5 100644
@@ -1 +1,3 @@
+if ARCH_IMX8M
 source "drivers/ddr/imx/imx8m/Kconfig"
+endif
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

Quoted 15 lines · Philipp Tomsich

No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture. This wraps an 'if ARCH_IMX8M' around these.

---

 drivers/ddr/imx/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/ddr/imx/Kconfig +0 -0
index 7e06fb2..09a35e5 100644

drivers/ddr/imx/Kconfig line 3

Quoted 3 lines
drivers/ddr/imx/Kconfig +2 -0
@@ -1 +1,3 @@
+if ARCH_IMX8M
 source "drivers/ddr/imx/imx8m/Kconfig"
+endif

Ugh. We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' lines like all of the other DDR controllers.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190103/5ba169e7/attachment.sig>
#2 lore raw

PATCH 1/1 Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

Quoted 16 lines · Tom Rini
Quoted 10 lines · Philipp Tomsich

No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture. This wraps an 'if ARCH_IMX8M' around these.

---

drivers/ddr/imx/Kconfig | 2 ++

1 file changed, 2 insertions(+)
Quoted 11 lines
Quoted 8 lines
drivers/ddr/imx/Kconfig +1 -0
index 7e06fb2..09a35e5 100644
@@ -1 +1,3 @@
+if ARCH_IMX8M

source "drivers/ddr/imx/imx8m/Kconfig"
+endif

Ugh. We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' lines like all of the other DDR controllers.

Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first time in a long time)—they just didn’t bother me as much as this one ;-)

If I remember to do so, I’ll submit patches for those two as well ...

Cheers,
Phil.

#3 lore raw

PATCH 1/1 Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

Hi Philipp,

Quoted 30 lines · Philipp Tomsich
Quoted 18 lines

On 03.01.2019, at 21:21, Tom Rini <[email protected] <mailto:[email protected]>> wrote:

Quoted 11 lines · Philipp Tomsich

No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture.  This wraps an 'if ARCH_IMX8M' around these.

<mailto:[email protected]>>
---

drivers/ddr/imx/Kconfig | 2 ++

1 file changed, 2 insertions(+)
Quoted 11 lines
Quoted 8 lines
drivers/ddr/imx/Kconfig +1 -0
index 7e06fb2..09a35e5 100644
@@ -1 +1,3 @@
+if ARCH_IMX8M

source "drivers/ddr/imx/imx8m/Kconfig"
+endif

Ugh.  We need drivers/ddr/imx/imx8m/Kconfig to have real 'depends on' lines like all of the other DDR controllers.

Quoted 6 lines

Unfortunately, there’s more without meaningful 'depends on’: STM32_SDRAM and MPC83XX_SDRAM also caught my eye today (I went into menuconfig for the first time in a long time)—they just didn’t bother me as much as this one ;-)

If I remember to do so, I’ll submit patches for those two as well ...

Nevertheless, and I agree your patch is working, too, the common way in Kconfig is to add suitable "depends on" as suggested by Tom and as we have on other DDR drivers instead of a global #if ARCH_IMX8m (I agree that for an user does not change a lot, by the way).

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/1 Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

In reply to Philipp Tomsich
Quoted 27 lines

-----Original Message-----
From: Philipp Tomsich [mailto:philipp.tomsich at theobroma-systems.com]
Sent: 2019年1月4日 1:48
To: u-boot at lists.denx.de
Cc: Tom Rini <[email protected]>; Philipp Tomsich <[email protected]>; Peng Fan <[email protected]>; Masahiro Yamada <[email protected]>
Subject: [PATCH] Kconfig: don't pollute Kconfig w/ i.MX8M options for everyone

No point in showing the various DRAM options (right in the top-level menu for 'Device Drivers') for i.MX8M when configured for a different architecture. This wraps an 'if ARCH_IMX8M' around these.

---

 drivers/ddr/imx/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/ddr/imx/Kconfig index renamed from drivers/ddr/imx/Kconfig +0 -0

7e06fb2..09a35e5 100644

drivers/ddr/imx/Kconfig line 3

Quoted 3 lines
drivers/ddr/imx/Kconfig +2 -0
@@ -1 +1,3 @@
+if ARCH_IMX8M
 source "drivers/ddr/imx/imx8m/Kconfig"
+endif

Thanks. Reviewed-by: Peng Fan <[email protected]>

Quoted 2 lines

--
2.1.4