Skip to contentSkip to conversation

fs/dax: Convert to use vmf_error()

PATCH In review Souptick Joarder 3 participants 6 messages Jan 4, 2019 – Feb 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/dax: Convert to use vmf_error()

This code is converted to use vmf_error().

---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/dax.c +1 -3
index 48132ec..ed39161 100644
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
 	if (error == 0)
 		return VM_FAULT_NOPAGE;
-	if (error == -ENOMEM)
-		return VM_FAULT_OOM;
-	return VM_FAULT_SIGBUS;
+	return vmf_error(error);
 }
 
 /*
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Souptick Joarder

This code is converted to use vmf_error().

Any comment on this patch ?

Quoted 22 lines
---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/dax.c +1 -4
index 48132ec..ed39161 100644
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
        if (error == 0)
                return VM_FAULT_NOPAGE;
-       if (error == -ENOMEM)
-               return VM_FAULT_OOM;
-       return VM_FAULT_SIGBUS;
+       return vmf_error(error);
 }
 
 /*
--

1.9.1

reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to Souptick Joarder
Quoted 3 lines · Souptick Joarder

This code is converted to use vmf_error().

Dan, you are merging DAX patches these days. So probably you should add yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs. Or I can start picking patches for fsdax to my tree if you are too busy but I think your tree is easier as there are less chances for conflicts etc.

In either case this patch looks OK to me so feel free to add

Honza

Quoted 22 lines
---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/dax.c +1 -3
index 48132ec..ed39161 100644
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
 	if (error == 0)
 		return VM_FAULT_NOPAGE;
-	if (error == -ENOMEM)
-		return VM_FAULT_OOM;
-	return VM_FAULT_SIGBUS;
+	return vmf_error(error);
 }
 
 /*
Signature · 1 line
1.9.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#3 lore raw
Quoted 8 lines · Jan Kara
Quoted 3 lines · Souptick Joarder

This code is converted to use vmf_error().

Dan, you are merging DAX patches these days. So probably you should add yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

Quoted 35 lines

Or I can start
picking patches for fsdax to my tree if you are too busy but I think your tree is easier as there are less chances for conflicts etc.

In either case this patch looks OK to me so feel free to add

Honza

Quoted 20 lines
---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/dax.c +1 -4
index 48132ec..ed39161 100644
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
      if (error == 0)
              return VM_FAULT_NOPAGE;
-     if (error == -ENOMEM)
-             return VM_FAULT_OOM;
-     return VM_FAULT_SIGBUS;
+     return vmf_error(error);
 }
 
 /*
--
Quoted 2 lines

1.9.1

--
Jan Kara <[email protected]>
SUSE Labs, CR

#4 lore raw

Hi Dan,

Quoted 4 lines · Dan Williams
Quoted 2 lines · Jan Kara

On Sat 05-01-19 00:54:11, Souptick Joarder wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

This code is converted to use vmf_error().

Dan, you are merging DAX patches these days. So probably you should add yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

This is not reflecting in linux-next. Is this queued for 5.1 ?

Quoted 36 lines
Quoted 36 lines

Or I can start
picking patches for fsdax to my tree if you are too busy but I think your tree is easier as there are less chances for conflicts etc.

In either case this patch looks OK to me so feel free to add

Honza

Quoted 20 lines
---
 fs/dax.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
fs/dax.c +1 -4
index 48132ec..ed39161 100644
@@ -1220,9 +1220,7 @@ static vm_fault_t dax_fault_return(int error)
 {
      if (error == 0)
              return VM_FAULT_NOPAGE;
-     if (error == -ENOMEM)
-             return VM_FAULT_OOM;
-     return VM_FAULT_SIGBUS;
+     return vmf_error(error);
 }
 
 /*
--
Quoted 2 lines

1.9.1

--
Jan Kara <[email protected]>
SUSE Labs, CR

#5 lore raw
Quoted 10 lines · Souptick Joarder

Hi Dan,

Quoted 6 lines · Dan Williams
Quoted 4 lines · Jan Kara
Quoted 2 lines · Souptick Joarder

This code is converted to use vmf_error().

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Dan, you are merging DAX patches these days. So probably you should add yourself to 'FILESYSTEM DIRECT ACCESS (DAX)' in MAINTAINERs.

Sounds good, I'll merge this and get MAINTAINERs fixed up.

This is not reflecting in linux-next. Is this queued for 5.1 ?

Thanks for the ping, I'll get it queued up shortly.