pinctrl: sirf: atlas7: use struct_size() in devm_kzalloc()
Subsystems (2)
PATCH 1/1 pinctrl: sirf: atlas7: use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo {
int stuff;
void *entry[];
};instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
--- drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/sirf/pinctrl-atlas7.c +2 -2
@@ -6007,8 +6007,8 @@ static int atlas7_gpio_probe(struct platform_device *pdev) }/* retrieve gpio descriptor data */ - a7gc =devm_kzalloc (&pdev->dev,sizeof (*a7gc) + -sizeof (struct atlas7_gpio_bank ) * nbank,GFP_KERNEL ); + a7gc =devm_kzalloc (&pdev->dev,struct_size (a7gc, banks, nbank), +GFP_KERNEL );if (!a7gc)return -ENOMEM ;
Signature · 1 line
2.20.1
Quoted 11 lines · Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example:
struct foo { int stuff; void *entry[]; };instance =
devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);
Quoted 8 lines
Instead of leaving these open-coded and prone to type mistakes, we can now use the new
struct_size()helper:instance =
devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch applied.
Yours,
Linus Walleij