Skip to contentSkip to conversation

regulator: bcm590xx: Fix .enable_reg for BCM590XX_REG_VSR

PATCH New Axel Lin 1 participant 1 message Jan 5, 2019 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: bcm590xx: Fix .enable_reg for BCM590XX_REG_VSR

Current implementation missed the case BCM590XX_REG_VSR, so bcm590xx_get_enable_register() returns 0 when id is BCM590XX_REG_VSR.

---
Hi Matt,
Current code looks strange becasue bcm590xx_get_enable_register() returns 0 for BCM590XX_REG_VSR but there is a BCM590XX_VSRPMCTRL1 defined in the code. I don't have the h/w, and I even cannot find the datasheet on the internet. I might be wrong, but just in case this might fix a real bug. Please help to review and test this patch.

Thanks,
Axel

 drivers/regulator/bcm590xx-regulator.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/regulator/bcm590xx-regulator.c +4 -0
index 92d6d7b10cf7..e49c0a7d5dd5 100644
@@ -242,8 +242,12 @@ static int bcm590xx_get_enable_register(int id)
 		case BCM590XX_REG_SDSR2:
 			reg = BCM590XX_SDSR2PMCTRL1;
 			break;
+		case BCM590XX_REG_VSR:
+			reg = BCM590XX_VSRPMCTRL1;
+			break;
 		case BCM590XX_REG_VBUS:
 			reg = BCM590XX_OTG_CTRL;
+			break;
 		}
 
 
Signature · 1 line
2.17.1