ACPI / LPSS: Make PCI dependency explicit
Subsystems (12)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v6 1/11 ACPI / LPSS: Make PCI dependency explicit
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")', it is possible to build ACPI without any PCI support. This code depends on PCI. Compile only when PCI is present.
--- drivers/acpi/Makefile | 3 ++- drivers/acpi/internal.h | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/acpi/Makefile +2 -1
@@ -41,7 +41,8 @@ acpi-y += ec.o acpi-$(CONFIG_ACPI_DOCK) += dock.o acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o -acpi-y += acpi_lpss.o acpi_apd.o +acpi-$(CONFIG_PCI) += acpi_lpss.o +acpi-y += acpi_apd.o acpi-y += acpi_platform.o acpi-y += acpi_pnp.o acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
drivers/acpi/internal.h +4 -0
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);#else static inline void acpi_debugfs_init (void ) {return ; }#endif +#ifdef CONFIG_PCI void acpi_lpss_init (void ); +#else +static inline void acpi_lpss_init (void ) {} +#endif void acpi_apd_init (void );
Signature · 1 line
2.19.0
PATCH v6 2/11 ata: pata_acpi: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. PATA_ACPI is a PCI device driver but the PCI dependency has not been explicitly called out.
--- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/Kconfig +1 -1
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers" config PATA_ACPI tristate "ACPI firmware driver for PATA" - depends on ATA_ACPI && ATA_BMDMA + depends on ATA_ACPI && ATA_BMDMA && PCI help This option enables an ACPI method driver which drives motherboard PATA controller interfaces through the ACPI
Signature · 1 line
2.19.0
PATCH v6 3/11 vga-switcheroo: make PCI dependency explicit
In reply to a message not in the archiveThis driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
--- drivers/gpu/vga/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/vga/Kconfig +1 -0
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO bool "Laptop Hybrid Graphics - GPU switching support" depends on X86 depends on ACPI + depends on PCI select VGA_ARB help Many laptops released in 2008/9/10 have two GPUs with a multiplexer
Signature · 6 lines
2.19.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v6 4/11 platform/x86: intel_ips: make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. Ipss driver is a PCI device driver but this has not been mentioned anywhere in Kconfig.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL config INTEL_IPS tristate "Intel Intelligent Power Sharing" - depends on ACPI + depends on ACPI && PCI ---help--- Intel Calpella platforms support dynamic power sharing between the CPU and GPU, maximizing performance in a given TDP. This driver,
Signature · 1 line
2.19.0
PATCH v6 5/11 platform/x86: intel_pmc: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. Code relies on PCI for execution. Specify this in the Kconfig.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communication
Signature · 1 line
2.19.0
Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
Quoted 17 lines · CET Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. Code relies on PCI for execution. Specify this in theKconfig.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +0
-0
drivers/platform/x86/Kconfig config INTEL_SMARTCONNECT · line 1180
Quoted 8 lines
drivers/platform/x86/Kconfig +1
-1@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communication
Andy, you had some reservations regarding this patch IIRC.
Should I apply it?
Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
Quoted 30 lines · Rafael J. Wysocki
Quoted 17 lines · CET Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. Code relies on PCI for execution. Specify this in theKconfig.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +0
-0drivers/platform/x86/Kconfig config INTEL_SMARTCONNECT · line 1180
Quoted 8 lines
drivers/platform/x86/Kconfig +1
-1@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communicationAndy, you had some reservations regarding this patch IIRC.
Quoted 1 line
Should I apply it?
Let's do it as a quick fix with something like below being added to the commit message:
"For sake of a quick fix this introduces a new mandatory dependency to the driver which may survive without it. Otherwise we need to revisit the driver architecture to address this properly."
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v6 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
Quoted 31 lines · CET Andy Shevchenko
Quoted 30 lines · Rafael J. Wysocki
Quoted 17 lines · CET Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. Code relies on PCI for execution. Specify this in theKconfig.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +0
-0drivers/platform/x86/Kconfig config INTEL_SMARTCONNECT · line 1180
Quoted 8 lines
drivers/platform/x86/Kconfig +1
-1@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communicationAndy, you had some reservations regarding this patch IIRC.
Quoted 8 lines
Quoted 1 line
Should I apply it?
Let's do it as a quick fix with something like below being added to the commit message:
"For sake of a quick fix this introduces a new mandatory dependency to the driver which may survive without it. Otherwise we need to revisit the driver architecture to address this properly."
Done, thanks!
PATCH v6 6/11 platform/x86: apple-gmux: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1135,7 +1135,7 @@ config SAMSUNG_Q10 config APPLE_GMUX tristate "Apple Gmux Driver" - depends on ACPI + depends on ACPI && PCI depends on PNP depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
Signature · 1 line
2.19.0
PATCH v6 7/11 drivers: thermal: int3406_thermal: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. Need CONFIG_PCI to be set in order to be able to use this driver.
--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/intel/int340x_thermal/Kconfig +1 -1
@@ -31,7 +31,7 @@ if INT340X_THERMAL config INT3406_THERMAL tristate "ACPI INT3406 display thermal driver" - depends on ACPI_VIDEO + depends on ACPI_VIDEO && PCI help The display thermal device represents the LED/LCD display panel that may or may not include touch support. The main function of
Signature · 1 line
2.19.0
Rafael J. Wysocki
maintainerRe: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
Quoted 18 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. NeedCONFIG_PCIto be set in order to be able to use this driver.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/intel/int340x_thermal/Kconfig +0
-0
drivers/thermal/intel/int340x_thermal/Kconfig if INT340X_THERMAL
Quoted 9 lines
drivers/thermal/intel/int340x_thermal/Kconfig +1
-2@@ -31,7 +31,7 @@ if INT340X_THERMAL config INT3406_THERMAL tristate "ACPI INT3406 display thermal driver" - depends on ACPI_VIDEO + depends on ACPI_VIDEO && PCI help The display thermal device represents the LED/LCD display panel that may or may not include touch support. The main function of --
Rui, any objections here? And for the [11/11]?
Zhang Rui
reviewerRe: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
Quoted 25 lines · Rafael J. Wysocki
Quoted 24 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. NeedCONFIG_PCIto be set in order to be able to use
this driver.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCIset")Signed-off-by Sinan Kaya <[email protected]>---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/intel/int340x_thermal/Kconfig +0
-0@@ -31,7 +31,7 @@ if INT340X_THERMAL
Quoted 11 lines
Quoted 10 lines
config
INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends onACPI_VIDEO
+ depends onACPI_VIDEO&& PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--Rui, any objections here? And for the [11/11]?
CONFIG_INT3406_THERMAL depends on CONFIG_INT340X_THERMAL, so IMO, patch 11 is sufficient.
thanks,
rui
Re: [PATCH v6 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
Quoted 39 lines · Zhang Rui
Quoted 25 lines · Rafael J. Wysocki
Quoted 24 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. NeedCONFIG_PCIto be set in order to be able to use
this driver.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCIset")Signed-off-by Sinan Kaya <[email protected]>--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/thermal/intel/int340x_thermal/Kconfig +0
-0@@ -31,7 +31,7 @@ if INT340X_THERMALQuoted 11 lines
Quoted 10 lines
drivers/thermal/intel/int340x_thermal/Kconfig +1
-1config INT3406_THERMAL tristate "ACPI INT3406 display thermal driver" - depends on ACPI_VIDEO + depends on ACPI_VIDEO && PCI help The display thermal device represents the LED/LCD displaypanel
that may or may not include touch support. The main
function of
--Rui, any objections here? And for the [11/11]?
Quoted 2 lines
CONFIG_INT3406_THERMALdepends onCONFIG_INT340X_THERMAL, so IMO, patch 11 is sufficient.
Yes, we can drop this patch. I found the issues in reverse order. Can we get an ACK for 11/11?
Quoted 3 lines
thanks,
rui
PATCH v6 8/11 ASoC: Intel: atom: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This code relies on IOSF_MBI and IOSF_MBI depends on PCI. For this reason, add a direct dependency on CONFIG_PCI to the IOSF_MBI driver.
--- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/Kconfig +1 -1
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH
Signature · 1 line
2.19.0
Rafael J. Wysocki
maintainerRe: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 10 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This code relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency onCONFIG_PCIto theIOSF_MBIdriver.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>
Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
Quoted 9 lines
--- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/intel/Kconfig +0
-0
sound/soc/intel/Kconfig config SND_SST_ATOM_HIFI2_PLATFORM_PCI
Quoted 9 lines
sound/soc/intel/Kconfig +1
-2@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH --
Mark, assuming that the ACK above was given here, do you want me to take this patch or do you want to take care of it yourself?
Mark Brown
maintainerRe: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 6 lines · Rafael J. Wysocki
Quoted 2 lines · Sinan Kaya
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
Yes. I've also applied it already and it's *still* being sent without either a cover letter or the rest of the series :(
Sinan:
Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.
Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 11 lines · Mark Brown
Quoted 6 lines · Rafael J. Wysocki
Quoted 2 lines · Sinan Kaya
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
Yes. I've also applied it already and it's *still* being sent without either a cover letter or the rest of the series :(
There is a cover letter but it is being sent to Linux-acpi and Linux-next only.
https://patchwork.kernel.org/cover/10749203/
This means that you are not on either of these mailing lists.
Quoted 8 lines
Sinan:
Please do not submit new versions of already applied patches, please submit incremental updates to the existing code. Modifying existing commits creates problems for other users building on top of those commits so it's best practice to only change pubished git commits if absolutely essential.
I apologize. I didn't realize that you applied this already. I'll drop this patch
in case I need to submit a new revision.
Mark Brown
maintainerRe: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 10 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
Yes. I've also applied it already and it's *still* being sent without either a cover letter or the rest of the series :(
There is a cover letter but it is being sent to Linux-acpi and Linux-next only.
https://patchwork.kernel.org/cover/10749203/
This means that you are not on either of these mailing lists.
No, it means that neither of those lists is going into my inbox directly - the cover letters really need to go through the same route as the patches to ensure that they're seen. People often read the lists at different times to their inbox, for example I prioritize reviewing things that are in my inbox and look at list traffic less frequently when my inbox is busy (as it tends to be most of the time).
Quoted 3 lines
I apologize. I didn't realize that you applied this already. I'll drop this patch
in case I need to submit a new revision.
You should have got this mail when it was applied:
http://mailman.alsa-project.org/pipermail/alsa-devel/2019-January/143687.html
Re: [PATCH v6 08/11] ASoC: Intel: atom: Make PCI dependency explicit
In reply to Rafael J. WysockiQuoted 10 lines · Rafael J. Wysocki
Quoted 8 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This code relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency onCONFIG_PCIto theIOSF_MBIdriver.
Quoted 5 lines
Quoted 2 lines
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>Sinan, I thought you received an ACK from Pierre-Louis on this one, didn't you?
Yes, there was an ack assuming that I fixed the ia64 kconfig. Since I didn't, I took it back.
Later ia64 failure was fixed by another patchset and Pierre-Louis said "looks good to me". I didn't
assume it was an ack unless explicitly stated.
It might be good if Pierre-Louis acked this version instead.
Quoted 21 lines
Quoted 9 lines
--- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/intel/Kconfig +0
-0sound/soc/intel/Kconfig config SND_SST_ATOM_HIFI2_PLATFORM_PCI
Quoted 9 lines
sound/soc/intel/Kconfig +1
-2@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH --Mark, assuming that the ACK above was given here, do you want me to take this patch or do you want to take care of it yourself?
PATCH v6 9/11 mmc: sdhci-acpi: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
@@ -116,7 +116,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers,
Signature · 1 line
2.19.0
Rafael J. Wysocki
maintainerRe: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
Quoted 18 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +0
-0
drivers/mmc/host/Kconfig config MMC_RICOH_MMC
Quoted 9 lines
drivers/mmc/host/Kconfig +1
-2@@ -116,7 +116,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers, --
Any objections against this one from anyone?
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
Quoted 20 lines · Rafael J. Wysocki
Quoted 19 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +0
-0@@ -116,7 +116,7 @@ config MMC_RICOH_MMC
Quoted 10 lines
drivers/mmc/host/Kconfig config MMC_RICOH_MMC
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-2config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers, --Any objections against this one from anyone?
+ QCOM and AMD contributors
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
Hi
Quoted 32 lines · Adrian Hunter
Quoted 20 lines · Rafael J. Wysocki
Quoted 19 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +0
-0@@ -116,7 +116,7 @@ config MMC_RICOH_MMCQuoted 10 lines
drivers/mmc/host/Kconfig config MMC_RICOH_MMC
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-2config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers, --Any objections against this one from anyone?
Quoted 2 lines
+ QCOM and AMD contributors
No issues with us as we have separate PCI based driver and ACPI based driver.
Regards
Nehal Shah
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
In reply to Adrian HunterQuoted 29 lines · Adrian Hunter
Quoted 19 lines · Rafael J. Wysocki
Quoted 18 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +0
-0@@ -116,7 +116,7 @@ config MMC_RICOH_MMCQuoted 9 lines
drivers/mmc/host/Kconfig config MMC_RICOH_MMC
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-2config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers, --Any objections against this one from anyone?
Quoted 2 lines
+ QCOM and AMD contributors
No issue with QCOM.
Cheers
Dongsheng
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
In reply to Sinan KayaQuoted 9 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
In reply to Sinan KayaQuoted 8 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>
Quoted 18 lines
--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +1
-1@@ -116,7 +116,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers,
Re: [PATCH v6 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
In reply to Sinan KayaQuoted 9 lines · Sinan Kaya
After 'commit
5d32a66541c4("PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset")' dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. This driver relies onIOSF_MBIandIOSF_MBIdepends on PCI. For this reason, add a direct dependency toCONFIG_PCIhere.Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>
Applied for fixes, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig +1
-2@@ -116,7 +116,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" - depends on MMC_SDHCI && ACPI + depends on MMC_SDHCI && ACPI && PCI select IOSF_MBI if X86 help This selects support for ACPI enumerated SDHCI controllers, --2.19.0
PATCH v6 10/11 x86/intel/lpss: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. LPSS code relies on PCI infrastructure but this dependency has not been explicitly called out.
--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
@@ -618,7 +618,7 @@ config X86_INTEL_QUARK config X86_INTEL_LPSS bool "Intel Low Power Subsystem Support" - depends on X86 && ACPI + depends on X86 && ACPI && PCI select COMMON_CLK select PINCTRL select IOSF_MBI
Signature · 1 line
2.19.0
PATCH v6 11/11 drivers: thermal: int340x_thermal: Make PCI dependency explicit
In reply to a message not in the archiveAfter 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. IOSF_CORE depends on PCI. For this reason, add a direct dependency on CONFIG_PCI.
--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/intel/int340x_thermal/Kconfig +1 -1
@@ -4,7 +4,7 @@ config INT340X_THERMAL tristate "ACPI INT340X thermal drivers" - depends on X86 && ACPI + depends on X86 && ACPI && PCI select THERMAL_GOV_USER_SPACE select ACPI_THERMAL_REL select ACPI_FAN
Signature · 1 line
2.19.0