Skip to contentSkip to conversation

lib/power: fix freq list function to handle null

PATCH Applied David Hunt 2 participants 2 messages Jan 7, 2019 – Jan 14, 2019

lore
Share & tools
lore

David Hunt

author
#0 lore raw

PATCH 1/1 lib/power: fix freq list function to handle null

This patch fixes a segfault in the case where a null buffer is passed to the following functions:
power_acpi_cpufreq_freqs()
power_pstate_cpufreq_freqs()

Fixes 445c6528b55f ("power: common interface for guest and host")
---
 lib/librte_power/power_acpi_cpufreq.c   | 5 +++++
 lib/librte_power/power_pstate_cpufreq.c | 5 +++++
 2 files changed, 10 insertions(+)
lib/librte_power/power_acpi_cpufreq.c +5 -0
index cd5978d5b..98dcde31d 100644
@@ -441,6 +441,11 @@ power_acpi_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
 		return 0;
 	}
 
+	if (freqs == NULL) {
+		RTE_LOG(ERR, POWER, "NULL buffer supplied\n");
+		return 0;
+	}
+
 	pi = &lcore_power_info[lcore_id];
 	if (num < pi->nb_freqs) {
 		RTE_LOG(ERR, POWER, "Buffer size is not enough\n");
lib/librte_power/power_pstate_cpufreq.c +5 -0
index 411d0eb16..0a566eb07 100644
@@ -580,6 +580,11 @@ power_pstate_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
 		return -1;
 	}
 
+	if (freqs == NULL) {
+		RTE_LOG(ERR, POWER, "NULL buffer supplied\n");
+		return 0;
+	}
+
 	pi = &lcore_power_info[lcore_id];
 	if (num < pi->nb_freqs) {
 		RTE_LOG(ERR, POWER, "Buffer size is not enough\n");
Signature · 1 line
2.17.1
#1 lore raw

07/01/2019 15:39, David Hunt:

Quoted 8 lines

This patch fixes a segfault in the case where a null buffer is passed to the following functions:
power_acpi_cpufreq_freqs()
power_pstate_cpufreq_freqs()

Fixes 445c6528b55f ("power: common interface for guest and host")

Applied, thanks