lib/power: fix return code to unsigned value
PATCH 1/1 lib/power: fix return code to unsigned value
The power_pstate_cpufreq_freqs() function was returning -1 in an unsigned int, causing buffer over-runs when the results were being processed. This function should be returning zero for all error conditions, similar to it's acpi relation, power_acpi_cpufreq_freqs().
Fixes e6c6dc0f96c8 ("power: add p-state driver compatibility")
Signed-off-by David Hunt <[email protected]>
--- lib/librte_power/power_pstate_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_power/power_pstate_cpufreq.c +1 -1
@@ -577,7 +577,7 @@ power_pstate_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)if (lcore_id >=RTE_MAX_LCORE ) {RTE_LOG (ERR ,POWER ,"Invalid lcore ID\n" ); -return -1 ; +return 0 ; }if (freqs ==NULL ) {
Signature · 1 line
2.17.1
Thomas Monjalon
Applied07/01/2019 15:40, David Hunt:
Quoted 8 lines
The
power_pstate_cpufreq_freqs()function was returning -1 in an unsigned int, causing buffer over-runs when the results were being processed. This function should be returning zero for all error conditions, similar to it's acpi relation,power_acpi_cpufreq_freqs().Fixes e6c6dc0f96c8 ("power: add p-state driver compatibility")Signed-off-by David Hunt <[email protected]>
Applied, thanks