Skip to contentSkip to conversation

+ proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree

DISCUSSION Alexey Dobriyan 2 participants 2 messages Jan 7, 2019 1 message not in the archive Proc filesystem

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20190107223609.Z6BC6rJ1M%[email protected]

#1 lore raw

Review

Quoted 6 lines · On Mon, Jan 07, 2019 at 02:36:09PM -0800, [email protected] wrote:

Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes

WARNING: Block comments use * on subsequent lines
#56: FILE: fs/proc/proc_net.c:44:

(quoted diff) +2 -0
+	// /proc/net/* can be changed under us by setns(CLONE_NEWNET)
+	pde->proc_dops = &simple_dentry_operations;

I did it on purpose! Otherwise default vim colouring marks "/*" in red because it is comment without "*/"

#2 lore raw
Quoted 10 lines · On Tue, 8 Jan 2019 02:37:20 +0300 Alexey Dobriyan <[email protected]> wrote:

Review

Quoted 6 lines · On Mon, Jan 07, 2019 at 02:36:09PM -0800, [email protected] wrote:

Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes

WARNING: Block comments use * on subsequent lines
#56: FILE: fs/proc/proc_net.c:44:

(quoted diff) +2 -0
+	// /proc/net/* can be changed under us by setns(CLONE_NEWNET)
+	pde->proc_dops = &simple_dentry_operations;

I did it on purpose! Otherwise default vim colouring marks "/*" in red because it is comment without "*/"

There's always a way ;)

fs/proc/proc_net.c renamed from fs/proc/proc_net.c~proc-fix-proc-net-after-setns2-checkpatch-fixes-fix +1 -1
@@ -40,7 +40,7 @@ static struct net *get_proc_net(const st
 
 static void pde_force_lookup(struct proc_dir_entry *pde)
 {
-	/* /proc/net/* can be changed under us by setns(CLONE_NEWNET) */
+	/* /proc/net/ entries can be changed under us by setns(CLONE_NEWNET) */
 	pde->proc_dops = &simple_dentry_operations;
 }
 

_