Skip to contentSkip to conversation

phy: ti: Fix compilation failures without REGMAP

PATCH Applied Jason Gunthorpe 2 participants 2 messages Jan 7, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: ti: Fix compilation failures without REGMAP

This driver requires regmap or the compile fails:

drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];

Add it to kconfig.

---
 drivers/phy/ti/Kconfig | 1 +
 1 file changed, 1 insertion(+)

.. and this is why I'm even compiling this thing when I'm not doing anything with CPSW ..

drivers/phy/ti/Kconfig +1 -0
index f137e010776463..c4709ed7fb0e72 100644
@@ -82,6 +82,7 @@ config PHY_TI_GMII_SEL
 	default y if TI_CPSW=y
 	depends on TI_CPSW || COMPILE_TEST
 	select GENERIC_PHY
+	select REGMAP
 	default m
 	help
 	  This driver supports configuring of the TI CPSW Port mode depending on
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

From: Jason Gunthorpe <[email protected]>
Date: Mon, 7 Jan 2019 17:54:14 +0000

Quoted 8 lines

This driver requires regmap or the compile fails:

drivers/phy/ti/phy-gmii-sel.c:43:27: error: array type has incomplete element type ‘struct reg_field’
const struct reg_field (*regfields)[PHY_GMII_SEL_LAST];

Add it to kconfig.

Applied.