ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
PATCH 1/1 ARM: dts: omap4-droid4: Fix typo in cpcap IRQ flags
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
--- arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +1 -1
@@ -105,7 +105,7 @@ interrupts-extended = < &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0 &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0 - &cpcap 48 1 + &cpcap 48 0 >; interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld",
Signature · 1 line
2.20.1
Rob Herring
maintainerQuoted 10 lines · Tony Lindgren
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (
regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
Hopefully, you mean a driver fix later and not changing the DT again? A 0 flag is correct if the type is not programmable which I'd guess is the case here.
Rob
Quoted 8 lines · Rob Herring
Quoted 7 lines · Tony Lindgren
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (
regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
Quoted 7 lines
Quoted 3 lines
This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
Hopefully, you mean a driver fix later and not changing the DT again? A 0 flag is correct if the type is not programmable which I'd guess is the case here.
Oh OK thanks for letting me know. In that case with 0 being correct for non-programmable interrupts, I'll just drop that paragraph and no need for further changes. The driver should be already doing the right thing.
Regards,
Tony
Quoted 11 lines · Tony Lindgren
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (
regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
Reported-by Pavel Machek <[email protected]>
Thanks for doing this.
Pavel
Quoted 11 lines
arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +1
-1@@ -105,7 +105,7 @@ interrupts-extended = < &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0 &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0 - &cpcap 48 1 + &cpcap 48 0 >; interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld",
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
Quoted 9 lines
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (
regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
Could we get this one applied? It is regression fix for 5.0-rc1...
Pavel
Quoted 20 lines
Reported-by Pavel Machek <[email protected]>Cc Pavel Machek <[email protected]>Cc Sebastian Reichel <[email protected]>Signed-off-by Tony Lindgren <[email protected]>--- arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/motorola-cpcap-mapphone.dtsi +1
-1@@ -105,7 +105,7 @@ interrupts-extended = < &cpcap 15 0 &cpcap 14 0 &cpcap 28 0 &cpcap 19 0 &cpcap 18 0 &cpcap 17 0 &cpcap 16 0 &cpcap 49 0 - &cpcap 48 1 + &cpcap 48 0 >; interrupt-names = "id_ground", "id_float", "se0conn", "vbusvld",
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 8 lines · Pavel Machek
Hi!
Quoted 6 lines
We're now getting the following error:
genirq: Setting trigger mode 1 for irq 230 failed (
regmap_irq_set_type+0x0/0x15c)
cpcap-usb-phy cpcap-usb-phy.0: could not get irq dp: -524
Quoted 5 lines
Quoted 3 lines
This is because of a typo in the irq flags. Really these interrupts are LEVEL, but before we change them we need to test them. So let's do a minimal fix first.
Could we get this one applied? It is regression fix for 5.0-rc1...
Yes thanks for reminding me, was planning to send off the first set earlier but got hit with more regressions and delays. Anyways, I just sent a pull request for the dts regressions.
Regards,
Tony