Skip to contentSkip to conversation

ARM: dts: omap3-gta04: Fix graph_port warning

PATCH In review Tony Lindgren 4 participants 10 messages Jan 7, 2019 – Jan 9, 2019 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap3-gta04: Fix graph_port warning

We're currently getting a warning with make dtbs:

arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
/ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit address error, expected "0"

Cc H. Nikolaus Schaller <[email protected]>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap3-gta04.dtsi +1 -1
@@ -717,7 +717,7 @@
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	port {
+	port@0 {
 		reg = <0>;
 		venc_out: endpoint {
 			remote-endpoint = <&opa_in>;
Signature · 1 line
2.20.1
#1 lore raw

Hi Tony,

Quoted 7 lines

Am 07.01.2019 um 17:05 schrieb Tony Lindgren <[email protected]>:

We're currently getting a warning with make dtbs:

arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
/ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit address error, expected "0"

yes, dtc has become more critical nowadays...

To me it looks like redundant information, but it is how it is.

Quoted 11 lines
Cc H. Nikolaus Schaller <[email protected]>

---
arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/omap3-gta04.dtsi line 723

Quoted 8 lines
arch/arm/boot/dts/omap3-gta04.dtsi +1 -1
@@ -717,7 +717,7 @@
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	port {
+	port@0 {
 		reg = <0>;
 		venc_out: endpoint {
 			remote-endpoint = <&opa_in>;

Looks good to me.

BR and thanks,
NIkolaus

maintainer
#2 lore raw
Quoted 7 lines · H. Nikolaus Schaller

Hi Tony,

Quoted 4 lines

Am 07.01.2019 um 17:05 schrieb Tony Lindgren <[email protected]>:

We're currently getting a warning with make dtbs:

Quoted 7 lines
Quoted 3 lines

arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
/ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit address error, expected "0"

yes, dtc has become more critical nowadays...

To me it looks like redundant information, but it is how it is.

If there's only one port, then it is redundant and you should drop reg instead. There should be a warning for that too. That one is probably off by default as that's more subjective and noisy.

Rob

#3 lore raw
Quoted 12 lines · Rob Herring
Quoted 11 lines · H. Nikolaus Schaller

Hi Tony,

Quoted 7 lines

Am 07.01.2019 um 17:05 schrieb Tony Lindgren <[email protected]>:

We're currently getting a warning with make dtbs:

arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
/ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit address error, expected "0"

Quoted 7 lines
Quoted 3 lines

yes, dtc has become more critical nowadays...

To me it looks like redundant information, but it is how it is.

If there's only one port, then it is redundant and you should drop reg instead. There should be a warning for that too. That one is probably off by default as that's more subjective and noisy.

OK dropping this patch. Nikolaus, care to post a better version since you can test it?

Regards,

Tony

#4 lore raw
Quoted 22 lines

Am 07.01.2019 um 19:34 schrieb Tony Lindgren <[email protected]>:

Quoted 18 lines · Rob Herring
Quoted 7 lines · H. Nikolaus Schaller

Hi Tony,

Quoted 4 lines

Am 07.01.2019 um 17:05 schrieb Tony Lindgren <[email protected]>:

We're currently getting a warning with make dtbs:

Quoted 7 lines
Quoted 3 lines

arch/arm/boot/dts/omap3-gta04.dtsi:720.7-727.4: Warning (graph_port):
/ocp@68000000/dss@48050000/encoder@48050c0 0/port: graph node unit address error, expected "0"

yes, dtc has become more critical nowadays...

To me it looks like redundant information, but it is how it is.

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

Quoted 9 lines
Quoted 2 lines

There should be a warning for that too. That one is probably off by default as that's more subjective and noisy.

OK dropping this patch. Nikolaus, care to post a better version since you can test it?

Regards,

Tony

#5 lore raw
Quoted 6 lines · H. Nikolaus Schaller
Quoted 2 lines
Quoted 2 lines

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

I don't think so. The code looks for 'reg', but if it's not there, then it's considered 0.

Tomi

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#6 lore raw
Quoted 11 lines · Tomi Valkeinen
Quoted 6 lines · H. Nikolaus Schaller
Quoted 2 lines
Quoted 2 lines

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

I don't think so. The code looks for 'reg', but if it's not there, then it's considered 0.

FYI, the binding doc for the graph bindings is at Documentation/devicetree/bindings/graph.txt if there is any questions on how things should work.

Regards,

Tony

#7 lore raw

Ho Tony, Tomi,

Quoted 12 lines

Am 08.01.2019 um 16:56 schrieb Tony Lindgren <[email protected]>:

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · H. Nikolaus Schaller
Quoted 2 lines
Quoted 2 lines

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

Quoted 6 lines
Quoted 2 lines

I don't think so. The code looks for 'reg', but if it's not there, then it's considered 0.

FYI, the binding doc for the graph bindings is at Documentation/devicetree/bindings/graph.txt if there is any questions on how things should work.

I interpret it that "port@number" is only needed if there are multiple ports and there should not be any "@" or "reg" for the single port case. Although it seems not to be explicitly forbidden.

The &dss port doesn't have it either.

So let's remove the reg = <0>;

It also seems that

	#address-cells = <1>;
	#size-cells = <0>;

is not required in this case and can also be removed.

I've tested and it works with v5.0-rc1.

There is an edited patch [1] but IMHO you as the original author should post it.

BR,
Nikolaus

[1]: http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=e46369390f62ce7176e91dfa443185e4b097ef4b

#8 lore raw
Quoted 35 lines · H. Nikolaus Schaller

Ho Tony, Tomi,

Quoted 12 lines

Am 08.01.2019 um 16:56 schrieb Tony Lindgren <[email protected]>:

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · H. Nikolaus Schaller
Quoted 2 lines
Quoted 2 lines

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

Quoted 6 lines
Quoted 2 lines

I don't think so. The code looks for 'reg', but if it's not there, then it's considered 0.

FYI, the binding doc for the graph bindings is at Documentation/devicetree/bindings/graph.txt if there is any questions on how things should work.

I interpret it that "port@number" is only needed if there are multiple ports and there should not be any "@" or "reg" for the single port case. Although it seems not to be explicitly forbidden.

The &dss port doesn't have it either.

So let's remove the reg = <0>;

It also seems that

	#address-cells = <1>;
	#size-cells = <0>;
Quoted 6 lines

is not required in this case and can also be removed.

I've tested and it works with v5.0-rc1.

There is an edited patch [1] but IMHO you as the original author should post it.

Looks good to me. But since you already modified it, all you need to do is add your Signed-off-by after mine and mail it out :) That is if you want to keep me as the original author I guess for the description.

Otherwise we have to go through one more round of emails where I post it you ack it and so on as I can't test it.

Regards,

Tony

Quoted 1 line

[1]: http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=e46369390f62ce7176e91dfa443185e4b097ef4b

#9 lore raw

Hi Tony,

Quoted 40 lines

Am 09.01.2019 um 18:01 schrieb Tony Lindgren <[email protected]>:

Quoted 37 lines · H. Nikolaus Schaller

Ho Tony, Tomi,

Quoted 12 lines

Am 08.01.2019 um 16:56 schrieb Tony Lindgren <[email protected]>:

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · H. Nikolaus Schaller
Quoted 2 lines
Quoted 2 lines

If there's only one port, then it is redundant and you should drop reg instead.

If I remember correctly it was required by older omapdrm code (which did scan for a reg property) but that may have changed. Therefore I've added Tomi to this discussion.

Quoted 6 lines
Quoted 2 lines

I don't think so. The code looks for 'reg', but if it's not there, then it's considered 0.

FYI, the binding doc for the graph bindings is at Documentation/devicetree/bindings/graph.txt if there is any questions on how things should work.

I interpret it that "port@number" is only needed if there are multiple ports and there should not be any "@" or "reg" for the single port case. Although it seems not to be explicitly forbidden.

The &dss port doesn't have it either.

So let's remove the reg = <0>;

It also seems that

	#address-cells = <1>;
	#size-cells = <0>;

is not required in this case and can also be removed.

Quoted 8 lines
Quoted 4 lines

I've tested and it works with v5.0-rc1.

There is an edited patch [1] but IMHO you as the original author should post it.

Looks good to me. But since you already modified it, all you need to do is add your Signed-off-by after mine and mail it out :)

Well, the main job is mailing it out (collecting the destination addresses)...

Quoted 5 lines

That is if you want to keep me as the
original author I guess for the description.

Otherwise we have to go through one more round of emails where I post it you ack it and so on as I can't test it.

Anyways, I send it asap.

BR,
Nikolaus

Quoted 6 lines

Regards,

Tony

Quoted 1 line

[1]: http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=e46369390f62ce7176e91dfa443185e4b097ef4b