Skip to contentSkip to conversation

Provides puredata package

PATCH New Mitchell Dokken 3 participants 6 messages Jan 8, 2019 – Jan 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Provides puredata package

---
 package/Config.in              |  1 +
 package/puredata/Config.in     | 12 ++++++++++++
 package/puredata/puredata.hash |  2 ++
 package/puredata/puredata.mk   | 34 ++++++++++++++++++++++++++++++++++
 4 files changed, 49 insertions(+)
 create mode 100644 package/puredata/Config.in
 create mode 100644 package/puredata/puredata.hash
 create mode 100644 package/puredata/puredata.mk
package/Config.in +1 -0
index 0df9b73088..e029de53db 100644
@@ -45,6 +45,7 @@ menu "Audio and video applications"
 	source "package/on2-8170-libs/Config.in"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
+	source "package/puredata/Config.in"
 	source "package/sox/Config.in"
 	source "package/squeezelite/Config.in"
 	source "package/tovid/Config.in"
package/puredata/Config.in new file +12 -0
new file mode 100644
index 0000000000..c8bafe8885
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+	bool "puredata"
+	select BR2_PACKAGE_TK
+	select BR2_PACKAGE_TCL
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_UTILS
+	select BR2_PACKAGE_XORG7
+	select BR2_PACKAGE_XAPP_XAUTH
+
+	help
+		Graphic realtime audio programming language
+		http://msp.ucsd.edu/software.htm
package/puredata/puredata.hash new file +2 -0
new file mode 100644
index 0000000000..505dbe3679
@@ -0,0 +1,2 @@
+# Locally calculated
+d2e04e75d22b0e41f27daacc0cd6ec6b05ae0ef214cc7315d57e5bfbeec23fa3  pd-0.49-0.src.tar.gz
package/puredata/puredata.mk new file +34 -0
new file mode 100644
index 0000000000..842970b983
@@ -0,0 +1,34 @@
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 Provides puredata package

Mitchell,

Quoted 7 lines · Mitchell Dokken
---
 package/Config.in              |  1 +
 package/puredata/Config.in     | 12 ++++++++++++
 package/puredata/puredata.hash |  2 ++
 package/puredata/puredata.mk   | 34 ++++++++++++++++++++++++++++++++++

If you're up for maintaining this package, I'd suggest adding yourself to the DEVELOPERS file. Then you'll get emails if the build fails when the autobuilder is testing different build configurations.

Quoted 23 lines
 4 files changed, 49 insertions(+)
 create mode 100644 package/puredata/Config.in
 create mode 100644 package/puredata/puredata.hash
 create mode 100644 package/puredata/puredata.mk
package/Config.in +1 -0
index 0df9b73088..e029de53db 100644
@@ -45,6 +45,7 @@ menu "Audio and video applications"
        source "package/on2-8170-libs/Config.in"
        source "package/opus-tools/Config.in"
        source "package/pulseaudio/Config.in"
+       source "package/puredata/Config.in"
        source "package/sox/Config.in"
        source "package/squeezelite/Config.in"
        source "package/tovid/Config.in"
package/puredata/Config.in new file +0 -0
new file mode 100644
index 0000000000..c8bafe8885

package/puredata/Config.in line 8

Quoted 8 lines
package/puredata/Config.in new file +8 -0
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+       bool "puredata"
+       select BR2_PACKAGE_TK
+       select BR2_PACKAGE_TCL
+       select BR2_PACKAGE_ALSA_LIB
+       select BR2_PACKAGE_ALSA_UTILS
+       select BR2_PACKAGE_XORG7
+       select BR2_PACKAGE_XAPP_XAUTH

Each of these selects won't automatically assume the respective "depends on" found in some of those package's Config.in. Please reflect those "depends on" dependencies and comment similar to the example, package/policycoreutils/Config.in with all its libsemanage depends on.

package/puredata/Config.in line 12

Quoted 4 lines
package/puredata/Config.in new file +4 -0
+
+       help
+               Graphic realtime audio programming language
+               http://msp.ucsd.edu/software.htm

Suggest running ./utils/check-package package/puredata/* to check for formatting of the new files.

package/puredata/puredata.hash line 2

Quoted 8 lines
package/puredata/puredata.hash new file +2 -0
new file mode 100644
index 0000000000..505dbe3679
@@ -0,0 +1,2 @@
+# Locally calculated
+d2e04e75d22b0e41f27daacc0cd6ec6b05ae0ef214cc7315d57e5bfbeec23fa3  pd-0.49-0.src.tar.gz

Please fix the format of this hash entry, see
https://buildroot.org/downloads/manual/manual.html#adding-packages-hash
for an example. That looks like a sha256?

Please add a license file hash as well.

Quoted 6 lines
package/puredata/puredata.mk new file +0 -0
new file mode 100644
index 0000000000..842970b983

package/puredata/puredata.mk line 9

Quoted 9 lines
package/puredata/puredata.mk new file +9 -0
@@ -0,0 +1,34 @@
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software

Please add license type and file names. See
https://buildroot.org/downloads/manual/manual.html#generic-package-tutorial
for an example of the use of license variables. Note, I understand this is a autotools pkg type, the generic in the manual had the best license example.

package/puredata/puredata.mk line 11

Quoted 2 lines
package/puredata/puredata.mk new file +2 -0
+PUREDATA_INSTALL_STAGING = YES
+PUREDATA_INSTALL_TARGET = YES

PUREDATA_INSTALL_TARGET is set defaultly to YES, so you can remove the line.

Quoted 26 lines
package/puredata/puredata.mk new file +23 -1
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+       cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
--

2.11.0

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Matt

#2 lore raw

PATCH 1/1 Provides puredata package

In reply to Mitchell Dokken

Mitchell, All,

Thanks for this submission. :-)

In addition to Matt's review, see a few comments below...

On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/puredata/Config.in line 7

Quoted 13 lines
package/puredata/Config.in new file +7 -0
new file mode 100644
index 0000000000..c8bafe8885
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+	bool "puredata"
+	select BR2_PACKAGE_TK
+	select BR2_PACKAGE_TCL
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_ALSA_UTILS
+	select BR2_PACKAGE_XORG7

Do not select Xorg, but depend on it.

package/puredata/Config.in line 8

Quoted 1 line
package/puredata/Config.in new file +1 -0
+	select BR2_PACKAGE_XAPP_XAUTH

... but you can select individual X package.

package/puredata/Config.in line 9

Quoted 1 line
package/puredata/Config.in new file +1 -0
+

No empty line before the help.

package/puredata/Config.in line 12

Quoted 3 lines
package/puredata/Config.in new file +3 -0
+	help
+		Graphic realtime audio programming language
+		http://msp.ucsd.edu/software.htm

Indentation for the help text is TAB-space-space. As suggested by Matt, use:

./utils/check-package package/puredata/*

Also, there is a better-looking homepage for Pure Data, maybe we can use it instead: http://puredata.info/ ?

[--SNIP--]

Quoted 6 lines
package/puredata/puredata.mk new file +0 -0
new file mode 100644
index 0000000000..842970b983

package/puredata/puredata.mk line 10

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
@@ -0,0 +1,34 @@
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES

Why does it need to be installed in staging? Is this providing a library?

Quoted 11 lines
package/puredata/puredata.mk new file +11 -0
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif

package/puredata/puredata.mk line 31

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef

Why do you need to run autogen.sh since you already have PUREDATA_AUTORECONF=YES ?

autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES anyway. The only delta is that it also creates a directory, so your hook should just do that: create the m4/generated directory. Also, make it a post-extract hook.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/puredata/puredata.mk new file +3 -0
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
Signature · 6 lines
2.11.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 21 lines
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
#3 lore raw

PATCH 1/1 Provides puredata package

Thank you, to both of you!

These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?

Quoted 135 lines · On Tue, Jan 8, 2019 at 1:20 AM <[email protected]> wrote:

Mitchell, All,

Thanks for this submission. :-)

In addition to Matt's review, see a few comments below...

On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/puredata/Config.in line 7

Quoted 13 lines
package/puredata/Config.in new file +7 -0
new file mode 100644
index 0000000000..c8bafe8885
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+     bool "puredata"
+     select BR2_PACKAGE_TK
+     select BR2_PACKAGE_TCL
+     select BR2_PACKAGE_ALSA_LIB
+     select BR2_PACKAGE_ALSA_UTILS
+     select BR2_PACKAGE_XORG7

Do not select Xorg, but depend on it.

package/puredata/Config.in line 8

Quoted 1 line
package/puredata/Config.in new file +1 -0
+     select BR2_PACKAGE_XAPP_XAUTH

... but you can select individual X package.

package/puredata/Config.in line 9

Quoted 1 line
package/puredata/Config.in new file +1 -0
+

No empty line before the help.

package/puredata/Config.in line 12

Quoted 3 lines
package/puredata/Config.in new file +3 -0
+     help
+             Graphic realtime audio programming language
+             http://msp.ucsd.edu/software.htm

Indentation for the help text is TAB-space-space. As suggested by Matt, use:

./utils/check-package package/puredata/*

Also, there is a better-looking homepage for Pure Data, maybe we can use it instead: http://puredata.info/ ?

[--SNIP--]

package/puredata/puredata.mk

Quoted 7 lines
package/puredata/puredata.mk new file +0 -0
new file mode 100644
index 0000000000..842970b983
@@ -0,0 +1,34 @@

+################################################################################

package/puredata/puredata.mk line 4

Quoted 4 lines
package/puredata/puredata.mk new file +3 -0
+#
+# puredata
+#

+################################################################################

package/puredata/puredata.mk line 10

Quoted 5 lines
package/puredata/puredata.mk new file +5 -0
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES

Why does it need to be installed in staging? Is this providing a library?

Quoted 11 lines
package/puredata/puredata.mk new file +11 -0
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif

package/puredata/puredata.mk line 31

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef

Why do you need to run autogen.sh since you already have PUREDATA_AUTORECONF=YES ?

autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES anyway. The only delta is that it also creates a directory, so your hook should just do that: create the m4/generated directory. Also, make it a post-extract hook.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/puredata/puredata.mk new file +3 -1
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
--

2.11.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |

'--------------------------------------:______/_____:------------------'

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

Quoted 10 lines

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190108/547eb44b/attachment.html>

#4 lore raw

PATCH 1/1 Provides puredata package

Mitchell,

Quoted 4 lines · Mitchell Dokken

Thank you, to both of you!

These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?

No need to reference this conversation directly, patchwork has recorded this first version of the patch
(http://patchwork.ozlabs.org/patch/1021690/) with all the conversation. One of the maintainers will mark it superseded once your v2 patch is sent out. For the new patch as it's a version 2, it's suggested to include a change log of changes from v1 to v2 (Manual Section 21.5.4 - Patch revision changelog). That manual section also has examples of how to use format patch to generate your v2.

Thanks for the submission!

Quoted 141 lines · On Tue, Jan 8, 2019 at 1:20 AM <[email protected]> wrote:
Quoted 129 lines

Mitchell, All,

Thanks for this submission. :-)

In addition to Matt's review, see a few comments below...

On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/puredata/Config.in line 7

Quoted 13 lines
package/puredata/Config.in new file +7 -0
new file mode 100644
index 0000000000..c8bafe8885
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+     bool "puredata"
+     select BR2_PACKAGE_TK
+     select BR2_PACKAGE_TCL
+     select BR2_PACKAGE_ALSA_LIB
+     select BR2_PACKAGE_ALSA_UTILS
+     select BR2_PACKAGE_XORG7

Do not select Xorg, but depend on it.

package/puredata/Config.in line 8

Quoted 1 line
package/puredata/Config.in new file +1 -0
+     select BR2_PACKAGE_XAPP_XAUTH

... but you can select individual X package.

package/puredata/Config.in line 9

Quoted 1 line
package/puredata/Config.in new file +1 -0
+

No empty line before the help.

package/puredata/Config.in line 12

Quoted 3 lines
package/puredata/Config.in new file +3 -0
+     help
+             Graphic realtime audio programming language
+             http://msp.ucsd.edu/software.htm

Indentation for the help text is TAB-space-space. As suggested by Matt, use:

./utils/check-package package/puredata/*

Also, there is a better-looking homepage for Pure Data, maybe we can use it instead: http://puredata.info/ ?

[--SNIP--]

Quoted 6 lines
package/puredata/puredata.mk new file +0 -0
new file mode 100644
index 0000000000..842970b983

package/puredata/puredata.mk line 10

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
@@ -0,0 +1,34 @@
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES

Why does it need to be installed in staging? Is this providing a library?

Quoted 11 lines
package/puredata/puredata.mk new file +11 -0
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif

package/puredata/puredata.mk line 31

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef

Why do you need to run autogen.sh since you already have PUREDATA_AUTORECONF=YES ?

autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES anyway. The only delta is that it also creates a directory, so your hook should just do that: create the m4/generated directory. Also, make it a post-extract hook.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/puredata/puredata.mk new file +3 -1
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
--

2.11.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |

'--------------------------------------:______/_____:------------------'

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

Quoted 6 lines

This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 23 lines
Matthew Weber | Pr. Software Engineer | Commercial Avionics

COLLINS AEROSPACE

400 Collins Road NE, Cedar Rapids, Iowa 52498, USA

Tel: +1 319 295 7349 | FAX: +1 319 263 6099

matthew.weber at collins.com | collinsaerospace.com



CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.


Any export restricted material should be shared using my
matthew.weber at corp.rockwellcollins.com address.
#5 lore raw

PATCH 1/1 Provides puredata package

Mitchell,

Quoted 11 lines · Matthew Weber

Mitchell,

Quoted 4 lines · Mitchell Dokken

Thank you, to both of you!

These are very helpful. I do have a question: when I fix all these issues, should I do exactly the same thing for the next patch review, or should I somehow reference this conversation?

Quoted 10 lines

No need to reference this conversation directly, patchwork has recorded this first version of the patch
(http://patchwork.ozlabs.org/patch/1021690/) with all the conversation. One of the maintainers will mark it superseded once your v2 patch is sent out. For the new patch as it's a version 2, it's suggested to include a change log of changes from v1 to v2 (Manual Section 21.5.4 - Patch revision changelog). That manual section also has examples of how to use format patch to generate your v2.

I forgot to mention. I'd suggest renaming the commit title to be "package/puredata: new package"

Quoted 170 lines
Quoted 138 lines · On Tue, Jan 8, 2019 at 1:20 AM <[email protected]> wrote:
Quoted 129 lines

Mitchell, All,

Thanks for this submission. :-)

In addition to Matt's review, see a few comments below...

On 2019-01-07 21:26 -0600, Mitchell Dokken spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/puredata/Config.in line 7

Quoted 13 lines
package/puredata/Config.in new file +7 -0
new file mode 100644
index 0000000000..c8bafe8885
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUREDATA
+     bool "puredata"
+     select BR2_PACKAGE_TK
+     select BR2_PACKAGE_TCL
+     select BR2_PACKAGE_ALSA_LIB
+     select BR2_PACKAGE_ALSA_UTILS
+     select BR2_PACKAGE_XORG7

Do not select Xorg, but depend on it.

package/puredata/Config.in line 8

Quoted 1 line
package/puredata/Config.in new file +1 -0
+     select BR2_PACKAGE_XAPP_XAUTH

... but you can select individual X package.

package/puredata/Config.in line 9

Quoted 1 line
package/puredata/Config.in new file +1 -0
+

No empty line before the help.

package/puredata/Config.in line 12

Quoted 3 lines
package/puredata/Config.in new file +3 -0
+     help
+             Graphic realtime audio programming language
+             http://msp.ucsd.edu/software.htm

Indentation for the help text is TAB-space-space. As suggested by Matt, use:

./utils/check-package package/puredata/*

Also, there is a better-looking homepage for Pure Data, maybe we can use it instead: http://puredata.info/ ?

[--SNIP--]

Quoted 6 lines
package/puredata/puredata.mk new file +0 -0
new file mode 100644
index 0000000000..842970b983

package/puredata/puredata.mk line 10

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
@@ -0,0 +1,34 @@
+################################################################################
+#
+# puredata
+#
+################################################################################
+
+PUREDATA_VERSION =  0.49-0
+PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
+PUREDATA_SITE = http://msp.ucsd.edu/Software
+PUREDATA_INSTALL_STAGING = YES

Why does it need to be installed in staging? Is this providing a library?

Quoted 11 lines
package/puredata/puredata.mk new file +11 -0
+PUREDATA_INSTALL_TARGET = YES
+PUREDATA_AUTORECONF = YES
+PUREDATA_CONF_OPTS = --no-recursion --disable-locales
+
+PUREDATA_DEPENDENCIES = alsa-utils tcl tk
+
+ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
+PUREDATA_CONF_OPTS += --enable-portaudio
+else
+PUREDATA_CONF_OPTS += --disable-portaudio
+endif

package/puredata/puredata.mk line 31

Quoted 10 lines
package/puredata/puredata.mk new file +10 -0
+
+ifeq ($(BR2_PACKAGE_JACK2),y)
+PUREDATA_CONF_OPTS += --enable-jack
+else
+PUREDATA_CONF_OPTS += --disable-jack
+endif
+
+define PUREDATA_RUN_AUTOGEN
+     cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef

Why do you need to run autogen.sh since you already have PUREDATA_AUTORECONF=YES ?

autogen.sh basically does just the same as PUREDATA_AUTORECONF=YES anyway. The only delta is that it also creates a directory, so your hook should just do that: create the m4/generated directory. Also, make it a post-extract hook.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/puredata/puredata.mk new file +3 -1
+PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
+
+$(eval $(autotools-package))
--

2.11.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
| +33 534.541.179 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
|      yann.morin (at) orange.com      |_="    ,--' | / \ HTML MAIL    |

'--------------------------------------:______/_____:------------------'

_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

Quoted 6 lines

This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

Matthew Weber | Pr. Software Engineer | Commercial Avionics

COLLINS AEROSPACE

400 Collins Road NE, Cedar Rapids, Iowa 52498, USA

Tel: +1 319 295 7349 | FAX: +1 319 263 6099

matthew.weber at collins.com | collinsaerospace.com

CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information of Collins Aerospace and its affiliated companies. If you are not the intended recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (including all attachments) from your computer. Your cooperation is greatly appreciated.

Any export restricted material should be shared using my matthew.weber at corp.rockwellcollins.com address.

Signature · 23 lines
Matthew Weber | Pr. Software Engineer | Commercial Avionics

COLLINS AEROSPACE

400 Collins Road NE, Cedar Rapids, Iowa 52498, USA

Tel: +1 319 295 7349 | FAX: +1 319 263 6099

matthew.weber at collins.com | collinsaerospace.com



CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.


Any export restricted material should be shared using my
matthew.weber at corp.rockwellcollins.com address.