drm/amd/powerplay: drop the unnecessary uclk hard min setting
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: drop the unnecessary uclk hard min setting
Since soft min setting is enough. Hard min setting is redundant.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0 -7
@@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_ (PPCLK_UCLK << 16) | (min_freq & 0xffff))),"Failed to set soft min memclk !" , return ret); - - min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level; -PP_ASSERT_WITH_CODE (!(ret =smum_send_msg_to_smc_with_parameter ( - hwmgr, PPSMC_MSG_SetHardMinByFreq, - (PPCLK_UCLK <<16 ) | (min_freq &0xffff ))), -"Failed to set hard min memclk !" , - return ret); } if (data->smu_features[GNLD_DPM_UVD].enabled &&
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Alex Deucher
Acked-byQuoted 31 lines · Evan Quan
Since soft min setting is enough. Hard min setting is redundant.
Change-Id I758386085f227bad94148ec0b38776312b6f5b25Reported-by Likun Gao <[email protected]>Signed-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-8@@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_ (PPCLK_UCLK << 16) | (min_freq & 0xffff))),"Failed to set soft min memclk !" , return ret); - - min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level; -PP_ASSERT_WITH_CODE (!(ret =smum_send_msg_to_smc_with_parameter ( - hwmgr, PPSMC_MSG_SetHardMinByFreq, - (PPCLK_UCLK <<16 ) | (min_freq &0xffff ))), -"Failed to set hard min memclk !" , - return ret); } if (data->smu_features[GNLD_DPM_UVD].enabled && --2.20.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Gao, Likun
Reviewed-by Likun Gao-----Original Message-----
From: Evan Quan <[email protected]>
Sent: Tuesday, January 08, 2019 12:28 PM
To: [email protected]
Cc: Gao, Likun <[email protected]>; Feng, Kenneth <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH] drm/amd/powerplay: drop the unnecessary uclk hard min setting
Since soft min setting is enough. Hard min setting is redundant.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0 -7
@@ -1692,13 +1692,6 @@ static int vega20_upload_dpm_min_level(struct pp_hwmgr *hwmgr, uint32_t feature_ (PPCLK_UCLK << 16) | (min_freq & 0xffff))),"Failed to set soft min memclk !" , return ret); - - min_freq = data->dpm_table.mem_table.dpm_state.hard_min_level; -PP_ASSERT_WITH_CODE (!(ret =smum_send_msg_to_smc_with_parameter ( - hwmgr, PPSMC_MSG_SetHardMinByFreq, - (PPCLK_UCLK <<16 ) | (min_freq &0xffff ))), -"Failed to set hard min memclk !" , - return ret); } if (data->smu_features[GNLD_DPM_UVD].enabled &&
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx