Skip to contentSkip to conversation

logging

PATCH In review Russell Coker 2 participants 2 messages Jan 8, 2019 – Jan 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 logging

Prosody and ntpd don't just need append access to their log files.

policy/modules/services/jabber.te +2 -3
Index: refpolicy-2.20180701/policy/modules/services/jabber.te
===================================================================
@@ -80,9 +80,8 @@ allow jabberd_t self:netlink_route_socke
 manage_files_pattern(jabberd_t, jabberd_lock_t, jabberd_lock_t)
 
 allow jabberd_t jabberd_log_t:dir setattr_dir_perms;
-append_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
-create_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
-setattr_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
+manage_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
+
 logging_log_filetrans(jabberd_t, jabberd_log_t, { file dir })
 
 manage_files_pattern(jabberd_domain, jabberd_spool_t, jabberd_spool_t)
policy/modules/services/ntp.te +2 -3
Index: refpolicy-2.20180701/policy/modules/services/ntp.te
===================================================================
@@ -73,9 +73,8 @@ read_lnk_files_pattern(ntpd_t, ntpd_key_
 allow ntpd_t ntpd_lock_t:file rw_file_perms;
 
 allow ntpd_t ntpd_log_t:dir setattr_dir_perms;
-append_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
-create_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
-setattr_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
+manage_dirs_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
+manage_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
 logging_log_filetrans(ntpd_t, ntpd_log_t, { file dir })
 
 manage_files_pattern(ntpd_t, ntpd_pid_t, ntpd_pid_t)
#1 lore raw
Quoted 24 lines · Russell Coker

Prosody and ntpd don't just need append access to their log files.

Index: refpolicy-2.20180701/policy/modules/services/jabber.te
===================================================================

policy/modules/services/jabber.te +2 -3
@@ -80,9 +80,8 @@ allow jabberd_t self:netlink_route_socke
  manage_files_pattern(jabberd_t, jabberd_lock_t, jabberd_lock_t)
 
  allow jabberd_t jabberd_log_t:dir setattr_dir_perms;
-append_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
-create_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
-setattr_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
+manage_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t)
+
  logging_log_filetrans(jabberd_t, jabberd_log_t, { file dir })
 
  manage_files_pattern(jabberd_domain, jabberd_spool_t, jabberd_spool_t)

Index: refpolicy-2.20180701/policy/modules/services/ntp.te
===================================================================

policy/modules/services/ntp.te +0 -0
@@ -73,9 +73,8 @@ read_lnk_files_pattern(ntpd_t, ntpd_key_
  allow ntpd_t ntpd_lock_t:file rw_file_perms;

policy/modules/services/ntp.te read_lnk_files_pattern(ntpd_t, ntpd_key_ · line 80

Quoted 10 lines
policy/modules/services/ntp.te +2 -3
 
  allow ntpd_t ntpd_log_t:dir setattr_dir_perms;
-append_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
-create_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
-setattr_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
+manage_dirs_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
+manage_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t)
  logging_log_filetrans(ntpd_t, ntpd_log_t, { file dir })
 
  manage_files_pattern(ntpd_t, ntpd_pid_t, ntpd_pid_t)

Merged.

Signature · 1 line
Chris PeBenito