Skip to contentSkip to conversation

selftests/networking: remove timestamping clean target

PATCH In review Anders Roxell 1 participant 2 messages Jan 8, 2019 – Jan 31, 2019 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/networking: remove timestamping clean target

Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced a warning:

Makefile:14: warning: overriding recipe for target 'clean' ../../lib.mk:137: warning: ignoring old recipe for target 'clean'

Theres no need for timestamping to have its own 'clean' target. The lib.mk file's 'clean' target gets included to the timestamping Makefile and that should be enough.

Fixes cda261f421ba ("selftests: add txtimestamp kselftest")
Signed-off-by Anders Roxell <anders.roxell at linaro.org>
---
 tools/testing/selftests/networking/timestamping/Makefile | 3 ---
 1 file changed, 3 deletions(-)
tools/testing/selftests/networking/timestamping/Makefile +0 -3
index 9050eeea5f5f..1de8bd8ccf5d 100644
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
 top_srcdir = ../../../../..
 KSFT_KHDR_INSTALL := 1
 include ../../lib.mk
-
-clean:
-	rm -fr $(TEST_GEN_FILES)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 29 lines · Anders Roxell

Commit cda261f421ba ("selftests: add txtimestamp kselftest") introduced a warning:

Makefile:14: warning: overriding recipe for target 'clean' ../../lib.mk:137: warning: ignoring old recipe for target 'clean'

Theres no need for timestamping to have its own 'clean' target. The lib.mk file's 'clean' target gets included to the timestamping Makefile and that should be enough.

Fixes cda261f421ba ("selftests: add txtimestamp kselftest")
Signed-off-by Anders Roxell <anders.roxell at linaro.org>
---
 tools/testing/selftests/networking/timestamping/Makefile | 3 ---
 1 file changed, 3 deletions(-)
tools/testing/selftests/networking/timestamping/Makefile +0 -4
index 9050eeea5f5f..1de8bd8ccf5d 100644
@@ -9,6 +9,3 @@ all: $(TEST_PROGS)
 top_srcdir = ../../../../..
 KSFT_KHDR_INSTALL := 1
 include ../../lib.mk
-
-clean:
-       rm -fr $(TEST_GEN_FILES)
--
Quoted 2 lines

2.20.1

Does this make sense?

Cheers,
Anders