drm/i915/gvt: give the cmd parser decode_info a const treatment
PATCH 1/2 drm/i915/gvt: give the cmd parser decode_info a const treatment
It doesn't need to be changed, make it const. The string literals should anyway be referred to as const data.
The following gets moved to rodata section:
0000000000000410 l O .rodata 0000000000000018 decode_info_mi 0000000000000390 l O .rodata 0000000000000018 decode_info_3d_media 00000000000003e0 l O .rodata 0000000000000018 decode_info_2d 0000000000000330 l O .rodata 0000000000000018 decode_info_mfx_vc 00000000000002e0 l O .rodata 0000000000000018 decode_info_vebox 0000000000000300 l O .rodata 0000000000000028 sub_op_vebox 0000000000000360 l O .rodata 0000000000000028 sub_op_mfx_vc 00000000000003c0 l O .rodata 0000000000000020 sub_op_3d_media 0000000000000400 l O .rodata 0000000000000010 sub_op_2d 0000000000000430 l O .rodata 0000000000000010 sub_op_mi
--- drivers/gpu/drm/i915/gvt/cmd_parser.c | 30 +++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/gvt/cmd_parser.c +15 -15
@@ -55,10 +55,10 @@ struct sub_op_bits {int low; };struct decode_info { -char *name; +const char *name;int op_len;int nr_sub_op; -struct sub_op_bits *sub_op; +const struct sub_op_bits *sub_op; };#define MAX_CMD_BUDGET 0x7fffffff
@@ -485,12 +485,12 @@ struct parser_exec_state {static unsigned long bypass_scan_mask =0 ;/* ring ALL, type = 0 */ -static struct sub_op_bits sub_op_mi[] = { +static const struct sub_op_bits sub_op_mi[] = { {31 ,29 }, {28 ,23 }, }; -static struct decode_info decode_info_mi = { +static const struct decode_info decode_info_mi = {"MI" ,OP_LEN_MI ,ARRAY_SIZE (sub_op_mi),
@@ -498,12 +498,12 @@ static struct decode_info decode_info_mi = { };/* ring RCS, command type 2 */ -static struct sub_op_bits sub_op_2d[] = { +static const struct sub_op_bits sub_op_2d[] = { {31 ,29 }, {28 ,22 }, }; -static struct decode_info decode_info_2d = { +static const struct decode_info decode_info_2d = {"2D" ,OP_LEN_2D ,ARRAY_SIZE (sub_op_2d),
@@ -511,14 +511,14 @@ static struct decode_info decode_info_2d = { };/* ring RCS, command type 3 */ -static struct sub_op_bits sub_op_3d_media[] = { +static const struct sub_op_bits sub_op_3d_media[] = { {31 ,29 }, {28 ,27 }, {26 ,24 }, {23 ,16 }, }; -static struct decode_info decode_info_3d_media = { +static const struct decode_info decode_info_3d_media = {"3D_Media" ,OP_LEN_3D_MEDIA ,ARRAY_SIZE (sub_op_3d_media),
@@ -526,7 +526,7 @@ static struct decode_info decode_info_3d_media = { };/* ring VCS, command type 3 */ -static struct sub_op_bits sub_op_mfx_vc[] = { +static const struct sub_op_bits sub_op_mfx_vc[] = { {31 ,29 }, {28 ,27 }, {26 ,24 },
@@ -534,7 +534,7 @@ static struct sub_op_bits sub_op_mfx_vc[] = { {20, 16}, }; -static struct decode_info decode_info_mfx_vc = { +static const struct decode_info decode_info_mfx_vc = {"MFX_VC" ,OP_LEN_MFX_VC , ARRAY_SIZE(sub_op_mfx_vc),
@@ -542,7 +542,7 @@ static struct decode_info decode_info_mfx_vc = { };/* ring VECS, command type 3 */ -static struct sub_op_bits sub_op_vebox[] = { +static const struct sub_op_bits sub_op_vebox[] = { {31 ,29 }, {28 ,27 }, {26 ,24 },
@@ -550,14 +550,14 @@ static struct sub_op_bits sub_op_vebox[] = { {20, 16}, }; -static struct decode_info decode_info_vebox = { +static const struct decode_info decode_info_vebox = { "VEBOX", OP_LEN_VEBOX, ARRAY_SIZE(sub_op_vebox), sub_op_vebox, }; -static struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] = { +static const struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] = { [RCS] = { &decode_info_mi, NULL,
@@ -616,7 +616,7 @@ static struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] = {static inline u32 get_opcode (u32 cmd,int ring_id) { -struct decode_info *d_info; +const struct decode_info *d_info; d_info = ring_decode_info[ring_id][CMD_TYPE (cmd)];if (d_info ==NULL )
@@ -657,7 +657,7 @@ static inline u32 sub_op_val(u32 cmd, u32 hi, u32 low)static inline void print_opcode (u32 cmd,int ring_id) { -struct decode_info *d_info; +const struct decode_info *d_info;int i; d_info = ring_decode_info[ring_id][CMD_TYPE (cmd)];
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915/gvt: give the cmd parser cmd_info a const treatment
It doesn't need to be changed, make it const. The string literals should anyway be referred to as const data.
The following gets moved to rodata section:
0000000000000080 l O .rodata 0000000000001c00 cmd_info
--- drivers/gpu/drm/i915/gvt/cmd_parser.c | 24 ++++++++++++------------ drivers/gpu/drm/i915/gvt/trace.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/gvt/cmd_parser.c +12 -12
@@ -375,7 +375,7 @@ typedef int (*parser_cmd_handler)(struct parser_exec_state *s);#define ADDR_FIX_5 (x1, x2, x3, x4, x5) (ADDR_FIX_1(x1) | ADDR_FIX_4(x2, x3, x4, x5))struct cmd_info { -char *name; +const char *name;u32 opcode;#define F_LEN_MASK (1U<<0)
@@ -425,7 +425,7 @@ struct cmd_info {struct cmd_entry {struct hlist_node hlist; -struct cmd_info *info; +const struct cmd_info *info; };enum {
@@ -474,7 +474,7 @@ struct parser_exec_state {int saved_buf_addr_type;bool is_ctx_wa; -struct cmd_info *info; +const struct cmd_info *info;struct intel_vgpu_workload *workload; };
@@ -625,7 +625,7 @@ static inline u32 get_opcode(u32 cmd, int ring_id)return cmd >> (32 - d_info->op_len); } -static inline struct cmd_info *find_cmd_entry (struct intel_gvt *gvt, +static inline const struct cmd_info *find_cmd_entry (struct intel_gvt *gvt,unsigned int opcode,int ring_id) {struct cmd_entry *e;
@@ -638,7 +638,7 @@ static inline struct cmd_info *find_cmd_entry(struct intel_gvt *gvt,return NULL ; } -static inline struct cmd_info *get_cmd_info (struct intel_gvt *gvt, +static inline const struct cmd_info *get_cmd_info (struct intel_gvt *gvt,u32 cmd,int ring_id) {u32 opcode;
@@ -776,7 +776,7 @@ static inline int ip_gma_advance(struct parser_exec_state *s,return 0 ; } -static inline int get_cmd_length (struct cmd_info *info,u32 cmd) +static inline int get_cmd_length (const struct cmd_info *info,u32 cmd) {if ((info->flag &F_LEN_MASK ) ==F_LEN_CONST )return info->len;
@@ -1643,7 +1643,7 @@ static int batch_buffer_needs_scan(struct parser_exec_state *s)static int find_bb_size (struct parser_exec_state *s,unsigned long *bb_size) {unsigned long gma =0 ; -struct cmd_info *info; +const struct cmd_info *info;uint32_t cmd_len =0 ;bool bb_end = false;struct intel_vgpu *vgpu = s->vgpu;
@@ -1842,7 +1842,7 @@ static int cmd_handler_mi_batch_buffer_start(struct parser_exec_state *s)static int mi_noop_index; -static struct cmd_info cmd_info[] = { +static const struct cmd_info cmd_info[] = { {"MI_NOOP" ,OP_MI_NOOP ,F_LEN_CONST ,R_ALL ,D_ALL ,0 ,1 ,NULL }, {"MI_SET_PREDICATE" ,OP_MI_SET_PREDICATE ,F_LEN_CONST ,R_ALL ,D_ALL ,
@@ -2521,7 +2521,7 @@ static void add_cmd_entry(struct intel_gvt *gvt, struct cmd_entry *e)static int cmd_parser_exec (struct parser_exec_state *s) {struct intel_vgpu *vgpu = s->vgpu; -struct cmd_info *info; +const struct cmd_info *info;u32 cmd;int ret =0 ;
@@ -2895,10 +2895,10 @@ int intel_gvt_scan_and_shadow_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)return 0 ; } -static struct cmd_info *find_cmd_entry_any_ring (struct intel_gvt *gvt, +static const struct cmd_info *find_cmd_entry_any_ring (struct intel_gvt *gvt,unsigned int opcode,unsigned long rings) { -struct cmd_info *info =NULL ; +const struct cmd_info *info =NULL ;unsigned int ring;for_each_set_bit (ring, &rings,I915_NUM_ENGINES ) {
@@ -2913,7 +2913,7 @@ static int init_cmd_table(struct intel_gvt *gvt) {int i;struct cmd_entry *e; -struct cmd_info *info; +const struct cmd_info *info;unsigned int gen_type; gen_type =intel_gvt_get_device_type (gvt);
drivers/gpu/drm/i915/gvt/trace.h +1 -1
@@ -228,7 +228,7 @@ TRACE_EVENT(oos_sync, TRACE_EVENT(gvt_command, TP_PROTO(u8 vgpu_id, u8 ring_id, u32 ip_gma, u32 *cmd_va, u32 cmd_len, u32 buf_type, u32 buf_addr_type, - void *workload, char *cmd_name), + void *workload, const char *cmd_name), TP_ARGS(vgpu_id, ring_id, ip_gma, cmd_va, cmd_len, buf_type, buf_addr_type, workload, cmd_name),
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915/gvt: give the cmd parser cmd_info a const treatment
Looks good to me.
Quoted 152 lines
-----Original Message-----
From: intel-gvt-dev [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Tuesday, January 8, 2019 10:12 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; [email protected]; Wang, Zhi A <[email protected]>; [email protected]
Subject: [PATCH 2/2] drm/i915/gvt: give the cmd parsercmd_infoa const treatmentIt doesn't need to be changed, make it const. The string literals should anyway be referred to as const data.
The following gets moved to rodata section:
0000000000000080 l O .rodata
0000000000001c00cmd_infoSigned-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/gvt/cmd_parser.c | 24 ++++++++++++------------ drivers/gpu/drm/i915/gvt/trace.h | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/gvt/cmd_parser.c +1
-1@@ -375,7 +375,7 @@ typedef int (*parser_cmd_handler)(struct parser_exec_state *s); #define ADDR_FIX_5(x1, x2, x3, x4, x5) (ADDR_FIX_1(x1) | ADDR_FIX_4(x2, x3, x4, x5))struct cmd_info { -char *name; +const char *name;u32 opcode;#define
F_LEN_MASK(1U<<0)drivers/gpu/drm/i915/gvt/cmd_parser.c +7
-5@@ -425,7 +425,7 @@ struct cmd_info {struct cmd_entry {struct hlist_node hlist; -struct cmd_info *info; +const struct cmd_info *info; };enum {@@ -474,7 +474,7 @@ struct parser_exec_state {int saved_buf_addr_type;bool is_ctx_wa; -struct cmd_info *info; +const struct cmd_info *info;struct intel_vgpu_workload *workload; };@@ -625,7 +625,7 @@ static inline u32 get_opcode(u32 cmd, int ring_id)return cmd >> (32 - d_info->op_len); } -static inline struct cmd_info *find_cmd_entry (struct intel_gvt *gvt, +static inline const struct cmd_info *find_cmd_entry (struct intel_gvt +*gvt,unsigned int opcode,int ring_id) {struct cmd_entry *e;@@ -638,7 +638,7 @@ static inline struct cmd_info *find_cmd_entry(structintel_gvt *gvt, return NULL; } -static inline struct cmd_info *get_cmd_info (struct intel_gvt *gvt, +static inline const struct cmd_info *get_cmd_info (struct intel_gvt +*gvt,u32 cmd,int ring_id) {u32 opcode;@@ -776,7 +776,7 @@ static inline int ip_gma_advance(structparser_exec_state *s, return 0; } -static inline int get_cmd_length (struct cmd_info *info,u32 cmd) +static inline int get_cmd_length (const struct cmd_info *info,u32 cmd) {if ((info->flag &F_LEN_MASK ) ==F_LEN_CONST )drivers/gpu/drm/i915/gvt/cmd_parser.c +2
-2return info->len;@@ -1643,7 +1643,7 @@ static int batch_buffer_needs_scan(struct parser_exec_state *s) static int find_bb_size(struct parser_exec_state *s,unsigned long *bb_size) {unsigned long gma =0 ; -struct cmd_info *info; +const struct cmd_info *info;uint32_t cmd_len =0 ;bool bb_end = false;struct intel_vgpu *vgpu = s->vgpu;@@ -1842,7 +1842,7 @@ static int cmd_handler_mi_batch_buffer_start(struct parser_exec_state *s)static int mi_noop_index; -static struct cmd_info cmd_info[] = { +static const struct cmd_info cmd_info[] = { {"MI_NOOP" ,OP_MI_NOOP ,F_LEN_CONST ,R_ALL ,D_ALL ,0 ,1 ,NULL },{"
MI_SET_PREDICATE",OP_MI_SET_PREDICATE,F_LEN_CONST,R_ALL,D_ALL, @@ -2521,7 +2521,7 @@ static voidadd_cmd_entry(struct intel_gvt *gvt, struct cmd_entry *e)static intcmd_parser_exec(struct parser_exec_state *s){drivers/gpu/drm/i915/gvt/cmd_parser.c +6
-4struct intel_vgpu *vgpu = s->vgpu; -struct cmd_info *info; +const struct cmd_info *info;u32 cmd;int ret =0 ;@@ -2895,10 +2895,10 @@ int intel_gvt_scan_and_shadow_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)return 0 ; } -static struct cmd_info *find_cmd_entry_any_ring (struct intel_gvt *gvt, +static const struct cmd_info *find_cmd_entry_any_ring (struct intel_gvt +*gvt,unsigned int opcode,unsigned long rings) { -struct cmd_info *info =NULL ; +const struct cmd_info *info =NULL ;unsigned int ring; for_each_set_bit(ring, &rings, I915_NUM_ENGINES) { @@ -2913,7 +2913,7 @@ static int init_cmd_table(struct intel_gvt *gvt) {int i;struct cmd_entry *e; -struct cmd_info *info; +const struct cmd_info *info;unsigned int gen_type; gen_type = intel_gvt_get_device_type(gvt); diff --git
a/drivers/gpu/drm/i915/gvt/trace.hb/drivers/gpu/drm/i915/gvt/trace.hindex1fd64202d74e..6d787750d279100644drivers/gpu/drm/i915/gvt/trace.h +1
-2@@ -228,7 +228,7 @@ TRACE_EVENT(oos_sync, TRACE_EVENT(gvt_command, TP_PROTO(u8 vgpu_id, u8 ring_id, u32 ip_gma, u32 *cmd_va, u32 cmd_len, u32 buf_type, u32 buf_addr_type, - void *workload, char *cmd_name), + void *workload, const char *cmd_name),TP_ARGS (vgpu_id, ring_id, ip_gma, cmd_va, cmd_len, buf_type, buf_addr_type, workload, cmd_name), --2.20.1
Quoted 4 lines
_______________________________________________
intel-gvt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
URL : https://patchwork.freedesktop.org/series/54884/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 52fd4ad1e302 drm/i915/gvt: give the cmd parser decode_info a const treatment d503188b9021 drm/i915/gvt: give the cmd parser cmd_info a const treatment -:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #52: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:629: +static inline const struct cmd_info *find_cmd_entry(struct intel_gvt *gvt, unsigned int opcode, int ring_id)
-:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #61: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:642:
+static inline const struct cmd_info *get_cmd_info(struct intel_gvt *gvt,
u32 cmd, int ring_id)
-:106: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #106: FILE: drivers/gpu/drm/i915/gvt/cmd_parser.c:2899:
+static const struct cmd_info *find_cmd_entry_any_ring(struct intel_gvt *gvt,
unsigned int opcode, unsigned long rings)
total: 0 errors, 0 warnings, 3 checks, 100 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
URL : https://patchwork.freedesktop.org/series/54884/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11252
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54884/revisions/1/
Known issues
------------
Here are the changes found in Patchwork_11252 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]
* igt@pm_rpm@basic-rte:
- fi-bsw-kefka: NOTRUN -> FAIL [fdo#108800]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-bsw-kefka: DMESG-WARN -> PASS
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: DMESG-FAIL [fdo#109228] -> PASS
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109228]: https://bugs.freedesktop.org/show_bug.cgi?id=109228
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
Participating hosts (48 -> 45)
------------------------------
Additional (1): fi-icl-y
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-glk-j4005
Build changes
-------------
* Linux: CI_DRM_5378 -> Patchwork_11252
CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11252: d503188b902114a32b55fe95da80799a34eed062 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d503188b9021 drm/i915/gvt: give the cmd parser cmd_info a const treatment 52fd4ad1e302 drm/i915/gvt: give the cmd parser decode_info a const treatment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11252/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/gvt: give the cmd parser decode_info a const treatment
URL : https://patchwork.freedesktop.org/series/54884/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11252_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_11252_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-skl: NOTRUN -> TIMEOUT [fdo#108039]
* igt@gem_workarounds@suspend-resume-context:
- shard-iclb: PASS -> INCOMPLETE [fdo#107713]
* igt@i915_suspend@sysfs-reader:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +3
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-skl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +4
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-untiled:
- shard-iclb: PASS -> WARN [fdo#108336] +1
* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-iclb: PASS -> FAIL [fdo#103167] +1
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-skl: NOTRUN -> FAIL [fdo#105683]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- shard-skl: PASS -> FAIL [fdo#107362]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885] +1
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +2
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: PASS -> FAIL [fdo#107815]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]
* igt@kms_setmode@basic:
- shard-kbl: NOTRUN -> FAIL [fdo#99912]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-skl: PASS -> FAIL [fdo#105010]
* igt@pm_rpm@debugfs-read:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +9
* igt@pm_rpm@fences-dpms:
- shard-skl: PASS -> INCOMPLETE [fdo#107807]
* igt@pm_rpm@legacy-planes:
- shard-iclb: PASS -> DMESG-WARN [fdo#108654]
#### Possible fixes ####
* igt@gem_userptr_blits@readonly-unsync:
- shard-skl: TIMEOUT [fdo#108887] -> PASS
* igt@i915_selftest@live_workarounds:
- shard-iclb: DMESG-FAIL [fdo#108954] -> PASS
* igt@kms_atomic_transition@plane-all-transition:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#109225] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS
* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +4
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +9
* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: WARN [fdo#108336] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: FAIL [fdo#103167] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-onoff:
- shard-iclb: FAIL [fdo#103167] -> PASS +1
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-iclb: DMESG-FAIL [fdo#103166] / [fdo#107724] -> PASS
* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +6
* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-iclb: FAIL [fdo#103166] -> PASS
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@pm_rpm@gem-execbuf:
- shard-iclb: INCOMPLETE [fdo#108840] -> PASS
* igt@pm_rpm@modeset-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS
* igt@pm_rpm@modeset-stress-extra-wait:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-snb: DMESG-WARN [fdo#109241] / [fdo#109244] -> INCOMPLETE [fdo#105411] / [fdo#106886]
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#107725]
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-iclb: FAIL [fdo#103232] -> DMESG-WARN [fdo#107724] / [fdo#108336]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: DMESG-FAIL [fdo#107724] -> FAIL [fdo#107882]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-iclb: FAIL [fdo#108948] -> DMESG-WARN [fdo#106885] / [fdo#107724] / [fdo#108336]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> DMESG-WARN [fdo#105604]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108887]: https://bugs.freedesktop.org/show_bug.cgi?id=108887
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_5378 -> Patchwork_11252
CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11252: d503188b902114a32b55fe95da80799a34eed062 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11252/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Looks good to me.
Quoted 160 lines
-----Original Message-----
From: intel-gvt-dev [mailto:[email protected]] On Behalf Of Jani Nikula
Sent: Tuesday, January 8, 2019 10:12 PM
To: [email protected]
Cc: Nikula, Jani <[email protected]>; [email protected]; Wang, Zhi A <[email protected]>; [email protected]
Subject: [PATCH 1/2] drm/i915/gvt: give the cmd parserdecode_infoa const treatmentIt doesn't need to be changed, make it const. The string literals should anyway be referred to as const data.
The following gets moved to rodata section:
0000000000000410 l O .rodata 0000000000000018
decode_info_mi
0000000000000390 l O .rodata 0000000000000018decode_info_3d_media00000000000003e0l O .rodata 0000000000000018decode_info_2d
0000000000000330 l O .rodata 0000000000000018decode_info_mfx_vc00000000000002e0l O .rodata 0000000000000018decode_info_vebox0000000000000300 l O .rodata 0000000000000028 sub_op_vebox 0000000000000360 l O .rodata 0000000000000028 sub_op_mfx_vc 00000000000003c0 l O .rodata 0000000000000020 sub_op_3d_media 0000000000000400 l O .rodata 0000000000000010 sub_op_2d 0000000000000430 l O .rodata 0000000000000010 sub_op_miSigned-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/gvt/cmd_parser.c | 30 +++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-)drivers/gpu/drm/i915/gvt/cmd_parser.c +16
-16@@ -55,10 +55,10 @@ struct sub_op_bits {int low; };struct decode_info { -char *name; +const char *name;int op_len;int nr_sub_op; -struct sub_op_bits *sub_op; +const struct sub_op_bits *sub_op; };#define MAX_CMD_BUDGET 0x7fffffff@@ -485,12 +485,12 @@ struct parser_exec_state { static unsigned long bypass_scan_mask =0 ;/* ring ALL, type = 0 */ -static struct sub_op_bits sub_op_mi[] = { +static const struct sub_op_bits sub_op_mi[] = { {31 ,29 }, {28 ,23 }, }; -static struct decode_info decode_info_mi = { +static const struct decode_info decode_info_mi = {"MI" ,OP_LEN_MI ,ARRAY_SIZE (sub_op_mi),@@ -498,12 +498,12 @@ static struct decode_info decode_info_mi = { };/* ring RCS, command type 2 */ -static struct sub_op_bits sub_op_2d[] = { +static const struct sub_op_bits sub_op_2d[] = { {31 ,29 }, {28 ,22 }, }; -static struct decode_info decode_info_2d = { +static const struct decode_info decode_info_2d = {"2D" ,OP_LEN_2D ,ARRAY_SIZE (sub_op_2d),@@ -511,14 +511,14 @@ static struct decode_info decode_info_2d = { };/* ring RCS, command type 3 */ -static struct sub_op_bits sub_op_3d_media[] = { +static const struct sub_op_bits sub_op_3d_media[] = { {31 ,29 }, {28 ,27 }, {26 ,24 }, {23 ,16 }, }; -static struct decode_info decode_info_3d_media = { +static const struct decode_info decode_info_3d_media = {"3D_Media" ,OP_LEN_3D_MEDIA ,ARRAY_SIZE (sub_op_3d_media),@@ -526,7 +526,7 @@ static struct decode_info decode_info_3d_media = { };/* ring VCS, command type 3 */ -static struct sub_op_bits sub_op_mfx_vc[] = { +static const struct sub_op_bits sub_op_mfx_vc[] = { {31 ,29 }, {28 ,27 }, {26 ,24 },@@ -534,7 +534,7 @@ static struct sub_op_bits sub_op_mfx_vc[] = { {20, 16}, }; -static struct decode_info decode_info_mfx_vc = { +static const struct decode_info decode_info_mfx_vc = {"MFX_VC" ,OP_LEN_MFX_VC , ARRAY_SIZE(sub_op_mfx_vc),@@ -542,7 +542,7 @@ static struct decode_info decode_info_mfx_vc = { };/* ring VECS, command type 3 */ -static struct sub_op_bits sub_op_vebox[] = { +static const struct sub_op_bits sub_op_vebox[] = { {31 ,29 }, {28 ,27 }, {26 ,24 },@@ -550,14 +550,14 @@ static struct sub_op_bits sub_op_vebox[] = { {20, 16}, }; -static struct decode_info decode_info_vebox = { +static const struct decode_info decode_info_vebox = { "VEBOX", OP_LEN_VEBOX, ARRAY_SIZE(sub_op_vebox), sub_op_vebox, }; -static struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] = { +static const struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] += { [RCS] = { &decode_info_mi, NULL,@@ -616,7 +616,7 @@ static struct decode_info *ring_decode_info[I915_NUM_ENGINES][8] = {static inline u32 get_opcode (u32 cmd,int ring_id) { -struct decode_info *d_info; +const struct decode_info *d_info; d_info = ring_decode_info[ring_id][CMD_TYPE (cmd)];if (d_info ==NULL )@@ -657,7 +657,7 @@ static inline u32 sub_op_val(u32 cmd, u32 hi, u32 low)static inline void print_opcode (u32 cmd,int ring_id) { -struct decode_info *d_info; +const struct decode_info *d_info;int i; d_info = ring_decode_info[ring_id][CMD_TYPE (cmd)]; --2.20.1
Quoted 4 lines
_______________________________________________
intel-gvt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx