usb: kconfig: remove dependency FSL_SOC for ehci fsl driver
Subsystems (2)
PATCH 1/3 usb: kconfig: remove dependency FSL_SOC for ehci fsl driver
From: Rajesh Bhagat <[email protected]>
CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on non-PPC platforms.
--- drivers/usb/host/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/Kconfig +2 -2
@@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX devices only. config USB_EHCI_FSL - tristate "Support for Freescale PPC on-chip EHCI USB controller" - depends on FSL_SOC + tristate "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCD select USB_EHCI_ROOT_HUB_TT ---help--- Variation of ARC USB block used in some Freescale chips.
PATCH 2/3 usb: ehci: fsl: Update register accessing for arm/arm64 platforms
arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.
--- drivers/usb/host/ehci-fsl.c | 64 ++++++++++++++++++++++++++++--------------- 1 files changed, 42 insertions(+), 22 deletions(-)
drivers/usb/host/ehci-fsl.c +42 -22
@@ -23,6 +23,7 @@#include <linux/platform_device.h> #include <linux/fsl_devices.h> #include <linux/of_platform.h> +#include <linux/io.h> #include "ehci.h" #include "ehci-fsl.h"
@@ -50,6 +51,7 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)struct resource *res;int irq;int retval; +u32 tmp;pr_debug ("initializing FSL-SOC USB Controller\n" );
@@ -114,18 +116,23 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev) }/* Enable USB controller, 83xx or 8536 */ -if (pdata->have_sysif_regs && pdata->controller_ver <FSL_USB_VER_1_6 ) -clrsetbits_be32 (hcd->regs +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,0x4 ); - +if (pdata->have_sysif_regs && pdata->controller_ver <FSL_USB_VER_1_6 ) { + tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=0x4 ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + }/* * Enable UTMI phy and program PTS field in UTMI mode before asserting * controller reset for USB Controller version 2.5 */ if (pdata->has_fsl_erratum_a007792) { -clrsetbits_be32 (hcd->regs +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,CTRL_UTMI_PHY_EN ); -writel (PORT_PTS_UTMI , hcd->regs +FSL_SOC_USB_PORTSC1 ); + tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + +iowrite32be (PORT_PTS_UTMI , hcd->regs +FSL_SOC_USB_PORTSC1 ); }/* Don't need to set host mode here. It will be done by tdi_reset() */
@@ -174,7 +181,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,enum fsl_usb2_phy_modes phy_mode, unsigned int port_offset) { - u32 portsc; + u32 portsc, tmp;struct ehci_hcd *ehci =hcd_to_ehci (hcd);void __iomem *non_ehci = hcd->regs;struct device *dev = hcd->self.controller;
@@ -192,11 +199,16 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,case FSL_USB2_PHY_ULPI :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ -clrbits32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK |UTMI_PHY_EN ); -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK , -ULPI_PHY_CLK_SEL |USB_CTRL_USB_EN ); +/* turn off UTMI PHY first */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK |UTMI_PHY_EN ); +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + +/* then turn on ULPI and enable USB controller */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK ); + tmp |=ULPI_PHY_CLK_SEL |USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); } portsc |=PORT_PTS_ULPI ;break ;
@@ -210,16 +222,21 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,case FSL_USB2_PHY_UTMI_DUAL :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,UTMI_PHY_EN ); + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK ); + tmp |=UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); +mdelay (FSL_UTMI_PHY_DLY );/* Delay for UTMI PHY CLK to become stable - 10ms*/ }/* enable UTMI PHY */ -if (pdata->have_sysif_regs) -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK , -CTRL_UTMI_PHY_EN ); +if (pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + } portsc |=PORT_PTS_UTMI ;break ;case FSL_USB2_PHY_NONE :
@@ -241,9 +258,12 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,ehci_writel (ehci, portsc, &ehci->regs->port_status[port_offset]); -if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,USB_CTRL_USB_EN ); +if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + }return 0 ; }
Greg Kroah-Hartman
maintainerRe: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Quoted 5 lines · Ran Wang
arm/arm64's
io.hdoesn't defineclrbits32()andclrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.
Shouldn't you have this patch before the Kconfig change, so that you do not break the build on ARM systems on that one and then fix it up on this one?
thanks,
greg k-h
RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Hi Greg,
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Ran Wang
arm/arm64's
io.hdoesn't defineclrbits32()andclrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.Shouldn't you have this patch before the
Kconfigchange, so that you do not break the build on ARM systems on that one and then fix it up on this one?
Yes, you are right, will adjust it in next version, thanks for pointing out.
Regards,
Ran
Alan Stern
maintainerRe: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
In reply to Ran WangQuoted 49 lines · Ran Wang
arm/arm64's
io.hdoesn't defineclrbits32()andclrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/ehci-fsl.c | 64 ++++++++++++++++++++++++++++--------------- 1 files changed, 42 insertions(+), 22 deletions(-)drivers/usb/host/ehci-fsl.c +8
-4@@ -23,6 +23,7 @@#include <linux/platform_device.h> #include <linux/fsl_devices.h> #include <linux/of_platform.h> +#include <linux/io.h> #include "ehci.h" #include "ehci-fsl.h" @@ -50,6 +51,7 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev)struct resource *res;int irq;int retval; +u32 tmp;pr_debug ("initializing FSL-SOC USB Controller\n" );@@ -114,18 +116,23 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev) }/* Enable USB controller, 83xx or 8536 */ -if (pdata->have_sysif_regs && pdata->controller_ver <FSL_USB_VER_1_6 ) -clrsetbits_be32 (hcd->regs +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,0x4 ); - +if (pdata->have_sysif_regs && pdata->controller_ver <FSL_USB_VER_1_6 ) { + tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=0x4 ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + }/* * Enable UTMI phy and program PTS field in UTMI mode before asserting * controller reset for USB Controller version 2.5 */
drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev) · line 135
Quoted 10 lines
drivers/usb/host/ehci-fsl.c +6
-3if (pdata->has_fsl_erratum_a007792) { -clrsetbits_be32 (hcd->regs +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,CTRL_UTMI_PHY_EN ); -writel (PORT_PTS_UTMI , hcd->regs +FSL_SOC_USB_PORTSC1 ); + tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + +iowrite32be (PORT_PTS_UTMI , hcd->regs +FSL_SOC_USB_PORTSC1 );
Why do you change this writel() into iowrite32be() but leave other instances of writel() unchanged? Was this a mistake?
Quoted 19 lines
drivers/usb/host/ehci-fsl.c +1
-4}/* Don't need to set host mode here. It will be done by tdi_reset() */ @@ -174,7 +181,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,enum fsl_usb2_phy_modes phy_mode, unsigned int port_offset) { - u32 portsc; + u32 portsc, tmp;struct ehci_hcd *ehci =hcd_to_ehci (hcd);void __iomem *non_ehci = hcd->regs;struct device *dev = hcd->self.controller;@@ -192,11 +199,16 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,case FSL_USB2_PHY_ULPI :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ -clrbits32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK |UTMI_PHY_EN ); - clrsetbits_be32(non_ehci + FSL_SOC_USB_CTRL,
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 209
Quoted 10 lines
drivers/usb/host/ehci-fsl.c +8
-2-CONTROL_REGISTER_W1C_MASK , - ULPI_PHY_CLK_SEL | USB_CTRL_USB_EN); +/* turn off UTMI PHY first */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK |UTMI_PHY_EN ); +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + +/* then turn on ULPI and enable USB controller */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK );
Unnecessary parens.
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 226
Quoted 13 lines
drivers/usb/host/ehci-fsl.c +4
-2+ tmp |=ULPI_PHY_CLK_SEL |USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); } portsc |=PORT_PTS_ULPI ;break ;@@ -210,16 +222,21 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,case FSL_USB2_PHY_UTMI_DUAL :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,UTMI_PHY_EN ); + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK );
Unnecessary parens.
Quoted 26 lines
drivers/usb/host/ehci-fsl.c +9
-6+ tmp |=UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); +mdelay (FSL_UTMI_PHY_DLY );/* Delay for UTMI PHY CLK to become stable - 10ms*/ }/* enable UTMI PHY */ -if (pdata->have_sysif_regs) -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK , -CTRL_UTMI_PHY_EN ); +if (pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + } portsc |=PORT_PTS_UTMI ;break ;case FSL_USB2_PHY_NONE :@@ -241,9 +258,12 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,ehci_writel (ehci, portsc, &ehci->regs->port_status[port_offset]); -if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) - clrsetbits_be32(non_ehci + FSL_SOC_USB_CTRL,
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 269
Quoted 10 lines
drivers/usb/host/ehci-fsl.c +6
-1- CONTROL_REGISTER_W1C_MASK, USB_CTRL_USB_EN); +if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + }return 0 ; }
Alan Stern
RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Hi Alan,
Quoted 79 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 00:20
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platformsQuoted 9 lines · Ran Wang
arm/arm64's
io.hdoesn't defineclrbits32()andclrsetbits_be32(), which causing compile failure on some Layerscape Platforms (such as LS1021A and LS2012A which also integrates FSL EHCI controller). So use ioread32be()/iowrite32be() instead to make it workable on both powerpc and arm.Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/ehci-fsl.c | 64 ++++++++++++++++++++++++++++---------------
drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device
Quoted 15 lines
1 files changed, 42 insertions(+), 22 deletions(-)drivers/usb/host/ehci-fsl.c +1
-0@@ -23,6 +23,7 @@#include <linux/platform_device.h> #include <linux/fsl_devices.h> #include <linux/of_platform.h> +#include <linux/io.h> #include "ehci.h" #include "ehci-fsl.h" @@ -50,6 +51,7 @@ static int fsl_ehci_drv_probe(struct platform_device*pdev)
drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct
Quoted 8 lines
drivers/usb/host/ehci-fsl.c +1
-0struct resource *res;int irq;int retval; +u32 tmp;pr_debug ("initializing FSL-SOC USB Controller\n" );@@ -114,18 +116,23 @@ static int fsl_ehci_drv_probe(struct
platform_device*pdev)drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev)
Quoted 4 lines
drivers/usb/host/ehci-fsl.c +0
-1}/* Enable USB controller, 83xx or 8536 */ - if (pdata->have_sysif_regs && pdata->controller_ver <
FSL_USB_VER_1_6)drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev)
Quoted 4 lines
drivers/usb/host/ehci-fsl.c +1
-3-clrsetbits_be32 (hcd->regs +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK ,0x4 ); - + if (pdata->have_sysif_regs && pdata->controller_ver <
FSL_USB_VER_1_6) {drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev)
Quoted 7 lines
drivers/usb/host/ehci-fsl.c +5
-0+ tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=0x4 ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + }/* * Enable UTMI phy and program PTS field in UTMI mode before asserting
drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev)
Quoted 5 lines
drivers/usb/host/ehci-fsl.c +0
-2* controller reset for USB Controller version 2.5 */ if (pdata->has_fsl_erratum_a007792) { - clrsetbits_be32(hcd->regs + FSL_SOC_USB_CTRL, - CONTROL_REGISTER_W1C_MASK,
CTRL_UTMI_PHY_EN);drivers/usb/host/ehci-fsl.c static int fsl_ehci_drv_probe(struct platform_device *pdev)
Quoted 7 lines
drivers/usb/host/ehci-fsl.c +6
-1-writel (PORT_PTS_UTMI , hcd->regs +FSL_SOC_USB_PORTSC1 ); + tmp =ioread32be (hcd->regs +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, hcd->regs +FSL_SOC_USB_CTRL ); + + iowrite32be(PORT_PTS_UTMI, hcd->regs +
FSL_SOC_USB_PORTSC1);
Quoted 2 lines
Why do you change this
writel()intoiowrite32be()but leave other instances ofwritel()unchanged? Was this a mistake?
Yes, I didn't notice there are other writel() used in this file.
However, as I know, on both powerpc and arm SoC, EHCI FSL IP's memory mapped register block is always Big-endian, so I'd like to replace all writel() with iowrite32be() in this file. Is it necessary?
Or I just replace them with ehci_writel() and select CONFIG_USB_EHCI_BIG_ENDIAN_MMIO?
Quoted 28 lines
Quoted 4 lines
drivers/usb/host/ehci-fsl.c +0
-0}/* Don't need to set host mode here. It will be done by tdi_reset() */ @@ -174,7 +181,7 @@ static int ehci_fsl_setup_phy(struct
usb_hcd*hcd,
Quoted 9 lines
drivers/usb/host/ehci-fsl.c +1
-1enum fsl_usb2_phy_modes phy_mode, unsigned int port_offset) { - u32 portsc; + u32 portsc, tmp;struct ehci_hcd *ehci =hcd_to_ehci (hcd);void __iomem *non_ehci = hcd->regs; struct device *dev = hcd->self.controller; @@ -192,11 +199,16 @@static int ehci_fsl_setup_phy(struct
usb_hcd*hcd,drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
Quoted 5 lines
drivers/usb/host/ehci-fsl.c +0
-2case FSL_USB2_PHY_ULPI :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ - clrbits32(non_ehci + FSL_SOC_USB_CTRL, - CONTROL_REGISTER_W1C_MASK |
UTMI_PHY_EN);drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
Quoted 3 lines
drivers/usb/host/ehci-fsl.c +0
-3- clrsetbits_be32(non_ehci + FSL_SOC_USB_CTRL, - CONTROL_REGISTER_W1C_MASK, - ULPI_PHY_CLK_SEL |
USB_CTRL_USB_EN);drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
Quoted 3 lines
drivers/usb/host/ehci-fsl.c +3
-0+/* turn off UTMI PHY first */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK |
UTMI_PHY_EN);
Quoted 7 lines
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 209
Quoted 5 lines
drivers/usb/host/ehci-fsl.c +5
-0+iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + +/* then turn on ULPI and enable USB controller */ + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK );Unnecessary parens.
Got it, fix it in next version.
Quoted 12 lines
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 214
Quoted 11 lines
drivers/usb/host/ehci-fsl.c +2
-2+ tmp |=ULPI_PHY_CLK_SEL |USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); } portsc |=PORT_PTS_ULPI ;break ;@@ -210,16 +222,21 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,case FSL_USB2_PHY_UTMI_DUAL :if (pdata->have_sysif_regs && pdata->controller_ver) {/* controller version 1.6 or above */ - clrsetbits_be32(non_ehci + FSL_SOC_USB_CTRL, - CONTROL_REGISTER_W1C_MASK,
UTMI_PHY_EN);
Quoted 4 lines
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd, · line 226
Quoted 2 lines
drivers/usb/host/ehci-fsl.c +2
-0+ tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~(CONTROL_REGISTER_W1C_MASK );Unnecessary parens.
Got it.
Regards,
Ran
Quoted 41 lines
drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
Quoted 4 lines
drivers/usb/host/ehci-fsl.c +3
-0+ tmp |=UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); +mdelay (FSL_UTMI_PHY_DLY );/* Delay for UTMI PHY CLK to
Quoted 17 lines
drivers/usb/host/ehci-fsl.c +6
-4become stable - 10ms*/ }/* enable UTMI PHY */ -if (pdata->have_sysif_regs) -clrsetbits_be32 (non_ehci +FSL_SOC_USB_CTRL , -CONTROL_REGISTER_W1C_MASK , -CTRL_UTMI_PHY_EN ); +if (pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=CTRL_UTMI_PHY_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + } portsc |=PORT_PTS_UTMI ;break ;case FSL_USB2_PHY_NONE :drivers/usb/host/ehci-fsl.c static int ehci_fsl_setup_phy(struct usb_hcd · line 247
Quoted 7 lines
drivers/usb/host/ehci-fsl.c +0
-3@@ -241,9 +258,12 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,ehci_writel (ehci, portsc, &ehci->regs->port_status[port_offset]); -if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) - clrsetbits_be32(non_ehci + FSL_SOC_USB_CTRL, - CONTROL_REGISTER_W1C_MASK,
USB_CTRL_USB_EN);Quoted 9 lines
drivers/usb/host/ehci-fsl.c +6
-0+if (phy_mode !=FSL_USB2_PHY_ULPI && pdata->have_sysif_regs) { + tmp =ioread32be (non_ehci +FSL_SOC_USB_CTRL ); + tmp &= ~CONTROL_REGISTER_W1C_MASK ; + tmp |=USB_CTRL_USB_EN ; +iowrite32be (tmp, non_ehci +FSL_SOC_USB_CTRL ); + }return 0 ;}
Alan Stern
Alan Stern
maintainerRE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Quoted 9 lines · Ran Wang
Quoted 2 lines
Why do you change this
writel()intoiowrite32be()but leave other instances ofwritel()unchanged? Was this a mistake?Yes, I didn't notice there are other
writel()used in this file.
However, as I know, on both powerpc and arm SoC, EHCI FSL IP's memory mapped register block is always Big-endian, so I'd like to replace allwritel()withiowrite32be()in this file. Is it necessary?Or I just replace them with
ehci_writel()and selectCONFIG_USB_EHCI_BIG_ENDIAN_MMIO?
That should work okay. ehci_fsl_setup() sets ehci->big_endian_desc and ehci->big_endian_mmio according to the platform data, so you just have to make sure the platform data is initialized correctly.
Alan Stern
RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Hi Alan,
Quoted 19 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 23:14
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]
Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platformsQuoted 8 lines · Ran Wang
Quoted 2 lines
Why do you change this
writel()intoiowrite32be()but leave other instances ofwritel()unchanged? Was this a mistake?Yes, I didn't notice there are other
writel()used in this file. However, as I know, on both powerpc and arm SoC, EHCI FSL IP's memory mapped register block is always Big-endian, so I'd like to replace allwritel()withiowrite32be()in this file. Is it necessary?
Quoted 7 lines
Quoted 1 line
Or I just replace them with
ehci_writel()and select
CONFIG_USB_EHCI_BIG_ENDIAN_MMIO?That should work okay.
ehci_fsl_setup()setsehci->big_endian_descandehci->big_endian_mmioaccording to the platform data, so you just have to make sure the platform data is initialized correctly.
OK, so I should not change writel() into iowrite32be() at that place you mentioned, and still using iowrite32be()/ioread32be() to replace clrsetbits_be32(), am I right?
Regards,
Ran
Quoted 1 line
Alan Stern
Alan Stern
maintainerRE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Quoted 24 lines · Ran Wang
Hi Alan,
Quoted 22 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 23:14
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]
Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platformsQuoted 9 lines · Ran Wang
Quoted 2 lines
Why do you change this
writel()intoiowrite32be()but leave other instances ofwritel()unchanged? Was this a mistake?Yes, I didn't notice there are other
writel()used in this file. However, as I know, on both powerpc and arm SoC, EHCI FSL IP's memory mapped register block is always Big-endian, so I'd like to replace allwritel()withiowrite32be()in this file. Is it necessary?Or I just replace them with
ehci_writel()and select
CONFIG_USB_EHCI_BIG_ENDIAN_MMIO?
Quoted 7 lines
Quoted 4 lines
That should work okay.
ehci_fsl_setup()setsehci->big_endian_descandehci->big_endian_mmioaccording to the platform data, so you just have to make sure the platform data is initialized correctly.OK, so I should not change
writel()intoiowrite32be()at that place you mentioned, and still using iowrite32be()/ioread32be() to replaceclrsetbits_be32(), am I right?
Actually, I think it would be good to use ehci_writel() and ehci_readl() everywhere except in fsl_ehci_drv_probe().
But if you prefer to use iowrite32be() and ioread32be() instead, that's probably okay. (However, it won't work if anyone ever produces a little-endian version of the IP.)
Alan Stern
RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for arm/arm64 platforms
Hi Alan,
Quoted 39 lines · Alan
Quoted 32 lines · Ran Wang
Hi Alan,
Quoted 21 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 23:14
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]
Subject: RE: [PATCH 2/3] usb: ehci: fsl: Update register accessing for
arm/arm64 platformsQuoted 9 lines · Ran Wang
Quoted 2 lines
Why do you change this
writel()intoiowrite32be()but leave other instances ofwritel()unchanged? Was this a mistake?Yes, I didn't notice there are other
writel()used in this file. However, as I know, on both powerpc and arm SoC, EHCI FSL IP's memory mapped register block is always Big-endian, so I'd like to replace allwritel()withiowrite32be()in this file. Is it necessary?Quoted 9 lines
Quoted 1 line
Or I just replace them with
ehci_writel()and select
CONFIG_USB_EHCI_BIG_ENDIAN_MMIO?That should work okay.
ehci_fsl_setup()setsehci->big_endian_descandehci->big_endian_mmioaccording to the platform data, so you justehci->have
to make sure the platform data is initialized correctly.Quoted 3 lines
OK, so I should not change
writel()intoiowrite32be()at that place you mentioned, and still using iowrite32be()/ioread32be() to replaceclrsetbits_be32(), am I right?
Quoted 6 lines
Actually, I think it would be good to use
ehci_writel()andehci_readl()everywhere except infsl_ehci_drv_probe().But if you prefer to use
iowrite32be()andioread32be()instead, that's probably okay. (However, it won't work if anyone ever produces a little- endian version of the IP.)
Got it, I'll verify with ehci_readl() then work out the v2 patch if pass. Thanks for advice.
Regards,
Ran
PATCH 3/3 drivers: usb :fsl: Remove USB Errata checking code
In reply to Ran WangFrom: yinbo.zhu <[email protected]>
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup.
--- drivers/usb/host/ehci-fsl.c | 7 +------ drivers/usb/host/fsl-mph-dr-of.c | 6 ++++++ include/linux/fsl_devices.h | 7 ++++--- 3 files changed, 11 insertions(+), 9 deletions(-)
drivers/usb/host/ehci-fsl.c +1 -6
@@ -304,14 +304,9 @@ static int ehci_fsl_usb_setup(struct ehci_hcd *ehci)return -EINVAL ;if (pdata->operating_mode ==FSL_USB2_MPH_HOST ) { -unsigned int chip, rev, svr; - - svr =mfspr (SPRN_SVR ); - chip = svr >>16 ; - rev = (svr >>4 ) &0xf ;/* Deal with USB Erratum #14 on MPC834x Rev 1.0 & 1.1 chips */ -if ((rev ==1 ) && (chip >=0x8050 ) && (chip <=0x8055 )) +if (pdata->has_fsl_erratum_14 ==1 ) ehci->has_fsl_port_bug =1 ;if (pdata->port_enables &FSL_USB2_PORT0_ENABLED )
drivers/usb/host/fsl-mph-dr-of.c +6 -0
@@ -225,6 +225,12 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev) pdata->has_fsl_erratum_a005697 =of_property_read_bool (np,"fsl,usb_erratum-a005697" ); +if (of_get_property (np,"fsl,usb_erratum_14" ,NULL )) + pdata->has_fsl_erratum_14 =1 ; +else + pdata->has_fsl_erratum_14 =0 ; + +/* * Determine whether phy_clk_valid needs to be checked * by reading property in device tree
include/linux/fsl_devices.h +4 -3
@@ -98,10 +98,11 @@ struct fsl_usb2_platform_data { unsigned suspended:1; unsigned already_suspended:1; - unsigned has_fsl_erratum_a007792:1; - unsigned has_fsl_erratum_a005275:1; + unsigned has_fsl_erratum_a007792:1; + unsigned has_fsl_erratum_14:1; + unsigned has_fsl_erratum_a005275:1; unsigned has_fsl_erratum_a005697:1; - unsigned check_phy_clk_valid:1; + unsigned check_phy_clk_valid:1;/* register save area for suspend/resume */ u32 pm_command;
Greg Kroah-Hartman
maintainerRe: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
Quoted 1 line · Ran Wang
From: yinbo.zhu <[email protected]>
I doubt Yinbo's name has a "." in it :)
Can you please fix this up to have the correct name here?
Quoted 7 lines
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup.
Signed-off-by Ramneek Mehresh <[email protected]>Signed-off-by Nikhil Badola <[email protected]>Signed-off-by yinbo.zhu <[email protected]>
And here.
thanks,
greg k-h
RE: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
Hi Greg,
Quoted 19 lines
-----Original Message-----
From: Greg Kroah-Hartman <[email protected]>
Sent: Tuesday, January 08, 2019 23:45
To: Ran Wang <[email protected]>
Cc: Alan Stern <[email protected]>; [email protected]; [email protected]; Yinbo Zhu <[email protected]>
Subject: Re: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking codeQuoted 1 line · Ran Wang
From: yinbo.zhu <[email protected]>
I doubt Yinbo's name has a "." in it :)
Can you please fix this up to have the correct name here?
Quoted 4 lines
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Ramneek Mehresh <[email protected]>Signed-off-by Nikhil Badola <[email protected]>Signed-off-by yinbo.zhu <[email protected]>And here.
Yes, this is a mistake (should be 'Yinbo Zhu'), I'll fix them in next version, thanks.
Regards,
Ran
Alan Stern
maintainerRe: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
In reply to Ran WangQuoted 59 lines · Ran Wang
From: yinbo.zhu <[email protected]>
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup.
Signed-off-by Ramneek Mehresh <[email protected]>Signed-off-by Nikhil Badola <[email protected]>Signed-off-by yinbo.zhu <[email protected]>Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/ehci-fsl.c | 7 +------ drivers/usb/host/fsl-mph-dr-of.c | 6 ++++++ include/linux/fsl_devices.h | 7 ++++--- 3 files changed, 11 insertions(+), 9 deletions(-)drivers/usb/host/ehci-fsl.c +1
-6@@ -304,14 +304,9 @@ static int ehci_fsl_usb_setup(struct ehci_hcd *ehci)return -EINVAL ;if (pdata->operating_mode ==FSL_USB2_MPH_HOST ) { -unsigned int chip, rev, svr; - - svr =mfspr (SPRN_SVR ); - chip = svr >>16 ; - rev = (svr >>4 ) &0xf ;/* Deal with USB Erratum #14 on MPC834x Rev 1.0 & 1.1 chips */ -if ((rev ==1 ) && (chip >=0x8050 ) && (chip <=0x8055 )) +if (pdata->has_fsl_erratum_14 ==1 ) ehci->has_fsl_port_bug =1 ;if (pdata->port_enables &FSL_USB2_PORT0_ENABLED )drivers/usb/host/fsl-mph-dr-of.c +6
-0@@ -225,6 +225,12 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev) pdata->has_fsl_erratum_a005697 =of_property_read_bool (np,"fsl,usb_erratum-a005697" ); +if (of_get_property (np,"fsl,usb_erratum_14" ,NULL )) + pdata->has_fsl_erratum_14 =1 ; +else + pdata->has_fsl_erratum_14 =0 ; + +/* * Determine whether phy_clk_valid needs to be checked * by reading property in device tree include/linux/fsl_devices.h +0
-0@@ -98,10 +98,11 @@ struct fsl_usb2_platform_data {
include/linux/fsl_devices.h struct fsl_usb2_platform_data { · line 105
Quoted 10 lines
include/linux/fsl_devices.h +4
-3unsigned suspended:1; unsigned already_suspended:1; - unsigned has_fsl_erratum_a007792:1; - unsigned has_fsl_erratum_a005275:1; + unsigned has_fsl_erratum_a007792:1; + unsigned has_fsl_erratum_14:1; + unsigned has_fsl_erratum_a005275:1; unsigned has_fsl_erratum_a005697:1; - unsigned check_phy_clk_valid:1; + unsigned check_phy_clk_valid:1;
You are using spaces here instead of tabs, which alters the alignment. Don't do that.
Alan Stern
Quoted 3 lines
include/linux/fsl_devices.h +0
-0/* register save area for suspend/resume */ u32 pm_command;
RE: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
Hi Alan,
Quoted 73 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 00:22
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]; Yinbo Zhu <[email protected]>
Subject: Re: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking codeQuoted 21 lines · Ran Wang
From: yinbo.zhu <[email protected]>
Remove USB errata checking code from driver. Applicability of erratum is retrieved by reading corresponding property in device tree. This property is written during device tree fixup.
Signed-off-by Ramneek Mehresh <[email protected]>Signed-off-by Nikhil Badola <[email protected]>Signed-off-by yinbo.zhu <[email protected]>Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/ehci-fsl.c | 7 +------ drivers/usb/host/fsl-mph-dr-of.c | 6 ++++++ include/linux/fsl_devices.h | 7 ++++--- 3 files changed, 11 insertions(+), 9 deletions(-)drivers/usb/host/ehci-fsl.c +0
-0drivers/usb/host/ehci-fsl.c static int ehci_fsl_usb_setup(struct ehci_hcd *ehci) · line 308
Quoted 10 lines
drivers/usb/host/ehci-fsl.c +0
-5@@ -304,14 +304,9 @@ static int ehci_fsl_usb_setup(struct ehci_hcd *ehci)return -EINVAL ;if (pdata->operating_mode ==FSL_USB2_MPH_HOST ) { -unsigned int chip, rev, svr; - - svr =mfspr (SPRN_SVR ); - chip = svr >>16 ; - rev = (svr >>4 ) &0xf ;/* Deal with USB Erratum #14 on MPC834x Rev 1.0 & 1.1 chips */
drivers/usb/host/ehci-fsl.c static int ehci_fsl_usb_setup(struct ehci_hcd *ehci)
Quoted 5 lines
drivers/usb/host/ehci-fsl.c +1
-1-if ((rev ==1 ) && (chip >=0x8050 ) && (chip <=0x8055 )) +if (pdata->has_fsl_erratum_14 ==1 ) ehci->has_fsl_port_bug =1 ;if (pdata->port_enables &FSL_USB2_PORT0_ENABLED ) diff --git
drivers/usb/host/fsl-mph-dr-of.c static int fsl_usb2_mph_dr_of_probe(struct
Quoted 5 lines
a/drivers/usb/host/fsl-mph-dr-of.cb/drivers/usb/host/fsl-mph-dr-of.cindex 677f9d5..4f8b8a0 100644drivers/usb/host/fsl-mph-dr-of.c +0
-0@@ -225,6 +225,12 @@ static int fsl_usb2_mph_dr_of_probe(struct
platform_device*ofdev)Quoted 18 lines
drivers/usb/host/fsl-mph-dr-of.c +6
-0pdata->has_fsl_erratum_a005697 =of_property_read_bool (np,"fsl,usb_erratum-a005697" ); +if (of_get_property (np,"fsl,usb_erratum_14" ,NULL )) + pdata->has_fsl_erratum_14 =1 ; +else + pdata->has_fsl_erratum_14 =0 ; + +/* * Determine whether phy_clk_valid needs to be checked * by reading property in device tree diff --git
a/include/linux/fsl_devices.hb/include/linux/fsl_devices.hindex 60cef82..7aa51bc 100644include/linux/fsl_devices.h +0
-0@@ -98,10 +98,11 @@ struct fsl_usb2_platform_data {
Quoted 13 lines
include/linux/fsl_devices.h struct fsl_usb2_platform_data { · line 105
Quoted 10 lines
include/linux/fsl_devices.h +4
-3unsigned suspended:1; unsigned already_suspended:1; - unsigned has_fsl_erratum_a007792:1; - unsigned has_fsl_erratum_a005275:1; + unsigned has_fsl_erratum_a007792:1; + unsigned has_fsl_erratum_14:1; + unsigned has_fsl_erratum_a005275:1; unsigned has_fsl_erratum_a005697:1; - unsigned check_phy_clk_valid:1; + unsigned check_phy_clk_valid:1;You are using spaces here instead of tabs, which alters the alignment. Don't do that.
Yes, will fix it in next version.
Regards,
Ran
Quoted 5 lines
Alan Stern
Quoted 3 lines
include/linux/fsl_devices.h +0
-0/* register save area for suspend/resume */ u32 pm_command;
kbuild test robot
build botRe: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
In reply to Ran WangThank you for the patch! Yet something to improve:
Hi yinbo.zhu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v5.0-rc1 next-20190108]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ran-Wang/usb-kconfig-remove-dependency-FSL_SOC-for-ehci-fsl-driver/20190108-143252 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_ioctl':
>> phy-fsl-usb.c:(.text+0x444): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_srp': phy-fsl-usb.c:(.text+0x4c0): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_host': phy-fsl-usb.c:(.text+0x5c0): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_hnp': phy-fsl-usb.c:(.text+0x650): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `show_fsl_usb2_otg_state': >> phy-fsl-usb.c:(.text+0x754): undefined reference to `usb_otg_state_string' drivers/usb/phy/phy-fsl-usb.o: In function `a_wait_enum': phy-fsl-usb.c:(.text+0x1064): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': >> phy-fsl-usb.c:(.text+0x1648): undefined reference to `usb_gadget_vbus_disconnect'
phy-fsl-usb.c:(.text+0x1658): undefined reference to `otg_statemachine'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Alan Stern
maintainerQuoted 16 lines · Ran Wang
From: Rajesh Bhagat <[email protected]>
CONFIG_USB_EHCI_FSLis not dependent onFSL_SOC, it can be built on non-PPC platforms.Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/host/Kconfig +0
-0
drivers/usb/host/Kconfig config XPS_USB_HCD_XILINX · line 183
Quoted 7 lines
drivers/usb/host/Kconfig +2
-2@@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX devices only. config USB_EHCI_FSL - tristate "Support for Freescale PPC on-chip EHCI USB controller" - depends on FSL_SOC + tristate "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCD
This line is not needed. The entire entry lies within an "if USB_EHCI_HCD" block.
Alan Stern
Quoted 4 lines
drivers/usb/host/Kconfig +0
-0select USB_EHCI_ROOT_HUB_TT ---help--- Variation of ARC USB block used in some Freescale chips.
Hi Alan,
Quoted 30 lines
-----Original Message-----
From: Alan Stern <[email protected]>
Sent: Wednesday, January 09, 2019 00:12
To: Ran Wang <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>; linux- [email protected]; [email protected]; Rajesh Bhagat <[email protected]>
Subject: Re: [PATCH 1/3] usb: kconfig: remove dependencyFSL_SOCfor ehci fsl driverQuoted 18 lines · Ran Wang
From: Rajesh Bhagat <[email protected]>
CONFIG_USB_EHCI_FSLis not dependent onFSL_SOC, it can be built on non-PPC platforms.Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Ran Wang <[email protected]>--- drivers/usb/host/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/host/Kconfig index renamed from drivers/usb/host/Kconfig +0
-016758b1..53cbc0c 100644
drivers/usb/host/Kconfig +0
-0@@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX devices only.
Quoted 8 lines
drivers/usb/host/Kconfig config XPS_USB_HCD_XILINX · line 183
Quoted 5 lines
drivers/usb/host/Kconfig +2
-2config USB_EHCI_FSL - tristate "Support for Freescale PPC on-chip EHCI USB controller" - depends on FSL_SOC + tristate "Support for Freescale on-chip EHCI USB controller" + depends on USB_EHCI_HCDThis line is not needed. The entire entry lies within an "if
USB_EHCI_HCD" block.
Got it, will remove it in next version, thanks.
Regards,
Ran
Quoted 6 lines
Alan Stern
Quoted 4 lines
drivers/usb/host/Kconfig +0
-0select USB_EHCI_ROOT_HUB_TT ---help--- Variation of ARC USB block used in some Freescale chips.