Btrfs: remove redundant check for swapfiles when reflinking
PATCH 1/1 Btrfs: remove redundant check for swapfiles when reflinking
From: Filipe Manana <[email protected]>
Checking if either of the inodes corresponds to a swapfile is already performed by generic_remap_file_range_prep(), so we do not need to do it in the btrfs clone and deduplication functions.
Signed-off-by Filipe Manana <[email protected]>
--- fs/btrfs/ioctl.c | 6 ------ 1 file changed, 6 deletions(-)
fs/btrfs/ioctl.c +0 -6
@@ -3286,9 +3286,6 @@ static int btrfs_extent_same(struct inode *src, u64 loff, u64 olen, (BTRFS_I(dst)->flags & BTRFS_INODE_NODATASUM))return -EINVAL ; -if (IS_SWAPFILE (src) ||IS_SWAPFILE (dst)) -return -ETXTBSY ; - tail_len = olen %BTRFS_MAX_DEDUPE_LEN ; chunk_count =div_u64 (olen,BTRFS_MAX_DEDUPE_LEN );if (chunk_count ==0 )
@@ -3913,9 +3910,6 @@ static noinline int btrfs_clone_files(struct file *file, struct file *file_src, (BTRFS_I(inode)->flags & BTRFS_INODE_NODATASUM))return -EINVAL ; -if (IS_SWAPFILE (src) ||IS_SWAPFILE (inode)) -return -ETXTBSY ; -/* * VFS's generic_remap_file_range_prep() protects us from cloning the * eof block into the middle of a file, which would result in corruption
Signature · 1 line
2.11.0
Quoted 7 lines · On Tue, Jan 08, 2019 at 11:43:18AM +0000, [email protected] wrote:
From: Filipe Manana <[email protected]>
Checking if either of the inodes corresponds to a swapfile is already performed by
generic_remap_file_range_prep(), so we do not need to do it in the btrfs clone and deduplication functions.Signed-off-by Filipe Manana <[email protected]>
Reviewed-by David Sterba <[email protected]>