Skip to contentSkip to conversation

drm/i915/backlight: Restore backlight on resume, v3.

PATCH In review Maarten Lankhorst 4 participants 20 messages Jan 8, 2019 – Jan 22, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 drm/i915/backlight: Restore backlight on resume, v3.

Restore our saved values for backlight. This way even with fastset on S4 resume we will correctly restore the backlight to the active values.

Changes since v1:
- Call enable_backlight() when backlight.level is set. On suspend backlight.enabled is always cleared, this makes it not a good indicator. Also check for crtc->state->active.
Changes since v2:
- Use the new update_pipe() callback to run this on resume as well.

---
 drivers/gpu/drm/i915/icl_dsi.c     |  1 +
 drivers/gpu/drm/i915/intel_ddi.c   |  2 ++
 drivers/gpu/drm/i915/intel_dp.c    |  1 +
 drivers/gpu/drm/i915/intel_drv.h   |  3 ++
 drivers/gpu/drm/i915/intel_lvds.c  |  1 +
 drivers/gpu/drm/i915/intel_panel.c | 49 +++++++++++++++++++++++-------
 drivers/gpu/drm/i915/vlv_dsi.c     |  1 +
 7 files changed, 47 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/icl_dsi.c +1 -0
index 4dd793b78996..3f92881600c5 100644
@@ -1378,6 +1378,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
 	encoder->disable = gen11_dsi_disable;
 	encoder->port = port;
 	encoder->get_config = gen11_dsi_get_config;
+	encoder->update_pipe = intel_panel_update_backlight;
 	encoder->compute_config = gen11_dsi_compute_config;
 	encoder->get_hw_state = gen11_dsi_get_hw_state;
 	encoder->type = INTEL_OUTPUT_DSI;
drivers/gpu/drm/i915/intel_ddi.c +2 -0
index 2d6ed990a232..d32865dc44e8 100644
@@ -3548,6 +3548,8 @@ static void intel_ddi_update_pipe_dp(struct intel_encoder *encoder,
 
 	intel_psr_enable(intel_dp, crtc_state);
 	intel_edp_drrs_enable(intel_dp, crtc_state);
+
+	intel_panel_update_backlight(encoder, crtc_state, conn_state);
 }
 
 static void intel_ddi_update_pipe(struct intel_encoder *encoder,
drivers/gpu/drm/i915/intel_dp.c +1 -0
index 62fd11540942..0cbacdc70b07 100644
@@ -6981,6 +6981,7 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
 	intel_encoder->compute_config = intel_dp_compute_config;
 	intel_encoder->get_hw_state = intel_dp_get_hw_state;
 	intel_encoder->get_config = intel_dp_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 	intel_encoder->suspend = intel_dp_encoder_suspend;
 	if (IS_CHERRYVIEW(dev_priv)) {
 		intel_encoder->pre_pll_enable = chv_dp_pre_pll_enable;
drivers/gpu/drm/i915/intel_drv.h +3 -0
index 1a11c2beb7f3..0a6fb42e2086 100644
@@ -2023,6 +2023,9 @@ int intel_panel_setup_backlight(struct drm_connector *connector,
 				enum pipe pipe);
 void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
 				  const struct drm_connector_state *conn_state);
+void intel_panel_update_backlight(struct intel_encoder *encoder,
+				  const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state);
 void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
 extern struct drm_display_mode *intel_find_panel_downclock(
 				struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/intel_lvds.c +1 -0
index b85e195f7c8a..189693b4c5e8 100644
@@ -909,6 +909,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
 	}
 	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
 	intel_encoder->get_config = intel_lvds_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 	intel_connector->get_hw_state = intel_connector_get_hw_state;
 
 	intel_connector_attach_encoder(intel_connector, intel_encoder);
drivers/gpu/drm/i915/intel_panel.c +38 -11

70 lines not on this page · raw message

drivers/gpu/drm/i915/vlv_dsi.c +1 -0
index 361e962a7969..3dcf7ddca032 100644
@@ -1689,6 +1689,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
 	intel_encoder->post_disable = intel_dsi_post_disable;
 	intel_encoder->get_hw_state = intel_dsi_get_hw_state;
 	intel_encoder->get_config = intel_dsi_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 
 	intel_connector->get_hw_state = intel_connector_get_hw_state;
 
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/5 drm/i915/backlight: Fix backlight takeover on LPT, v3.

On lynxpoint the bios sometimes sets up the backlight using the CPU display, but the driver expects using the PWM PCH override register.

Read the value from the CPU register, then convert it to the other units by converting from the old duty cycle, to freq, to the new units.

This value is then programmed in the override register, after which we set the override and disable the CPU display control. This allows us to switch the source without flickering, and make the backlight controls work in the driver.

Changes since v1:
- Read BLC_PWM_CPU_CTL2 to cpu_ctl2.
- Clean up cpu_mode if slightly.
- Always disable BLM_PWM_ENABLE in cpu_ctl2.
Changes since v2:
- Simplify cpu_mode handling (Jani)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108225

Cc Basil Eric Rabi <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Tolga Cakir <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_panel.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_panel.c +22 -4
index f71b33cf1c97..1c9ef54d58fe 100644
@@ -1493,8 +1493,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct intel_panel *panel = &connector->panel;
-	u32 pch_ctl1, pch_ctl2, val;
-	bool alt;
+	u32 cpu_ctl2, pch_ctl1, pch_ctl2, val;
+	bool alt, cpu_mode;
 
 	if (HAS_PCH_LPT(dev_priv))
 		alt = I915_READ(SOUTH_CHICKEN2) & LPT_PWM_GRANULARITY;
@@ -1508,6 +1508,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 	pch_ctl2 = I915_READ(BLC_PWM_PCH_CTL2);
 	panel->backlight.max = pch_ctl2 >> 16;
 
+	cpu_ctl2 = I915_READ(BLC_PWM_CPU_CTL2);
+
 	if (!panel->backlight.max)
 		panel->backlight.max = get_backlight_max_vbt(connector);
 
@@ -1516,12 +1518,28 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 
 	panel->backlight.min = get_backlight_min_vbt(connector);
 
-	val = lpt_get_backlight(connector);
+	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+
+	cpu_mode = panel->backlight.enabled && HAS_PCH_LPT(dev_priv) &&
+		   !(pch_ctl1 & BLM_PCH_OVERRIDE_ENABLE) &&
+		   (cpu_ctl2 & BLM_PWM_ENABLE);
+	if (cpu_mode)
+		val = pch_get_backlight(connector);
+	else
+		val = lpt_get_backlight(connector);
 	val = intel_panel_compute_brightness(connector, val);
 	panel->backlight.level = clamp(val, panel->backlight.min,
 				       panel->backlight.max);
 
-	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+	if (cpu_mode) {
+		DRM_DEBUG_KMS("CPU backlight register was enabled, switching to PCH override\n");
+
+		/* Write converted CPU PWM value to PCH override register */
+		lpt_set_backlight(connector->base.state, panel->backlight.level);
+		I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
+
+		I915_WRITE(BLC_PWM_CPU_CTL2, cpu_ctl2 & ~BLM_PWM_ENABLE);
+	}
 
 	return 0;
 }
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/5
#2 lore raw

Re: [PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v3.

Quoted 18 lines · Maarten Lankhorst

On lynxpoint the bios sometimes sets up the backlight using the CPU display, but the driver expects using the PWM PCH override register.

Read the value from the CPU register, then convert it to the other units by converting from the old duty cycle, to freq, to the new units.

This value is then programmed in the override register, after which we set the override and disable the CPU display control. This allows us to switch the source without flickering, and make the backlight controls work in the driver.

Changes since v1:
- Read BLC_PWM_CPU_CTL2 to cpu_ctl2.
- Clean up cpu_mode if slightly.
- Always disable BLM_PWM_ENABLE in cpu_ctl2.
Changes since v2:
- Simplify cpu_mode handling (Jani)

Quoted 8 lines

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108225

Cc Basil Eric Rabi <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Tolga Cakir <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Jani Nikula <[email protected]>
Quoted 50 lines
---
  drivers/gpu/drm/i915/intel_panel.c | 26 ++++++++++++++++++++++----
  1 file changed, 22 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_panel.c +15 -4
index f71b33cf1c97..1c9ef54d58fe 100644
@@ -1493,8 +1493,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
  {
  	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
  	struct intel_panel *panel = &connector->panel;
-	u32 pch_ctl1, pch_ctl2, val;
-	bool alt;
+	u32 cpu_ctl2, pch_ctl1, pch_ctl2, val;
+	bool alt, cpu_mode;
 
  	if (HAS_PCH_LPT(dev_priv))
  		alt = I915_READ(SOUTH_CHICKEN2) & LPT_PWM_GRANULARITY;
@@ -1508,6 +1508,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
  	pch_ctl2 = I915_READ(BLC_PWM_PCH_CTL2);
  	panel->backlight.max = pch_ctl2 >> 16;
 
+	cpu_ctl2 = I915_READ(BLC_PWM_CPU_CTL2);
+
  	if (!panel->backlight.max)
  		panel->backlight.max = get_backlight_max_vbt(connector);
 
@@ -1516,12 +1518,28 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 
  	panel->backlight.min = get_backlight_min_vbt(connector);
 
-	val = lpt_get_backlight(connector);
+	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+
+	cpu_mode = panel->backlight.enabled && HAS_PCH_LPT(dev_priv) &&
+		   !(pch_ctl1 & BLM_PCH_OVERRIDE_ENABLE) &&
+		   (cpu_ctl2 & BLM_PWM_ENABLE);
+	if (cpu_mode)
+		val = pch_get_backlight(connector);
+	else
+		val = lpt_get_backlight(connector);
  	val = intel_panel_compute_brightness(connector, val);
  	panel->backlight.level = clamp(val, panel->backlight.min,
  				       panel->backlight.max);
 
-	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+	if (cpu_mode) {
+		DRM_DEBUG_KMS("CPU backlight register was enabled, switching to PCH override\n");

drivers/gpu/drm/i915/intel_panel.c static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus · line 1545

Quoted 10 lines
drivers/gpu/drm/i915/intel_panel.c +7 -0
+
+		/* Write converted CPU PWM value to PCH override register */
+		lpt_set_backlight(connector->base.state, panel->backlight.level);
+		I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
+
+		I915_WRITE(BLC_PWM_CPU_CTL2, cpu_ctl2 & ~BLM_PWM_ENABLE);
+	}
 
  	return 0;
  }

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 2/5
#3 lore raw

Re: [PATCH 2/5] drm/i915/backlight: Fix backlight takeover on LPT, v3.

In reply to Maarten Lankhorst
Quoted 18 lines · Maarten Lankhorst

On lynxpoint the bios sometimes sets up the backlight using the CPU display, but the driver expects using the PWM PCH override register.

Read the value from the CPU register, then convert it to the other units by converting from the old duty cycle, to freq, to the new units.

This value is then programmed in the override register, after which we set the override and disable the CPU display control. This allows us to switch the source without flickering, and make the backlight controls work in the driver.

Changes since v1:
- Read BLC_PWM_CPU_CTL2 to cpu_ctl2.
- Clean up cpu_mode if slightly.
- Always disable BLM_PWM_ENABLE in cpu_ctl2.
Changes since v2:
- Simplify cpu_mode handling (Jani)

Quoted 8 lines

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108225

Cc Basil Eric Rabi <[email protected]>
Cc Hans de Goede <[email protected]>
Cc Tolga Cakir <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Jani Nikula <[email protected]>
Quoted 59 lines
---
 drivers/gpu/drm/i915/intel_panel.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_panel.c +22 -4
index f71b33cf1c97..1c9ef54d58fe 100644
@@ -1493,8 +1493,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct intel_panel *panel = &connector->panel;
-	u32 pch_ctl1, pch_ctl2, val;
-	bool alt;
+	u32 cpu_ctl2, pch_ctl1, pch_ctl2, val;
+	bool alt, cpu_mode;
 
 	if (HAS_PCH_LPT(dev_priv))
 		alt = I915_READ(SOUTH_CHICKEN2) & LPT_PWM_GRANULARITY;
@@ -1508,6 +1508,8 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 	pch_ctl2 = I915_READ(BLC_PWM_PCH_CTL2);
 	panel->backlight.max = pch_ctl2 >> 16;
 
+	cpu_ctl2 = I915_READ(BLC_PWM_CPU_CTL2);
+
 	if (!panel->backlight.max)
 		panel->backlight.max = get_backlight_max_vbt(connector);
 
@@ -1516,12 +1518,28 @@ static int lpt_setup_backlight(struct intel_connector *connector, enum pipe unus
 
 	panel->backlight.min = get_backlight_min_vbt(connector);
 
-	val = lpt_get_backlight(connector);
+	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+
+	cpu_mode = panel->backlight.enabled && HAS_PCH_LPT(dev_priv) &&
+		   !(pch_ctl1 & BLM_PCH_OVERRIDE_ENABLE) &&
+		   (cpu_ctl2 & BLM_PWM_ENABLE);
+	if (cpu_mode)
+		val = pch_get_backlight(connector);
+	else
+		val = lpt_get_backlight(connector);
 	val = intel_panel_compute_brightness(connector, val);
 	panel->backlight.level = clamp(val, panel->backlight.min,
 				       panel->backlight.max);
 
-	panel->backlight.enabled = pch_ctl1 & BLM_PCH_PWM_ENABLE;
+	if (cpu_mode) {
+		DRM_DEBUG_KMS("CPU backlight register was enabled, switching to PCH override\n");
+
+		/* Write converted CPU PWM value to PCH override register */
+		lpt_set_backlight(connector->base.state, panel->backlight.level);
+		I915_WRITE(BLC_PWM_PCH_CTL1, pch_ctl1 | BLM_PCH_OVERRIDE_ENABLE);
+
+		I915_WRITE(BLC_PWM_CPU_CTL2, cpu_ctl2 & ~BLM_PWM_ENABLE);
+	}
 
 	return 0;
 }
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

PATCH 3/5 drm/i915: Enable fastset for non-boot modesets.

In reply to Maarten Lankhorst

Now that our state comparison functions are pretty complete, we should enable fastset by default when a modeset can be avoided. Even if we're not completely certain about the inherited state, we can be certain after the first modeset that our sw state matches the hw state.

There is one testcase explicitly testing fastset, kms_panel_fitting.atomic-fastset but other testcases do so indirectly because most tests don't clean up the display during exit, or otherwise indirectly preserve mode by doing igt_display_reset or inheriting during init.

---
 drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +6 -2
index 696e6f5680df..f8cbdd50fa38 100644
@@ -11671,6 +11671,11 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
 		(current_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
 		!(pipe_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
 
+	if (fixup_inherited && !i915_modparams.fastboot) {
+		drm_dbg(DRM_UT_KMS, "initial modeset and fastboot not set\n");
+		ret = false;
+	}
+
 #define PIPE_CONF_CHECK_X(name) do { \
 	if (current_config->name != pipe_config->name) { \
 		pipe_config_err(adjust, __stringify(name), \
@@ -12694,8 +12699,7 @@ static int intel_atomic_check(struct drm_device *dev,
 			return ret;
 		}
 
-		if (i915_modparams.fastboot &&
-		    intel_pipe_config_compare(dev_priv,
+		if (intel_pipe_config_compare(dev_priv,
 					to_intel_crtc_state(old_crtc_state),
 					pipe_config, true)) {
 			crtc_state->mode_changed = false;
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 3/5
#5 lore raw

Re: [PATCH 3/5] drm/i915: Enable fastset for non-boot modesets.

Quoted 11 lines · Maarten Lankhorst

Now that our state comparison functions are pretty complete, we should enable fastset by default when a modeset can be avoided. Even if we're not completely certain about the inherited state, we can be certain after the first modeset that our sw state matches the hw state.

There is one testcase explicitly testing fastset, kms_panel_fitting.atomic-fastset but other testcases do so indirectly because most tests don't clean up the display during exit, or otherwise indirectly preserve mode by doing igt_display_reset or inheriting during init.

Quoted 3 lines
Quoted 22 lines
---
  drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +5 -0
index 696e6f5680df..f8cbdd50fa38 100644
@@ -11671,6 +11671,11 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
  		(current_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
  		!(pipe_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
 
+	if (fixup_inherited && !i915_modparams.fastboot) {
+		drm_dbg(DRM_UT_KMS, "initial modeset and fastboot not set\n");
+		ret = false;
+	}
+
  #define PIPE_CONF_CHECK_X(name) do { \
  	if (current_config->name != pipe_config->name) { \
  		pipe_config_err(adjust, __stringify(name), \

drivers/gpu/drm/i915/intel_display.c static int intel_atomic_check(struct drm_device *dev, · line 12705

Quoted 9 lines
drivers/gpu/drm/i915/intel_display.c +1 -2
@@ -12694,8 +12699,7 @@ static int intel_atomic_check(struct drm_device *dev,
  			return ret;
  		}
 
-		if (i915_modparams.fastboot &&
-		    intel_pipe_config_compare(dev_priv,
+		if (intel_pipe_config_compare(dev_priv,
  					to_intel_crtc_state(old_crtc_state),
  					pipe_config, true)) {
  			crtc_state->mode_changed = false;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#6 lore raw

Re: [PATCH 3/5] drm/i915: Enable fastset for non-boot modesets.

In reply to Maarten Lankhorst
Quoted 23 lines · Maarten Lankhorst

Now that our state comparison functions are pretty complete, we should enable fastset by default when a modeset can be avoided. Even if we're not completely certain about the inherited state, we can be certain after the first modeset that our sw state matches the hw state.

There is one testcase explicitly testing fastset, kms_panel_fitting.atomic-fastset but other testcases do so indirectly because most tests don't clean up the display during exit, or otherwise indirectly preserve mode by doing igt_display_reset or inheriting during init.

---
 drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 696e6f5680df..f8cbdd50fa38 100644

drivers/gpu/drm/i915/intel_display.c intel_pipe_config_compare(struct drm_i915_private *dev_priv, · line 11675

Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -11671,6 +11671,11 @@ intel_pipe_config_compare(struct drm_i915_private *dev_priv,
 		(current_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
 		!(pipe_config->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
 
+	if (fixup_inherited && !i915_modparams.fastboot) {
+		drm_dbg(DRM_UT_KMS, "initial modeset and fastboot not set\n");

DRM_DEBUG_KMS() please.

Quoted 16 lines
drivers/gpu/drm/i915/intel_display.c +4 -2
+		ret = false;
+	}
+
 #define PIPE_CONF_CHECK_X(name) do { \
 	if (current_config->name != pipe_config->name) { \
 		pipe_config_err(adjust, __stringify(name), \
@@ -12694,8 +12699,7 @@ static int intel_atomic_check(struct drm_device *dev,
 			return ret;
 		}
 
-		if (i915_modparams.fastboot &&
-		    intel_pipe_config_compare(dev_priv,
+		if (intel_pipe_config_compare(dev_priv,
 					to_intel_crtc_state(old_crtc_state),
 					pipe_config, true)) {
 			crtc_state->mode_changed = false;
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

PATCH 4/5 drm/i915: Make HW readout mark CRTC scaler as in use.

In reply to Maarten Lankhorst

This way we don't accidentally double allocate it. Noticed this when I wrote a patch to sanity check all of the scaler state.

---
 drivers/gpu/drm/i915/intel_display.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_display.c +1 -0
index f8cbdd50fa38..f902f720a3fb 100644
@@ -8869,6 +8869,7 @@ static void skylake_get_pfit_config(struct intel_crtc *crtc,
 			pipe_config->pch_pfit.enabled = true;
 			pipe_config->pch_pfit.pos = I915_READ(SKL_PS_WIN_POS(crtc->pipe, i));
 			pipe_config->pch_pfit.size = I915_READ(SKL_PS_WIN_SZ(crtc->pipe, i));
+			scaler_state->scalers[i].in_use = true;
 			break;
 		}
 	}
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH 5/5 drm/i915: Re-enable fastset by default

In reply to Maarten Lankhorst

Now that we've solved the backlight issue, I think it's time to enable this again by default. We've enabled it in the past, but backlight issues prevented us from enabling it by default.

Our hardware readout is pretty complete, and with all of the connector state moved to atomic I'm hoping we finally have enough capability to re-enable fastset by default.

---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +1 -1
index 6efcf330bdab..7dd71bc85106 100644
@@ -66,7 +66,7 @@ struct drm_printer;
 	/* leave bools at the end to not create holes */ \
 	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
 	param(bool, enable_hangcheck, true) \
-	param(bool, fastboot, false) \
+	param(bool, fastboot, true) \
 	param(bool, prefault_disable, false) \
 	param(bool, load_detect_test, false) \
 	param(bool, force_reset_modeset_test, false) \
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 5/5
#9 lore raw

Re: [PATCH 5/5] drm/i915: Re-enable fastset by default

Quoted 9 lines · Maarten Lankhorst

Now that we've solved the backlight issue, I think it's time to enable this again by default. We've enabled it in the past, but backlight issues prevented us from enabling it by default.

Our hardware readout is pretty complete, and with all of the connector state moved to atomic I'm hoping we finally have enough capability to re-enable fastset by default.

Quoted 10 lines
---
  drivers/gpu/drm/i915/i915_params.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_params.h +0 -0
index 6efcf330bdab..7dd71bc85106 100644

drivers/gpu/drm/i915/i915_params.h struct drm_printer; · line 72

Quoted 8 lines
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -66,7 +66,7 @@ struct drm_printer;
  	/* leave bools at the end to not create holes */ \
  	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
  	param(bool, enable_hangcheck, true) \
-	param(bool, fastboot, false) \
+	param(bool, fastboot, true) \
  	param(bool, prefault_disable, false) \
  	param(bool, load_detect_test, false) \
  	param(bool, force_reset_modeset_test, false) \

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.
URL : https://patchwork.freedesktop.org/series/54896/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
166eabf8e961 drm/i915/backlight: Restore backlight on resume, v3.
-:25: WARNING:BAD_SIGN_OFF: Duplicate signature
#25: 
Signed-off-by: Maarten Lankhorst <[email protected]>

total: 0 errors, 1 warnings, 0 checks, 115 lines checked 3d64968ecaff drm/i915/backlight: Fix backlight takeover on LPT, v3. 333cb43bd431 drm/i915: Enable fastset for non-boot modesets. -:44: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #44: FILE: drivers/gpu/drm/i915/intel_display.c:12703:
+ if (intel_pipe_config_compare(dev_priv,
to_intel_crtc_state(old_crtc_state),

total: 0 errors, 0 warnings, 1 checks, 20 lines checked 03101c92e0e0 drm/i915: Make HW readout mark CRTC scaler as in use. 3d1540509b3c drm/i915: Re-enable fastset by default

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.
URL : https://patchwork.freedesktop.org/series/54896/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/backlight: Restore backlight on resume, v3.
Okay!

Commit: drm/i915/backlight: Fix backlight takeover on LPT, v3. -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void)

Commit: drm/i915: Enable fastset for non-boot modesets. Okay!

Commit: drm/i915: Make HW readout mark CRTC scaler as in use. Okay!

Commit: drm/i915: Re-enable fastset by default
Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.
URL : https://patchwork.freedesktop.org/series/54896/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5378 -> Patchwork_11255
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54896/revisions/1/

Known issues
------------

Here are the changes found in Patchwork_11255 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#107341]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]

* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998]

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: PASS -> DMESG-FAIL [fdo#102614]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]

#### Possible fixes ####

* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS

* igt@gem_exec_suspend@basic-s4-devices:
- fi-bsw-kefka: DMESG-WARN -> PASS
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS

* igt@i915_selftest@live_hangcheck:
- fi-apl-guc: DMESG-FAIL [fdo#109228] -> PASS

* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: FAIL [fdo#103167] -> PASS

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: INCOMPLETE [fdo#102657] -> PASS

* igt@kms_psr@sprite_plane_onoff:
- fi-skl-6700hq: FAIL [fdo#107383] -> PASS +3

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102657]: https://bugs.freedesktop.org/show_bug.cgi?id=102657
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107341]: https://bugs.freedesktop.org/show_bug.cgi?id=107341
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109228]: https://bugs.freedesktop.org/show_bug.cgi?id=109228

Participating hosts (48 -> 43)
------------------------------

Missing (5): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-glk-j4005

Build changes
-------------

* Linux: CI_DRM_5378 -> Patchwork_11255

CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11255: 3d1540509b3c003c691c1937c80111c0946e1a9a @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

3d1540509b3c drm/i915: Re-enable fastset by default 03101c92e0e0 drm/i915: Make HW readout mark CRTC scaler as in use. 333cb43bd431 drm/i915: Enable fastset for non-boot modesets. 3d64968ecaff drm/i915/backlight: Fix backlight takeover on LPT, v3. 166eabf8e961 drm/i915/backlight: Restore backlight on resume, v3.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11255/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#13 lore raw

✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3.
URL : https://patchwork.freedesktop.org/series/54896/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5378_full -> Patchwork_11255_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_11255_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_11255_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11255_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_whisper@normal:
- shard-skl: PASS -> INCOMPLETE

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-iclb: PASS -> FAIL

Known issues
------------

Here are the changes found in Patchwork_11255_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-skl: NOTRUN -> TIMEOUT [fdo#108039]

* igt@kms_busy@extended-modeset-hang-newfb-render-c:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#107956] +3

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
- shard-kbl: NOTRUN -> DMESG-WARN [fdo#107956]

* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +3

* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-glk: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-iclb: PASS -> FAIL [fdo#103167] +5

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-skl: NOTRUN -> FAIL [fdo#105683]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-skl: NOTRUN -> FAIL [fdo#103167]

* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: PASS -> INCOMPLETE [fdo#107713]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-skl: NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166] +1

* igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
- shard-iclb: PASS -> FAIL [fdo#103166]

* igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
- shard-kbl: NOTRUN -> FAIL [fdo#103166]

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-iclb: PASS -> DMESG-FAIL [fdo#107724]

* igt@kms_setmode@basic:
- shard-kbl: NOTRUN -> FAIL [fdo#99912]

* igt@kms_sysfs_edid_timing:
- shard-iclb: PASS -> FAIL [fdo#100047]

* igt@perf_pmu@rc6-runtime-pm-long:
- shard-skl: PASS -> FAIL [fdo#105010]

* igt@pm_rpm@fences-dpms:
- shard-skl: PASS -> INCOMPLETE [fdo#107807] +1

* igt@pm_rpm@universal-planes:
- shard-iclb: PASS -> DMESG-WARN [fdo#108654]

#### Possible fixes ####

* igt@i915_selftest@live_workarounds:
- shard-iclb: DMESG-FAIL [fdo#108954] -> PASS

* igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#109225] -> PASS +1

* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: FAIL [fdo#106641] -> PASS

* igt@kms_color@pipe-c-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS

* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +2

* igt@kms_draw_crc@draw-method-xrgb2101010-render-untiled:
- shard-iclb: WARN [fdo#108336] -> PASS +4

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +5

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-iclb: DMESG-FAIL [fdo#107720] / [fdo#107724] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +4
- shard-glk: FAIL [fdo#103167] -> PASS +1

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +13

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-iclb: DMESG-FAIL [fdo#103166] / [fdo#107724] -> PASS

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-glk: FAIL [fdo#103166] -> PASS

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-FAIL [fdo#108950] -> PASS

* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS

* igt@perf_pmu@event-wait-rcs0:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +23

* igt@pm_rpm@gem-execbuf:
- shard-iclb: INCOMPLETE [fdo#108840] -> PASS

* igt@pm_rpm@modeset-lpsp-stress:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS

* igt@pm_rpm@modeset-stress-extra-wait:
- shard-iclb: DMESG-WARN [fdo#108654] -> PASS

* igt@pm_rps@min-max-config-loaded:
- shard-apl: FAIL [fdo#102250] -> PASS

#### Warnings ####

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#107725]

* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-iclb: DMESG-FAIL [fdo#107724] -> FAIL [fdo#107882]

* igt@kms_psr@no_drrs:
- shard-iclb: DMESG-WARN [fdo#107724] -> FAIL [fdo#108341]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107720]: https://bugs.freedesktop.org/show_bug.cgi?id=107720
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108039]: https://bugs.freedesktop.org/show_bug.cgi?id=108039
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
[fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954
[fdo#109225]: https://bugs.freedesktop.org/show_bug.cgi?id=109225
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (7 -> 7)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_5378 -> Patchwork_11255

CI_DRM_5378: 96b07848e43c024bd6a5a44970371c4866140a1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11255: 3d1540509b3c003c691c1937c80111c0946e1a9a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11255/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)
URL : https://patchwork.freedesktop.org/series/54896/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0cd0b789cc0b drm/i915/backlight: Restore backlight on resume, v3.
-:25: WARNING:BAD_SIGN_OFF: Duplicate signature
#25: 
Signed-off-by: Maarten Lankhorst <[email protected]>

total: 0 errors, 1 warnings, 0 checks, 115 lines checked fdf463f0ab72 drm/i915/backlight: Fix backlight takeover on LPT, v3. eb50555aeccd drm/i915: Enable fastset for non-boot modesets. -:44: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #44: FILE: drivers/gpu/drm/i915/intel_display.c:12702:
+ if (intel_pipe_config_compare(dev_priv,
to_intel_crtc_state(old_crtc_state),

total: 0 errors, 0 warnings, 1 checks, 20 lines checked 55a70fd879df drm/i915: Make HW readout mark CRTC scaler as in use. 53109c96d2f1 drm/i915: Re-enable fastset by default

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)
URL : https://patchwork.freedesktop.org/series/54896/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/backlight: Restore backlight on resume, v3.
Okay!

Commit: drm/i915/backlight: Fix backlight takeover on LPT, v3. -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) -O:drivers/gpu/drm/i915/intel_panel.c:1521:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void) +drivers/gpu/drm/i915/intel_panel.c:1531:34: warning: expression using sizeof(void)

Commit: drm/i915: Enable fastset for non-boot modesets. Okay!

Commit: drm/i915: Make HW readout mark CRTC scaler as in use. Okay!

Commit: drm/i915: Re-enable fastset by default
Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)
URL : https://patchwork.freedesktop.org/series/54896/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5382 -> Patchwork_11261
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/54896/revisions/2/

Known issues
------------

Here are the changes found in Patchwork_11261 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]

* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998] +1

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u3: PASS -> FAIL [fdo#103167]
- fi-hsw-peppy: PASS -> DMESG-FAIL [fdo#102614]

#### Possible fixes ####

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241

Participating hosts (47 -> 45)
------------------------------

Additional (2): fi-icl-y fi-snb-2520m
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan

Build changes
-------------

* Linux: CI_DRM_5382 -> Patchwork_11261

CI_DRM_5382: f4b4417009b26e8f389f9d4c5c35e2a8daa67c9f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4757: 738f43a54d626f08e250c926a5aeec53458fbd3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11261: 53109c96d2f1641d71adc656f23f5ca304d592b7 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

53109c96d2f1 drm/i915: Re-enable fastset by default 55a70fd879df drm/i915: Make HW readout mark CRTC scaler as in use. eb50555aeccd drm/i915: Enable fastset for non-boot modesets. fdf463f0ab72 drm/i915/backlight: Fix backlight takeover on LPT, v3. 0cd0b789cc0b drm/i915/backlight: Restore backlight on resume, v3.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11261/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/5] drm/i915/backlight: Restore backlight on resume, v3. (rev2)
URL : https://patchwork.freedesktop.org/series/54896/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5382_full -> Patchwork_11261_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_11261_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_11261_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_11261_full:

### IGT changes ###

#### Warnings ####

* igt@gem_cpu_reloc@full:
- shard-skl: TIMEOUT [fdo#108248] -> INCOMPLETE

Known issues
------------

Here are the changes found in Patchwork_11261_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_schedule@pi-ringfull-blt:
- shard-kbl: NOTRUN -> FAIL [fdo#103158]

* igt@gem_userptr_blits@readonly-unsync:
- shard-iclb: PASS -> INCOMPLETE [fdo#108342]

* igt@i915_suspend@shrink:
- shard-apl: NOTRUN -> DMESG-WARN [fdo#107886] / [fdo#109244]
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#107886] / [fdo#109244]

* igt@kms_busy@extended-modeset-hang-newfb-render-c:

    - shard-glk:          NOTRUN -> DMESG-WARN [fdo#107956] +2
    - shard-hsw:          NOTRUN -> DMESG-WARN [fdo#107956]
    - shard-skl:          NOTRUN -> DMESG-WARN [fdo#107956] +1
    - shard-kbl:          PASS -> DMESG-WARN [fdo#107956]

* igt@kms_busy@extended-modeset-hang-oldfb-with-reset-render-a:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]

* igt@kms_color@pipe-a-gamma:
- shard-skl: PASS -> FAIL [fdo#104782]

* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: PASS -> FAIL [fdo#104782]

* igt@kms_cursor_crc@cursor-128x128-dpms:
- shard-apl: PASS -> FAIL [fdo#103232]

* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]

* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: NOTRUN -> FAIL [fdo#103232] +1

* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: NOTRUN -> FAIL [fdo#105454] / [fdo#106509]

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-iclb: PASS -> WARN [fdo#108336]

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
- shard-skl: PASS -> FAIL [fdo#108222]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-skl: PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@kms_fbcon_fbt@psr:
- shard-skl: NOTRUN -> FAIL [fdo#107882]

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] +5
- shard-skl: PASS -> FAIL [fdo#105363]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +1

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-glk: NOTRUN -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-hsw: NOTRUN -> FAIL [fdo#105682]
- shard-skl: NOTRUN -> FAIL [fdo#105683]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-skl: PASS -> FAIL [fdo#103167] +2

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-iclb: PASS -> FAIL [fdo#103167] +4

* igt@kms_frontbuffer_tracking@fbcpsr-farfromfence:
- shard-skl: PASS -> FAIL [fdo#105682]

* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-snb: SKIP -> INCOMPLETE [fdo#105411]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: PASS -> DMESG-WARN [fdo#107724] / [fdo#108336] +1

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-skl: NOTRUN -> INCOMPLETE [fdo#104108] / [fdo#107773]

* igt@kms_plane@pixel-format-pipe-b-planes:
- shard-skl: NOTRUN -> DMESG-WARN [fdo#106885]

* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-iclb: PASS -> FAIL [fdo#103166]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145] +2

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: NOTRUN -> FAIL [fdo#108145]

* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: NOTRUN -> FAIL [fdo#103166] +2

* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-apl: PASS -> FAIL [fdo#103166] +3

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: NOTRUN -> DMESG-WARN [fdo#105763] / [fdo#106538]

* igt@kms_setmode@basic:
- shard-glk: NOTRUN -> FAIL [fdo#99912]

* igt@pm_backlight@fade_with_suspend:
- shard-skl: NOTRUN -> FAIL [fdo#107847]

* igt@pm_rpm@pm-caching:
- shard-iclb: PASS -> INCOMPLETE [fdo#108840]

#### Possible fixes ####

* igt@gem_pwrite@big-gtt-fbr:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS

* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
- shard-skl: DMESG-WARN [fdo#107956] -> PASS

* igt@kms_chv_cursor_fail@pipe-c-256x256-right-edge:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> PASS +2

* igt@kms_color@pipe-c-degamma:
- shard-apl: FAIL [fdo#104782] -> PASS

* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2

* igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
- shard-iclb: WARN [fdo#108336] -> PASS

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: FAIL [fdo#105363] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: DMESG-FAIL [fdo#107720] / [fdo#107724] -> PASS

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-apl: FAIL [fdo#103167] -> PASS

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-wc:
- shard-iclb: DMESG-FAIL [fdo#107724] -> PASS +1

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-fullscreen:
- shard-iclb: FAIL [fdo#103167] -> PASS +1

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS

* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-iclb: FAIL [fdo#103166] -> PASS +1

* igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
- shard-apl: FAIL [fdo#103166] -> PASS

* igt@kms_rmfb@rmfb-ioctl:
- shard-iclb: DMESG-WARN [fdo#107724] -> PASS +12

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-iclb: INCOMPLETE [fdo#107713] -> PASS

* igt@pm_rpm@reg-read-ioctl:
- shard-skl: INCOMPLETE [fdo#107807] -> PASS

#### Warnings ####

* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-iclb: DMESG-WARN [fdo#107724] / [fdo#108336] -> FAIL [fdo#103232]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-wc:
- shard-iclb: DMESG-FAIL [fdo#107724] -> FAIL [fdo#103167]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107720]: https://bugs.freedesktop.org/show_bug.cgi?id=107720
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#107847]: https://bugs.freedesktop.org/show_bug.cgi?id=107847
[fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
[fdo#107886]: https://bugs.freedesktop.org/show_bug.cgi?id=107886
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108222]: https://bugs.freedesktop.org/show_bug.cgi?id=108222
[fdo#108248]: https://bugs.freedesktop.org/show_bug.cgi?id=108248
[fdo#108336]: https://bugs.freedesktop.org/show_bug.cgi?id=108336
[fdo#108342]: https://bugs.freedesktop.org/show_bug.cgi?id=108342
[fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109241]: https://bugs.freedesktop.org/show_bug.cgi?id=109241
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (6 -> 7)
------------------------------

Additional (1): shard-glk

Build changes
-------------

* Linux: CI_DRM_5382 -> Patchwork_11261

CI_DRM_5382: f4b4417009b26e8f389f9d4c5c35e2a8daa67c9f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4757: 738f43a54d626f08e250c926a5aeec53458fbd3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_11261: 53109c96d2f1641d71adc656f23f5ca304d592b7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11261/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/5
#18 lore raw
In reply to Maarten Lankhorst

Hi,

Quoted 10 lines · Maarten Lankhorst

Restore our saved values for backlight. This way even with fastset on S4 resume we will correctly restore the backlight to the active values.

Changes since v1:
- Call enable_backlight() when backlight.level is set. On suspend backlight.enabled is always cleared, this makes it not a good indicator. Also check for crtc->state->active.
Changes since v2:
- Use the new update_pipe() callback to run this on resume as well.

Quoted 7 lines

Entire series looks good to me:

Regards,

Hans

p.s.

I'll also reply to the other 4 patches to get the Rev-by on all patches in patchwork.

Quoted 156 lines
---
  drivers/gpu/drm/i915/icl_dsi.c     |  1 +
  drivers/gpu/drm/i915/intel_ddi.c   |  2 ++
  drivers/gpu/drm/i915/intel_dp.c    |  1 +
  drivers/gpu/drm/i915/intel_drv.h   |  3 ++
  drivers/gpu/drm/i915/intel_lvds.c  |  1 +
  drivers/gpu/drm/i915/intel_panel.c | 49 +++++++++++++++++++++++-------
  drivers/gpu/drm/i915/vlv_dsi.c     |  1 +
  7 files changed, 47 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/icl_dsi.c +1 -0
index 4dd793b78996..3f92881600c5 100644
@@ -1378,6 +1378,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
  	encoder->disable = gen11_dsi_disable;
  	encoder->port = port;
  	encoder->get_config = gen11_dsi_get_config;
+	encoder->update_pipe = intel_panel_update_backlight;
  	encoder->compute_config = gen11_dsi_compute_config;
  	encoder->get_hw_state = gen11_dsi_get_hw_state;
  	encoder->type = INTEL_OUTPUT_DSI;
drivers/gpu/drm/i915/intel_ddi.c +2 -0
index 2d6ed990a232..d32865dc44e8 100644
@@ -3548,6 +3548,8 @@ static void intel_ddi_update_pipe_dp(struct intel_encoder *encoder,
 
  	intel_psr_enable(intel_dp, crtc_state);
  	intel_edp_drrs_enable(intel_dp, crtc_state);
+
+	intel_panel_update_backlight(encoder, crtc_state, conn_state);
  }
 
  static void intel_ddi_update_pipe(struct intel_encoder *encoder,
drivers/gpu/drm/i915/intel_dp.c +1 -0
index 62fd11540942..0cbacdc70b07 100644
@@ -6981,6 +6981,7 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
  	intel_encoder->compute_config = intel_dp_compute_config;
  	intel_encoder->get_hw_state = intel_dp_get_hw_state;
  	intel_encoder->get_config = intel_dp_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
  	intel_encoder->suspend = intel_dp_encoder_suspend;
  	if (IS_CHERRYVIEW(dev_priv)) {
  		intel_encoder->pre_pll_enable = chv_dp_pre_pll_enable;
drivers/gpu/drm/i915/intel_drv.h +3 -0
index 1a11c2beb7f3..0a6fb42e2086 100644
@@ -2023,6 +2023,9 @@ int intel_panel_setup_backlight(struct drm_connector *connector,
  				enum pipe pipe);
  void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
  				  const struct drm_connector_state *conn_state);
+void intel_panel_update_backlight(struct intel_encoder *encoder,
+				  const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state);
  void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
  extern struct drm_display_mode *intel_find_panel_downclock(
  				struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/intel_lvds.c +1 -0
index b85e195f7c8a..189693b4c5e8 100644
@@ -909,6 +909,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
  	}
  	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
  	intel_encoder->get_config = intel_lvds_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
  	intel_connector->get_hw_state = intel_connector_get_hw_state;
 
  	intel_connector_attach_encoder(intel_connector, intel_encoder);
drivers/gpu/drm/i915/intel_panel.c +38 -11
index ee3e0842d542..f71b33cf1c97 100644
@@ -1087,20 +1087,11 @@ static void pwm_enable_backlight(const struct intel_crtc_state *crtc_state,
  	intel_panel_actually_set_backlight(conn_state, panel->backlight.level);
  }
 
-void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
-				  const struct drm_connector_state *conn_state)
+static void __intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
+					   const struct drm_connector_state *conn_state)
  {
  	struct intel_connector *connector = to_intel_connector(conn_state->connector);
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
  	struct intel_panel *panel = &connector->panel;
-	enum pipe pipe = to_intel_crtc(crtc_state->base.crtc)->pipe;
-
-	if (!panel->backlight.present)
-		return;
-
-	DRM_DEBUG_KMS("pipe %c\n", pipe_name(pipe));
-
-	mutex_lock(&dev_priv->backlight_lock);
 
  	WARN_ON(panel->backlight.max == 0);
 
@@ -1117,6 +1108,24 @@ void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
  	panel->backlight.enabled = true;
  	if (panel->backlight.device)
  		panel->backlight.device->props.power = FB_BLANK_UNBLANK;
+}
+
+void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state)
+{
+	struct intel_connector *connector = to_intel_connector(conn_state->connector);
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	struct intel_panel *panel = &connector->panel;
+	enum pipe pipe = to_intel_crtc(crtc_state->base.crtc)->pipe;
+
+	if (!panel->backlight.present)
+		return;
+
+	DRM_DEBUG_KMS("pipe %c\n", pipe_name(pipe));
+
+	mutex_lock(&dev_priv->backlight_lock);
+
+	__intel_panel_enable_backlight(crtc_state, conn_state);
 
  	mutex_unlock(&dev_priv->backlight_lock);
  }
@@ -1773,6 +1782,24 @@ static int pwm_setup_backlight(struct intel_connector *connector,
  	return 0;
  }
 
+void intel_panel_update_backlight(struct intel_encoder *encoder,
+				  const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state)
+{
+	struct intel_connector *connector = to_intel_connector(conn_state->connector);
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	struct intel_panel *panel = &connector->panel;
+
+	if (!panel->backlight.present)
+		return;
+
+	mutex_lock(&dev_priv->backlight_lock);
+	if (!panel->backlight.enabled)
+		__intel_panel_enable_backlight(crtc_state, conn_state);
+
+	mutex_unlock(&dev_priv->backlight_lock);
+}
+
  int intel_panel_setup_backlight(struct drm_connector *connector, enum pipe pipe)
  {
  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
drivers/gpu/drm/i915/vlv_dsi.c +0 -0
index 361e962a7969..3dcf7ddca032 100644

drivers/gpu/drm/i915/vlv_dsi.c void vlv_dsi_init(struct drm_i915_private *dev_priv) · line 1695

Quoted 7 lines
drivers/gpu/drm/i915/vlv_dsi.c +1 -0
@@ -1689,6 +1689,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
  	intel_encoder->post_disable = intel_dsi_post_disable;
  	intel_encoder->get_hw_state = intel_dsi_get_hw_state;
  	intel_encoder->get_config = intel_dsi_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 
  	intel_connector->get_hw_state = intel_connector_get_hw_state;
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 1/5
#19 lore raw
In reply to Maarten Lankhorst
Quoted 10 lines · Maarten Lankhorst

Restore our saved values for backlight. This way even with fastset on S4 resume we will correctly restore the backlight to the active values.

Changes since v1:
- Call enable_backlight() when backlight.level is set. On suspend backlight.enabled is always cleared, this makes it not a good indicator. Also check for crtc->state->active.
Changes since v2:
- Use the new update_pipe() callback to run this on resume as well.

Quoted 7 lines
Quoted 161 lines
---
 drivers/gpu/drm/i915/icl_dsi.c     |  1 +
 drivers/gpu/drm/i915/intel_ddi.c   |  2 ++
 drivers/gpu/drm/i915/intel_dp.c    |  1 +
 drivers/gpu/drm/i915/intel_drv.h   |  3 ++
 drivers/gpu/drm/i915/intel_lvds.c  |  1 +
 drivers/gpu/drm/i915/intel_panel.c | 49 +++++++++++++++++++++++-------
 drivers/gpu/drm/i915/vlv_dsi.c     |  1 +
 7 files changed, 47 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/icl_dsi.c +1 -0
index 4dd793b78996..3f92881600c5 100644
@@ -1378,6 +1378,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
 	encoder->disable = gen11_dsi_disable;
 	encoder->port = port;
 	encoder->get_config = gen11_dsi_get_config;
+	encoder->update_pipe = intel_panel_update_backlight;
 	encoder->compute_config = gen11_dsi_compute_config;
 	encoder->get_hw_state = gen11_dsi_get_hw_state;
 	encoder->type = INTEL_OUTPUT_DSI;
drivers/gpu/drm/i915/intel_ddi.c +2 -0
index 2d6ed990a232..d32865dc44e8 100644
@@ -3548,6 +3548,8 @@ static void intel_ddi_update_pipe_dp(struct intel_encoder *encoder,
 
 	intel_psr_enable(intel_dp, crtc_state);
 	intel_edp_drrs_enable(intel_dp, crtc_state);
+
+	intel_panel_update_backlight(encoder, crtc_state, conn_state);
 }
 
 static void intel_ddi_update_pipe(struct intel_encoder *encoder,
drivers/gpu/drm/i915/intel_dp.c +1 -0
index 62fd11540942..0cbacdc70b07 100644
@@ -6981,6 +6981,7 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
 	intel_encoder->compute_config = intel_dp_compute_config;
 	intel_encoder->get_hw_state = intel_dp_get_hw_state;
 	intel_encoder->get_config = intel_dp_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 	intel_encoder->suspend = intel_dp_encoder_suspend;
 	if (IS_CHERRYVIEW(dev_priv)) {
 		intel_encoder->pre_pll_enable = chv_dp_pre_pll_enable;
drivers/gpu/drm/i915/intel_drv.h +3 -0
index 1a11c2beb7f3..0a6fb42e2086 100644
@@ -2023,6 +2023,9 @@ int intel_panel_setup_backlight(struct drm_connector *connector,
 				enum pipe pipe);
 void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
 				  const struct drm_connector_state *conn_state);
+void intel_panel_update_backlight(struct intel_encoder *encoder,
+				  const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state);
 void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state);
 extern struct drm_display_mode *intel_find_panel_downclock(
 				struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/intel_lvds.c +1 -0
index b85e195f7c8a..189693b4c5e8 100644
@@ -909,6 +909,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
 	}
 	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
 	intel_encoder->get_config = intel_lvds_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 	intel_connector->get_hw_state = intel_connector_get_hw_state;
 
 	intel_connector_attach_encoder(intel_connector, intel_encoder);
drivers/gpu/drm/i915/intel_panel.c +38 -11
index ee3e0842d542..f71b33cf1c97 100644
@@ -1087,20 +1087,11 @@ static void pwm_enable_backlight(const struct intel_crtc_state *crtc_state,
 	intel_panel_actually_set_backlight(conn_state, panel->backlight.level);
 }
 
-void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
-				  const struct drm_connector_state *conn_state)
+static void __intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
+					   const struct drm_connector_state *conn_state)
 {
 	struct intel_connector *connector = to_intel_connector(conn_state->connector);
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct intel_panel *panel = &connector->panel;
-	enum pipe pipe = to_intel_crtc(crtc_state->base.crtc)->pipe;
-
-	if (!panel->backlight.present)
-		return;
-
-	DRM_DEBUG_KMS("pipe %c\n", pipe_name(pipe));
-
-	mutex_lock(&dev_priv->backlight_lock);
 
 	WARN_ON(panel->backlight.max == 0);
 
@@ -1117,6 +1108,24 @@ void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
 	panel->backlight.enabled = true;
 	if (panel->backlight.device)
 		panel->backlight.device->props.power = FB_BLANK_UNBLANK;
+}
+
+void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state)
+{
+	struct intel_connector *connector = to_intel_connector(conn_state->connector);
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	struct intel_panel *panel = &connector->panel;
+	enum pipe pipe = to_intel_crtc(crtc_state->base.crtc)->pipe;
+
+	if (!panel->backlight.present)
+		return;
+
+	DRM_DEBUG_KMS("pipe %c\n", pipe_name(pipe));
+
+	mutex_lock(&dev_priv->backlight_lock);
+
+	__intel_panel_enable_backlight(crtc_state, conn_state);
 
 	mutex_unlock(&dev_priv->backlight_lock);
 }
@@ -1773,6 +1782,24 @@ static int pwm_setup_backlight(struct intel_connector *connector,
 	return 0;
 }
 
+void intel_panel_update_backlight(struct intel_encoder *encoder,
+				  const struct intel_crtc_state *crtc_state,
+				  const struct drm_connector_state *conn_state)
+{
+	struct intel_connector *connector = to_intel_connector(conn_state->connector);
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	struct intel_panel *panel = &connector->panel;
+
+	if (!panel->backlight.present)
+		return;
+
+	mutex_lock(&dev_priv->backlight_lock);
+	if (!panel->backlight.enabled)
+		__intel_panel_enable_backlight(crtc_state, conn_state);
+
+	mutex_unlock(&dev_priv->backlight_lock);
+}
+
 int intel_panel_setup_backlight(struct drm_connector *connector, enum pipe pipe)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->dev);
drivers/gpu/drm/i915/vlv_dsi.c +1 -0
index 361e962a7969..3dcf7ddca032 100644
@@ -1689,6 +1689,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
 	intel_encoder->post_disable = intel_dsi_post_disable;
 	intel_encoder->get_hw_state = intel_dsi_get_hw_state;
 	intel_encoder->get_config = intel_dsi_get_config;
+	intel_encoder->update_pipe = intel_panel_update_backlight;
 
 	intel_connector->get_hw_state = intel_connector_get_hw_state;
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx