Skip to contentSkip to conversation

xenomai: remove unnecessary autoreconf

PATCH New Thomas De Schampheleire 3 participants 10 messages Jan 8, 2019 – Jan 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

From: Thomas De Schampheleire <[email protected]>

As xenomai release tarballs ship with a configure script, there is only a need for autoreconfiguring when patches are applied.

The last patch was removed with git commit de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

---
 package/xenomai/xenomai.mk | 2 --
 1 file changed, 2 deletions(-)
package/xenomai/xenomai.mk +0 -2
index 6bf08edfbc..d88e969adb 100644
@@ -24,8 +24,6 @@ XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \
 
 XENOMAI_DEPENDENCIES = host-pkgconf
 
-# 0002-boilerplate-build-obstack-support-conditionally.patch
-XENOMAI_AUTORECONF = YES
 
 XENOMAI_INSTALL_STAGING = YES
 XENOMAI_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-user
Signature · 1 line
2.18.1
#1 lore raw

PATCH 2/2 DEVELOPERS: add Thomas De Schampheleire for xenomai

From: Thomas De Schampheleire <[email protected]>

---
 DEVELOPERS | 1 +
 1 file changed, 1 insertion(+)
DEVELOPERS +1 -0
index e561739fab..3b3923ae4f 100644
@@ -2076,6 +2076,7 @@ F:	package/perl-net-snmp/
 F:	package/perl-net-ssh2/
 F:	package/perl-net-telnet/
 F:	package/pigz/
+F:	package/xenomai/
 F:	support/scripts/size-stats
 F:	utils/size-stats-compare
 F:	toolchain/
Signature · 1 line
2.18.1
#3 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

In reply to Thomas De Schampheleire
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> As xenomai release tarballs ship with a configure script, there is only a need for autoreconfiguring when patches are applied.

The last patch was removed with git commit de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

In reply to Thomas De Schampheleire

Thomas DS, All,

On 2019-01-08 21:38 +0100, Thomas De Schampheleire spake thusly:

Quoted 18 lines

From: Thomas De Schampheleire <[email protected]>

As xenomai release tarballs ship with a configure script, there is only a need for autoreconfiguring when patches are applied.

The last patch was removed with git commit de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

---
 package/xenomai/xenomai.mk | 2 --
 1 file changed, 2 deletions(-)
package/xenomai/xenomai.mk +0 -0
index 6bf08edfbc..d88e969adb 100644

package/xenomai/xenomai.mk XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \ · line 27

Quoted 6 lines
package/xenomai/xenomai.mk +0 -2
@@ -24,8 +24,6 @@ XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \
 
 XENOMAI_DEPENDENCIES = host-pkgconf
 
-# 0002-boilerplate-build-obstack-support-conditionally.patch
-XENOMAI_AUTORECONF = YES
 

This is causing failures in the CI:

    https://gitlab.com/buildroot.org/buildroot/pipelines/42622285

because there are now two consecutive empty lines.

Regards,
Yann E. MORIN.

Quoted 9 lines
package/xenomai/xenomai.mk +0 -0
 XENOMAI_INSTALL_STAGING = YES
 XENOMAI_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-user
Signature · 6 lines
2.18.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 9 lines

package/xenomai/xenomai.mk XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \ · line 28

Quoted 3 lines
package/xenomai/xenomai.mk +0 -2
-# 0002-boilerplate-build-obstack-support-conditionally.patch
-XENOMAI_AUTORECONF = YES

This is causing failures in the CI:

    https://gitlab.com/buildroot.org/buildroot/pipelines/42622285

because there are now two consecutive empty lines.

Fixed, thanks. Odd that my check-package post-commit hook didn't catch it.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

El jue., 10 ene. 2019 a las 8:36, Peter Korsgaard
(<[email protected]>) escribi?:

Quoted 11 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 5 lines

package/xenomai/xenomai.mk XENOMAI_LICENSE_FILES = debian/copyright include/COPYING kernel/cobalt/COPYING \ · line 28

Quoted 3 lines
package/xenomai/xenomai.mk +0 -2
-# 0002-boilerplate-build-obstack-support-conditionally.patch
-XENOMAI_AUTORECONF = YES

This is causing failures in the CI:

Quoted 6 lines
Quoted 3 lines
    https://gitlab.com/buildroot.org/buildroot/pipelines/42622285

because there are now two consecutive empty lines.

Fixed, thanks. Odd that my check-package post-commit hook didn't catch it.

Oops, sorry.
Could you show me how to enable this as hook, then I'll add it locally too.

Thanks,
Thomas

#7 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Fixed, thanks. Odd that my check-package post-commit hook didn't catch it.

Oops, sorry.
Could you show me how to enable this as hook, then I'll add it locally too.

I have in .git/hooks/post-commit:

#!/bin/sh

# check-package on added/changed files
git show --no-renames HEAD | \
        lsdiff -s | \
        awk '{ if ($1 != "-") print substr($2, 3) }' | \
        xargs -r ./utils/check-package
Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

El jue., 10 ene. 2019 a las 10:30, Peter Korsgaard (<[email protected]>) escribi?:

Quoted 11 lines
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Fixed, thanks. Odd that my check-package post-commit hook didn't catch it.

Oops, sorry.
Could you show me how to enable this as hook, then I'll add it locally too.

I have in .git/hooks/post-commit:

Quoted 7 lines

#!/bin/sh

# check-package on added/changed files
git show --no-renames HEAD | \
        lsdiff -s | \
        awk '{ if ($1 != "-") print substr($2, 3) }' | \
        xargs -r ./utils/check-package

Thanks!

#9 lore raw

PATCH 1/2 xenomai: remove unnecessary autoreconf

In reply to Thomas De Schampheleire
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

From: Thomas De Schampheleire <[email protected]> As xenomai release tarballs ship with a configure script, there is only a need for autoreconfiguring when patches are applied.

The last patch was removed with git commit de993bc23aab100e16026cb4cabebed48b9e1989 but the AUTORECONF line remained.

Committed to 2018.02.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard