Skip to contentSkip to conversation

printk: Pass groupsize to memory_display() in print_hex_dump()

PATCH Applied Andrey Smirnov 2 participants 2 messages Jan 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 printk: Pass groupsize to memory_display() in print_hex_dump()

Don't hardcode grouping data into 4-byte words in print_hex_dump() implementation and instead pass 'groupsize' to memory_display(), since that's what that parameter is for.

---
 include/printk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/printk.h +1 -1
index aaad07552..ab2c64cf3 100644
@@ -119,7 +119,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str,
 		int prefix_type, int rowsize, int groupsize,
 		const void *buf, size_t len, bool ascii)
 {
-	memory_display(buf, 0, len, 4, 0);
+	memory_display(buf, 0, len, groupsize, 0);
 }
 
 struct log_entry {
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 8 lines · Andrey Smirnov

Don't hardcode grouping data into 4-byte words in print_hex_dump() implementation and instead pass 'groupsize' to memory_display(), since that's what that parameter is for.

---
 include/printk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 23 lines
include/printk.h +1 -1
index aaad07552..ab2c64cf3 100644
@@ -119,7 +119,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str,
 		int prefix_type, int rowsize, int groupsize,
 		const void *buf, size_t len, bool ascii)
 {
-	memory_display(buf, 0, len, 4, 0);
+	memory_display(buf, 0, len, groupsize, 0);
 }
 
 struct log_entry {
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox