Skip to contentSkip to conversation

arm64: dts: mt8173: add pmu nodes for mt8173

PATCH In review Seiya Wang 2 participants 5 messages Jan 9, 2019 – Apr 16, 2019

Subsystems (2)
lore
Share & tools
lore

Seiya Wang

author
#0 lore raw

PATCH 1/1 arm64: dts: mt8173: add pmu nodes for mt8173

This patch adds the device nodes of ARM Performance Monitor Uint for mt8173.

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +14 -0
index 412ffd4d426b..44374c506a1c 100644
@@ -216,6 +216,20 @@
 		};
 	};
 
+	pmu_a53 {
+		compatible = "arm,cortex-a53-pmu";
+		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu0>, <&cpu1>;
+	};
+
+	pmu_a72 {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu2>, <&cpu3>;
+	};
+
 	psci {
 		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
 		method = "smc";
Signature · 1 line
2.14.1
maintainer
#1 lore raw
Quoted 19 lines · Seiya Wang

This patch adds the device nodes of ARM Performance Monitor Uint for mt8173.

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +3 -0
index 412ffd4d426b..44374c506a1c 100644
@@ -216,6 +216,20 @@
 		};
 	};
 
+	pmu_a53 {
+		compatible = "arm,cortex-a53-pmu";
+		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,

arch/arm64/boot/dts/mediatek/mt8173.dtsi line 231

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +10 -0
+			     <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu0>, <&cpu1>;
+	};
+
+	pmu_a72 {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu2>, <&cpu3>;
+	};

There is no a72 but a a57 CPU present.
Typo?

Regards,
Matthias

Quoted 5 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +1 -0
+
 	psci {
 		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
 		method = "smc";
author
#2 lore raw
Quoted 35 lines · Matthias Brugger
Quoted 19 lines · Seiya Wang

This patch adds the device nodes of ARM Performance Monitor Uint for mt8173.

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +3 -0
index 412ffd4d426b..44374c506a1c 100644
@@ -216,6 +216,20 @@
 		};
 	};
 
+	pmu_a53 {
+		compatible = "arm,cortex-a53-pmu";
+		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,

arch/arm64/boot/dts/mediatek/mt8173.dtsi line 231

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +10 -0
+			     <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu0>, <&cpu1>;
+	};
+
+	pmu_a72 {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu2>, <&cpu3>;
+	};

There is no a72 but a a57 CPU present.
Typo?

Quoted 2 lines

Regards,
Matthias

MT8173 is actually using a72, not a57.
I will submit another patch for fixing it.

Thanks.

Quoted 5 lines
Quoted 5 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +1 -0
+
 	psci {
 		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
 		method = "smc";
author
#3 lore raw
In reply to Matthias Brugger
Quoted 35 lines · Matthias Brugger
Quoted 19 lines · Seiya Wang

This patch adds the device nodes of ARM Performance Monitor Uint for mt8173.

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +3 -0
index 412ffd4d426b..44374c506a1c 100644
@@ -216,6 +216,20 @@
 		};
 	};
 
+	pmu_a53 {
+		compatible = "arm,cortex-a53-pmu";
+		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,

arch/arm64/boot/dts/mediatek/mt8173.dtsi line 231

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +10 -0
+			     <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu0>, <&cpu1>;
+	};
+
+	pmu_a72 {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu2>, <&cpu3>;
+	};

There is no a72 but a a57 CPU present.
Typo?

Quoted 2 lines

Regards,
Matthias

Please also apply this (if no problems) since we have changed to ca72. Thanks.

Quoted 5 lines
Quoted 5 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +1 -0
+
 	psci {
 		compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
 		method = "smc";
maintainer
#4 lore raw
Quoted 36 lines · Seiya Wang
Quoted 35 lines · Matthias Brugger
Quoted 19 lines · Seiya Wang

This patch adds the device nodes of ARM Performance Monitor Uint for mt8173.

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +3 -0
index 412ffd4d426b..44374c506a1c 100644
@@ -216,6 +216,20 @@
 		};
 	};
 
+	pmu_a53 {
+		compatible = "arm,cortex-a53-pmu";
+		interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,

arch/arm64/boot/dts/mediatek/mt8173.dtsi line 231

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +10 -0
+			     <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu0>, <&cpu1>;
+	};
+
+	pmu_a72 {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-affinity = <&cpu2>, <&cpu3>;
+	};

There is no a72 but a a57 CPU present.
Typo?

Quoted 6 lines
Quoted 2 lines

Regards,
Matthias

Please also apply this (if no problems) since we have changed to ca72. Thanks.

Pushed now to v5.1-next/dts64

Thanks for the heads up :)