Skip to contentSkip to conversation

sched/credit2: remove stale comment

PATCH In review Juergen Gross 3 participants 4 messages Jan 9, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/credit2: remove stale comment

With being the default scheduler now the comment in sched_credit2 stating it being experimental should be removed.

While at it remove the "TODO" comments already addressed.

---
 xen/common/sched_credit2.c | 6 ------
 1 file changed, 6 deletions(-)
xen/common/sched_credit2.c +0 -6
index 623a325ceb..543dc3664d 100644
@@ -59,19 +59,13 @@
 #define TRC_CSCHED2_RUNQ_CAND_CHECK  TRC_SCHED_CLASS_EVT(CSCHED2, 23)
 
 /*
- * WARNING: This is still in an experimental phase.  Status and work can be found at the
- * credit2 wiki page:
- *  http://wiki.xen.org/wiki/Credit2_Scheduler_Development
- *
  * TODO:
  * + Hyperthreading
- *  - Look for non-busy core if possible
  *  - "Discount" time run on a thread with busy siblings
  * + Algorithm:
  *  - "Mixed work" problem: if a VM is playing audio (5%) but also burning cpu (e.g.,
  *    a flash animation in the background) can we schedule it with low enough latency
  *    so that audio doesn't skip?
- *  - Cap and reservation: How to implement with the current system?
  * + Optimizing
  *  - Profiling, making new algorithms, making math more efficient (no long division)
  */
Signature · 7 lines
2.16.4


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Juergen Gross

With being the default scheduler now the comment in sched_credit2 stating it being experimental should be removed.

While at it remove the "TODO" comments already addressed.

Thanks,
Dario

Signature · 4 lines
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 10 lines
Quoted 1 line
Quoted 1 line · On 09.01.19 at 14:59, <[email protected]> wrote:
Quoted 7 lines · Juergen Gross

With being the default scheduler now the comment in sched_credit2 stating it being experimental should be removed.

While at it remove the "TODO" comments already addressed.

And I guess this is fine to put in for 4.12?

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 5 lines · Jan Beulich
Quoted 5 lines
Quoted 1 line
Quoted 1 line · On 09.01.19 at 14:59, <[email protected]> wrote:
Quoted 3 lines · Juergen Gross

With being the default scheduler now the comment in sched_credit2 stating it being experimental should be removed.

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

While at it remove the "TODO" comments already addressed.

And I guess this is fine to put in for 4.12?

Yes:

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel