Skip to contentSkip to conversation

x86/mm/fault.c: Convert to use vm_fault_t

PATCH In review Souptick Joarder 2 participants 2 messages Jan 9, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 x86/mm/fault.c: Convert to use vm_fault_t

Convert to use vm_fault_t type for last argument of do_sigbus().

kbuild reported a warning during testing of final vm_fault_t patch integrated in mm tree.

[auto build test WARNING on linus/master]
[also build test WARNING on v5.0-rc1 next-20190109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

https://github.com/0day-ci/linux/commits/Souptick-Joarder/
mm-Create-the-new-vm_fault_t-type/20190109-154216

All warnings:

arch/x86/mm/fault.c:1051:39: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1057:29: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1059:29: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1094:62: warning: incorrect type in argument 4 (different base types)
arch/x86/mm/fault.c:1094:62: expected unsigned int fault
arch/x86/mm/fault.c:1094:62: got restricted vm_fault_t [usertype] fault

This patch has fixed the warnings.

---
v2: updated the change log.

 arch/x86/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/mm/fault.c +1 -1
index 2ff25ad..dea3725 100644
@@ -1031,7 +1031,7 @@ static inline bool bad_area_access_from_pkeys(unsigned long error_code,
 
 static void
 do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address,
-	  unsigned int fault)
+	  vm_fault_t fault)
 {
 	struct task_struct *tsk = current;
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · On Thu, 10 Jan 2019 00:07:42 +0530 Souptick Joarder <[email protected]>…

Convert to use vm_fault_t type for last argument of do_sigbus().

kbuild reported a warning during testing of final vm_fault_t patch integrated in mm tree.

Please be more specific when identifying patches.

Quoted 10 lines

[auto build test WARNING on linus/master]
[also build test WARNING on v5.0-rc1 next-20190109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

https://github.com/0day-ci/linux/commits/Souptick-Joarder/
mm-Create-the-new-vm_fault_t-type/20190109-154216

All warnings:

Quoted 9 lines

arch/x86/mm/fault.c:1051:39: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1057:29: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1059:29: warning: restricted vm_fault_t degrades to integer arch/x86/mm/fault.c:1094:62: warning: incorrect type in argument 4 (different base types)
arch/x86/mm/fault.c:1094:62: expected unsigned int fault
arch/x86/mm/fault.c:1094:62: got restricted vm_fault_t [usertype] fault

This patch has fixed the warnings.

I'll be folding this into "mm: Create the new vm_fault_t type".