Skip to contentSkip to conversation

drivers: fix "no previous prototype" warnings

PATCH Applied Antony Pavlov 2 participants 5 messages Jan 9, 2019 – Jan 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover drivers: fix "no previous prototype" warnings

Antony Pavlov (3):
w1: fix "no previous prototype for 'w1_found'" warning
serial: amba-pl011: fix "no previous prototype for 'pl011_init_port'" warning
net: ks8851_mll: fix "no previous prototype for 'ks_enable_qmu'" warning

 drivers/net/ks8851_mll.c    | 2 +-
 drivers/serial/amba-pl011.c | 2 +-
 drivers/w1/w1.c             | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

PATCH 1/3 w1: fix "no previous prototype for 'w1_found'" warning

The patch fixes the following compiler's warning:

drivers/w1/w1.c:459:6: warning: no previous prototype for ‘w1_found’ [-Wmissing-prototypes]
void w1_found(struct w1_bus *bus, u64 rn)

      ^~~~~~~~
---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/w1/w1.c +1 -1
index 694ffa853e..f74046c0b7 100644
@@ -456,7 +456,7 @@ int w1_driver_register(struct w1_driver *drv)
 	return register_driver(&drv->drv);
 }
 
-void w1_found(struct w1_bus *bus, u64 rn)
+static void w1_found(struct w1_bus *bus, u64 rn)
 {
 	struct w1_device *dev;
 	u64 tmp = be64_to_cpu(rn);
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

PATCH 2/3 serial: amba-pl011: fix "no previous prototype for 'pl011_init_port'" warning

In reply to Antony Pavlov

The patch fixes the following compiler's warning:

drivers/serial/amba-pl011.c:151:5: warning: no previous prototype for ‘pl011_init_port’ [-Wmissing-prototypes]
int pl011_init_port (struct console_device *cdev)

     ^~~~~~~~~~~~~~~
---
 drivers/serial/amba-pl011.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/serial/amba-pl011.c +1 -1
index ce40f840f7..9b567e3cd2 100644
@@ -148,7 +148,7 @@ static void pl011_rlcr(struct amba_uart_port *uart, u32 lcr)
 	}
 }
 
-int pl011_init_port (struct console_device *cdev)
+static int pl011_init_port(struct console_device *cdev)
 {
 	struct amba_uart_port *uart = to_amba_uart_port(cdev);
 
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

PATCH 3/3 net: ks8851_mll: fix "no previous prototype for 'ks_enable_qmu'" warning

In reply to Antony Pavlov

The patch fixes the following compiler's warning:

drivers/net/ks8851_mll.c:438:6: warning: no previous prototype for ‘ks_enable_qmu’ [-Wmissing-prototypes]
void ks_enable_qmu(struct ks_net *ks)

      ^~~~~~~~~~~~~
---
 drivers/net/ks8851_mll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ks8851_mll.c +1 -1
index c0608112d5..b037e19633 100644
@@ -435,7 +435,7 @@ static inline void ks_outblk(struct ks_net *ks, u16 *wptr, u32 len)
 		writew(*wptr++, ks->hw_addr);
 }
 
-void ks_enable_qmu(struct ks_net *ks)
+static void ks_enable_qmu(struct ks_net *ks)
 {
 	u16 w;
 
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#4 lore raw
In reply to Antony Pavlov
Quoted 9 lines · Antony Pavlov

Antony Pavlov (3):
w1: fix "no previous prototype for 'w1_found'" warning
serial: amba-pl011: fix "no previous prototype for 'pl011_init_port'" warning
net: ks8851_mll: fix "no previous prototype for 'ks_enable_qmu'" warning

 drivers/net/ks8851_mll.c    | 2 +-
 drivers/serial/amba-pl011.c | 2 +-
 drivers/w1/w1.c             | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox