drm/amdgpu: Add missing power attribute to APU check
Subsystems (2)
PATCH 1/1 drm/amdgpu: Add missing power attribute to APU check
Add missing power_average to visible check for power attributesi for APUs. Was missed before.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +2 -1
@@ -1799,7 +1799,8 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, effective_mode &= ~S_IWUSR ;if ((adev->flags &AMD_IS_APU ) && - (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || + (attr == &sensor_dev_attr_power1_average.dev_attr.attr || + attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr|| attr == &sensor_dev_attr_power1_cap.dev_attr.attr))return 0 ;
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20190110032347.18890-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Ping?
Quoted 24 lines · Alex Deucher
Add missing
power_averageto visible check for power attributesi for APUs. Was missed before.Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +2
-2@@ -1799,7 +1799,8 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, effective_mode &= ~S_IWUSR ;if ((adev->flags &AMD_IS_APU ) && - (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || + (attr == &sensor_dev_attr_power1_average.dev_attr.attr || + attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr|| attr == &sensor_dev_attr_power1_cap.dev_attr.attr))return 0 ; --
Quoted 2 lines
2.20.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_NNmdoYZvAHcKy5Act4PRqGSqH1RPTCXq2SVHJNo2i4Hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Ping again?
Alex
Quoted 20 lines · Alex Deucher
Ping?
Quoted 16 lines · Alex Deucher
Add missing
power_averageto visible check for power attributesi for APUs. Was missed before.Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +0
-0@@ -1799,7 +1799,8 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj, effective_mode &= ~S_IWUSR ;
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +2
-2if ((adev->flags &AMD_IS_APU ) && - (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || + (attr == &sensor_dev_attr_power1_average.dev_attr.attr || + attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr|| attr == &sensor_dev_attr_power1_cap.dev_attr.attr))return 0 ; --2.20.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_Ode61xeHM03azU7LbzD-f38d5Kxadz98tveWm4Q062sw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Quan, Evan
Reviewed-by Evan QuanQuoted 49 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2019年1月22日 3:01
To: amd-gfx list <[email protected]>
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: Add missing power attribute to APU checkPing again?
Alex
Quoted 4 lines · Alex Deucher
Ping?
On Wed, Jan 9, 2019 at 10:23 PM Alex Deucher <[email protected]>
Quoted 9 lines · wrote:
Quoted 9 lines
Add missing
power_averageto visible check for power attributesi for APUs. Was missed before.Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c static umode_t
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +0
-0@@ -1799,7 +1799,8 @@ static umode_thwmon_attributes_visible(struct kobject *kobj,
Quoted 13 lines
Quoted 11 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +3
-2effective_mode &= ~S_IWUSR ;if ((adev->flags &AMD_IS_APU ) && - (attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr || + (attr == &sensor_dev_attr_power1_average.dev_attr.attr || + attr == &sensor_dev_attr_power1_cap_max.dev_attr.attr + || attr == &sensor_dev_attr_power1_cap_min.dev_attr.attr|| attr == &sensor_dev_attr_power1_cap.dev_attr.attr))return 0 ; --Quoted 2 lines
2.20.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx