Skip to contentSkip to conversation

nvme-cli: Fixup compilation with user-defined CFLAGS

PATCH New Hannes Reinecke 1 participant 2 messages Jan 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-cli: Fixup compilation with user-defined CFLAGS

Calling 'make CFLAGS="-Wall"' breaks compilation as the include statement will be overwritten.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
index 525616a..4ea19dd 100644
@@ -1,5 +1,5 @@
-CFLAGS ?= -O2 -g -Wall -Werror -I.
-CFLAGS += -std=gnu99
+CFLAGS ?= -O2 -g -Wall -Werror
+CFLAGS += -I. -std=gnu99
 CPPFLAGS += -D_GNU_SOURCE -D__CHECK_ENDIAN__
 LIBUUID = $(shell $(LD) -o /dev/null -luuid >/dev/null 2>&1; echo $$?)
 NVME = nvme
Signature · 1 line
2.13.7
#1 lore raw

PATCH 1/1 nvme-cli: Fixup compilation with user-defined CFLAGS

Quoted 14 lines · Hannes Reinecke

Calling 'make CFLAGS="-Wall"' breaks compilation as the include statement will be overwritten.

Signed-off-by Hannes Reinecke <hare at suse.com>
---
  Makefile | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +0 -0
index 525616a..4ea19dd 100644

Makefile line 5

Quoted 7 lines
Makefile +2 -2
@@ -1,5 +1,5 @@
-CFLAGS ?= -O2 -g -Wall -Werror -I.
-CFLAGS += -std=gnu99
+CFLAGS ?= -O2 -g -Wall -Werror
+CFLAGS += -I. -std=gnu99
  CPPFLAGS += -D_GNU_SOURCE -D__CHECK_ENDIAN__
  LIBUUID = $(shell $(LD) -o /dev/null -luuid >/dev/null 2>&1; echo $$?)
  NVME = nvme

Please disregard. This patch doesn't fix it :-(

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N?rnberg)