Skip to contentSkip to conversation

spi: dw: fix warning unused variable 'ret'

PATCH In review Anders Roxell 2 participants 2 messages Jan 10, 2019 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: dw: fix warning unused variable 'ret'

When CONFIG_SPI_DESIGNWARE are enabled we see the unused variable warning in dw_spi_setup.

../drivers/spi/spi-dw.c: In function ‘dw_spi_setup’:
../drivers/spi/spi-dw.c:400:6: warning: unused variable ‘ret’ [-Wunused-variable]

  int ret;
      ^~~

Remove the unused varable.

Fixes 9400c41e77b8 ("spi: dw: Convert to use CS GPIO descriptors")
---
 drivers/spi/spi-dw.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-dw.c +0 -1
index f54b498001a9..7092e58add2c 100644
@@ -397,7 +397,6 @@ static int dw_spi_setup(struct spi_device *spi)
 {
 	struct dw_spi_chip *chip_info = NULL;
 	struct chip_data *chip;
-	int ret;
 
 	/* Only alloc on first setup */
 	chip = spi_get_ctldata(spi);
Signature · 1 line
2.19.2
maintainer
#1 lore raw

Applied "spi: dw: fix warning unused variable 'ret'" to the spi tree

The patch

spi: dw: fix warning unused variable 'ret'

has been applied to the spi tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 4f0a0cd52d6c812fbf737e436b18f04eac2e312e Mon Sep 17 00:00:00 2001

From: Anders Roxell <[email protected]>
Date: Thu, 10 Jan 2019 11:14:07 +0100
Subject: [PATCH] spi: dw: fix warning unused variable 'ret'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When CONFIG_SPI_DESIGNWARE are enabled we see the unused variable warning in dw_spi_setup.

../drivers/spi/spi-dw.c: In function ‘dw_spi_setup’:
../drivers/spi/spi-dw.c:400:6: warning: unused variable ‘ret’ [-Wunused-variable]

  int ret;
      ^~~

Remove the unused varable.

Fixes 9400c41e77b8 ("spi: dw: Convert to use CS GPIO descriptors")
---
 drivers/spi/spi-dw.c | 1 -
 1 file changed, 1 deletion(-)
drivers/spi/spi-dw.c +0 -1
index f54b498001a9..7092e58add2c 100644
@@ -397,7 +397,6 @@ static int dw_spi_setup(struct spi_device *spi)
 {
 	struct dw_spi_chip *chip_info = NULL;
 	struct chip_data *chip;
-	int ret;
 
 	/* Only alloc on first setup */
 	chip = spi_get_ctldata(spi);
Signature · 1 line
2.20.1