dma: ixm-dma: fix warning comparison of distinct pointer types
Subsystems (2)
PATCH 1/1 dma: ixm-dma: fix warning comparison of distinct pointer types
The warning got introduced by commit 930507c18304 ("arm64: add basic Kconfig symbols for i.MX8"). Since it got enabled for arm64. The warning haven't been seen before since size_t was 'unsigned int' when built on arm32.
../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^~
../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~
../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~
../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~
../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’
now = min(d->len, sg_dma_len(sg));
^~~Rework so that we use min_t and pass in the size_t that returns the minimum of two values, using the specified type.
--- drivers/dma/imx-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/imx-dma.c +1 -1
@@ -285,7 +285,7 @@ static inline int imxdma_sg_next(struct imxdma_desc *d)struct scatterlist *sg = d->sg;unsigned long now; - now =min (d->len,sg_dma_len (sg)); + now =min_t (size_t, d->len,sg_dma_len (sg));if (d->len !=IMX_DMA_LENGTH_LOOP ) d->len -= now;
Quoted 23 lines · Anders Roxell
The warning got introduced by commit
930507c18304("arm64: add basicKconfigsymbols for i.MX8"). Since it got enabled for arm64. The warning haven't been seen before sincesize_twas 'unsigned int' when built on arm32.
../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))^~ ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’ (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’ __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’ #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’ now = min(d->len, sg_dma_len(sg)); ^~~
Quoted 4 lines
Rework so that we use
min_tand pass in thesize_tthat returns the minimum of two values, using the specified type.Signed-off-by Anders Roxell <[email protected]>
'now' should probably also be a size_t, but it can be done separately. imxdma_sg_next()'s return value is never checked anywhere, so the function can be changed to void as well.
That being said, I think this specific patch should go in now to keep warnings out of our standard builds. The more we keep around, the harder it is to spot when a new legitimate one shows up.
-Olof
Hi Anders,
Quoted 23 lines · Anders Roxell
The warning got introduced by commit
930507c18304("arm64: add basicKconfigsymbols for i.MX8"). Since it got enabled for arm64. The warning haven't been seen before sincesize_twas 'unsigned int' when built on arm32.
../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))^~ ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’ (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’ __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’ #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’ now = min(d->len, sg_dma_len(sg)); ^~~
Quoted 4 lines
Rework so that we use
min_tand pass in thesize_tthat returns the minimum of two values, using the specified type.Signed-off-by Anders Roxell <[email protected]>
There is a typo in the Subject: s/ixm/imx/ and the prefix should be dmaengine instead:
dmaengine: imx-dma: fix warning comparison of distinct pointer types
With that fixed:
Quoted 32 lines · Fabio Estevam
Hi Anders,
Quoted 23 lines · Anders Roxell
The warning got introduced by commit
930507c18304("arm64: add basicKconfigsymbols for i.MX8"). Since it got enabled for arm64. The warning haven't been seen before sincesize_twas 'unsigned int' when built on arm32.
../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))^~ ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’ (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’ __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’ #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’ now = min(d->len, sg_dma_len(sg)); ^~~Quoted 4 lines
Rework so that we use
min_tand pass in thesize_tthat returns the minimum of two values, using the specified type.Signed-off-by Anders Roxell <[email protected]>
Quoted 8 lines
There is a typo in the Subject: s/ixm/imx/ and the prefix should be dmaengine instead:
dmaengine: imx-dma: fix warning comparison of distinct pointer types
With that fixed:
Reviewed-by Fabio Estevam <[email protected]>
OK, thanks Fabio.
Dan, do you want me to resend the patch with an updated shortlog or will you do that when you apply the patch?
Cheers,
Anders
Vinod Koul
maintainerQuoted 38 lines · Anders Roxell
Quoted 37 lines · Fabio Estevam
Hi Anders,
Quoted 23 lines · Anders Roxell
The warning got introduced by commit
930507c18304("arm64: add basicKconfigsymbols for i.MX8"). Since it got enabled for arm64. The warning haven't been seen before sincesize_twas 'unsigned int' when built on arm32.
../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))^~ ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’ (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’ __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’ #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’ now = min(d->len, sg_dma_len(sg)); ^~~Quoted 4 lines
Rework so that we use
min_tand pass in thesize_tthat returns the minimum of two values, using the specified type.Signed-off-by Anders Roxell <[email protected]>There is a typo in the Subject: s/ixm/imx/ and the prefix should be dmaengine instead:
dmaengine: imx-dma: fix warning comparison of distinct pointer types
Quoted 8 lines
Quoted 3 lines
With that fixed:
Reviewed-by Fabio Estevam <[email protected]>OK, thanks Fabio.
Dan, do you want me to resend the patch with an updated shortlog or will you do that when you apply the patch?
applied after fixing subsystem name and driver name