Fix ERROR:do not initialise statics to 0 in af_vsock.c
Subsystems (3)
PATCH 1/1 Fix ERROR:do not initialise statics to 0 in af_vsock.c
Found by scripts/checkpatch.pl
--- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/vmw_vsock/af_vsock.c +1 -1
@@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)static int __vsock_bind_stream (struct vsock_sock *vsk,struct sockaddr_vm *addr) { -static u32 port =0 ; +static u32 port;struct sockaddr_vm new_addr;if (!port)
Signature · 1 line
2.20.1.97.g81188d93c3-goog
Quoted 2 lines · Lepton Wu
Found by
scripts/checkpatch.pl
---
Please include your Signed-off-by.
net/vmw_vsock/af_vsock.c static void vsock_pending_work(struct work_struct *work) · line 508
Quoted 13 lines
net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/vmw_vsock/af_vsock.c +1
-1@@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)static int __vsock_bind_stream (struct vsock_sock *vsk,struct sockaddr_vm *addr) { -static u32 port =0 ; +static u32 port;
Reviewed-by Stefan Hajnoczi <[email protected]>
PATCH v2 1/1 Fix ERROR:do not initialise statics to 0 in af_vsock.c
Found by scripts/checkpatch.pl
Signed-off-by Lepton Wu <[email protected]>
--- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/vmw_vsock/af_vsock.c +1 -1
@@ -505,7 +505,7 @@ static void vsock_pending_work(struct work_struct *work)static int __vsock_bind_stream (struct vsock_sock *vsk,struct sockaddr_vm *addr) { -static u32 port =0 ; +static u32 port;struct sockaddr_vm new_addr;if (!port)
Signature · 1 line
2.20.1.97.g81188d93c3-goog
David Miller
maintainerFrom: Lepton Wu <[email protected]>
Date: Wed, 9 Jan 2019 15:45:41 -0800
Quoted 1 line
Found by
scripts/checkpatch.pl
I applied this and pushed out but didn't catch in time that you didn't provide a properly Signed-off-by: Please do that next time.