Skip to contentSkip to conversation

fs/direct-io.c: include fs/internal.h for sb_init_dio_done_wq()

PATCH RESEND In review Eric Biggers 1 participant 2 messages Jan 10, 2019 – Feb 7, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 fs/direct-io.c: include fs/internal.h for sb_init_dio_done_wq()

From: Eric Biggers <[email protected]>

sb_init_dio_done_wq() is defined in fs/direct-io.c and declared in fs/internal.h, but the declaration isn't included at the point of the definition. Include the header to enforce that the definition matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/direct-io.c | 1 +
 1 file changed, 1 insertion(+)
fs/direct-io.c +1 -0
index dbc1a1f080ceb..42e497e3a39a9 100644
@@ -37,6 +37,7 @@
 #include <linux/uio.h>
 #include <linux/atomic.h>
 #include <linux/prefetch.h>
+#include "internal.h"
 
 /*
  * How many user pages to map in one call to get_user_pages().  This determines
Signature · 1 line
2.20.1.97.g81188d93c3-goog
#1 lore raw
Quoted 29 lines · Eric Biggers

From: Eric Biggers <[email protected]>

sb_init_dio_done_wq() is defined in fs/direct-io.c and declared in fs/internal.h, but the declaration isn't included at the point of the definition. Include the header to enforce that the definition matches the declaration.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

---
 fs/direct-io.c | 1 +
 1 file changed, 1 insertion(+)
fs/direct-io.c +1 -0
index dbc1a1f080ceb..42e497e3a39a9 100644
@@ -37,6 +37,7 @@
 #include <linux/uio.h>
 #include <linux/atomic.h>
 #include <linux/prefetch.h>
+#include "internal.h"
 
 /*
  * How many user pages to map in one call to get_user_pages().  This determines
Signature · 1 line
2.20.1.97.g81188d93c3-goog

Ping. Al, are you planning to apply this?

- Eric