Skip to contentSkip to conversation

drm/amd/display: Remove error message in stream create routine

PATCH In review Jerry (Fangzhi) Zuo 2 participants 3 messages Jan 10, 2019 – Jan 11, 2019 4 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Remove error message in stream create routine

MST has its unique sequence that may get failed due to no stream in atomic check in some cases, e.g., hotplug, S3 resume.

Remove the ERROR message in the stream create routine, and leave its caller to decide if additional action is required.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -3
index 53c49c901a6a..a9ed225d2ae0 100644
@@ -3052,10 +3052,8 @@ create_stream_for_sink(struct amdgpu_dm_connector *aconnector,
 
 	stream = dc_create_stream_for_sink(sink);
 
-	if (stream == NULL) {
-		DRM_ERROR("Failed to create stream for sink!\n");
+	if (stream == NULL)
 		goto finish;
-	}
 
 	stream->dm_stream_context = aconnector;
 
Signature · 6 lines
2.14.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · Jerry (Fangzhi) Zuo

MST has its unique sequence that may get failed due to no stream in atomic check in some cases, e.g., hotplug, S3 resume.

You might want to elaborate more here, e.g. what's the actual reason for MST not having streams in the case of a hotplug or S3 resume? Have they not been created yet, etc. etc.

Quoted 27 lines

Remove the ERROR message in the stream create routine, and leave its caller to decide if additional action is required.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -3
index 53c49c901a6a..a9ed225d2ae0 100644
@@ -3052,10 +3052,8 @@ create_stream_for_sink(struct amdgpu_dm_connector
 *aconnector,
 
 	stream = dc_create_stream_for_sink(sink);
 
-	if (stream == NULL) {
-		DRM_ERROR("Failed to create stream for sink!\n");
+	if (stream == NULL)
 		goto finish;
-	}
 
 	stream->dm_stream_context = aconnector;
Signature · 7 lines
Cheers,
	Lyude Paul

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BYAPR12MB3526B750A65A3DFA58606B16E5840@BYAPR12MB3526.namprd12.prod.outlook.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 47d6f36ace8bf5189ae12a250f70177c6b435563.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

author Reviewed-by Lyude Paul
#6 lore raw

OK. Got you. Thanks.

-----Original Message-----
From: Lyude Paul <[email protected]>
Sent: January 10, 2019 6:07 PM
To: Zuo, Jerry <[email protected]>; Wentland, Harry <[email protected]>
Subject: Re: [PATCH] drm/amd/display: Remove error message in stream create routine

Quoted 7 lines · Jerry

Thanks for your comments. The failure in creating stream for sink could be in the following two cases:

In hotplug scenario, when hotplug back to the same port, first tries to check old connector which gets failed, and then go through the new added connector without issue.

Quoted 8 lines

In S3 topology change, the new sink will not get created in the resume routine that leads to the failure in creating stream. The sink and stream will eventually get created after the resume when triggering hotplug event.

Both sequence seems to be normal in MST processing. For the hotplug, not quite clear why the old connector still needs to check. Seems only new connector needs that. Please correct me if I have misunderstanding on this part.

I don't think the old connector needs a check, that's likely just a sideaffect of the connector not being unreferenced entirely yet by userspace/the kernel- but it should be safe to ignore.

Anyway- if you replace "In S3 topology change" with "When an MST topology connected to a port is replaced with a different topology while the system is suspended", then feel free to add my R-B

Quoted 42 lines

Jerry

-----Original Message-----
From: Lyude Paul <[email protected]>
Sent: January 10, 2019 4:33 PM
To: Zuo, Jerry <[email protected]>; [email protected]; Wentland, Harry <[email protected]>
Subject: Re: [PATCH] drm/amd/display: Remove error message in stream create routine

Quoted 2 lines · Jerry (Fangzhi) Zuo

MST has its unique sequence that may get failed due to no stream in atomic check in some cases, e.g., hotplug, S3 resume.

You might want to elaborate more here, e.g. what's the actual reason for MST not having streams in the case of a hotplug or S3 resume? Have they not been created yet, etc. etc.

Quoted 24 lines

Remove the ERROR message in the stream create routine, and leave its caller to decide if additional action is required.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -3
index 53c49c901a6a..a9ed225d2ae0 100644
@@ -3052,10 +3052,8 @@ create_stream_for_sink(struct 
 amdgpu_dm_connector *aconnector,
 
 	stream = dc_create_stream_for_sink(sink);
 
-	if (stream == NULL) {
-		DRM_ERROR("Failed to create stream for sink!\n");
+	if (stream == NULL)
 		goto finish;
-	}
 
Quoted 6 lines

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c create_stream_for_sink(struct amdgpu_dm_connector *aconnector, · line 3058

Quoted 2 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0 -0
 	stream->dm_stream_context = aconnector;

--
Cheers,
Lyude Paul

--
Cheers,
Lyude Paul

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx