Skip to contentSkip to conversation

Fix typo. Change tlb_range_add to iotlb_range_add and tlb_sync to iotlb_sync

PATCH Applied Tom Murphy 2 participants 4 messages Dec 4, 2018 – Jan 11, 2019 IOMMU

lore
Share & tools
lore

Tom Murphy

author
#0 lore raw

PATCH 1/1 Fix typo. Change tlb_range_add to iotlb_range_add and tlb_sync to iotlb_sync

From: tom <[email protected]>

Someone forgot to update this comment.

---
 include/linux/iommu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/iommu.h +2 -2
index a1d28f42cb77..11db18b9ffe8 100644
@@ -168,8 +168,8 @@ struct iommu_resv_region {
  * @map: map a physically contiguous memory region to an iommu domain
  * @unmap: unmap a physically contiguous memory region from an iommu domain
  * @flush_tlb_all: Synchronously flush all hardware TLBs for this domain
- * @tlb_range_add: Add a given iova range to the flush queue for this domain
- * @tlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
+ * @iotlb_range_add: Add a given iova range to the flush queue for this domain
+ * @iotlb_sync: Flush all queued ranges from the hardware TLBs and empty flush
  *            queue
  * @iova_to_phys: translate iova to physical address
  * @add_device: add device to iommu grouping
Signature · 1 line
2.11.0
author
#2 lore raw

Ah shoot, it looks like I forgot to change flush_tlb_all -> flush_iotlb_all

Should I submit another patch?

Quoted 12 lines · Joerg Roedel
Quoted 8 lines · Tom Murphy

From: tom <[email protected]>

Someone forgot to update this comment.

---
 include/linux/iommu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

maintainer
#3 lore raw
Quoted 3 lines · Tom Murphy

Ah shoot, it looks like I forgot to change flush_tlb_all -> flush_iotlb_all

Should I submit another patch?

Yes, please.