Skip to contentSkip to conversation

webkitgtk: Enable building for ARC architecture

PATCH In review Alexey Brodkin 3 participants 5 messages Jan 11, 2019 – Jan 14, 2019 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkitgtk: Enable building for ARC architecture

For that we need 2 things:
1. Disable JIT in JS as it's not supported for ARC.

2. Compile with "-mlong-calls" so relocations with offsets larger than 25 bits are used, otherwise linker fails to link final binaries.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Alexander Kanavin <alex.kanavin at gmail.com>
Cc Hongxu Jia <hongxu.jia at windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +7 -0
index fc56822f7a..56f69c7a30 100644
@@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \
 EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF "
 EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF "
 
+# Javascript JIT is not supported on ARC
+EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
+# By default 25-bit "medium" calls are used on ARC
+# which is not enough for binaries larger than 32 MiB
+CFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_append_arc = " -mlong-calls"
+
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=OFF "
Signature · 1 line
2.16.2
#1 lore raw

✗ patchtest: failure for webkitgtk: Enable building for ARC architecture

== Series Details ==

Series: webkitgtk: Enable building for ARC architecture
Revision: 1
URL : https://patchwork.openembedded.org/series/15614/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 65c419b8c4)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#2 lore raw

PATCH 1/1 webkitgtk: Enable building for ARC architecture

In reply to Alexey Brodkin
Quoted 20 lines · Alexey Brodkin

For that we need 2 things:
1. Disable JIT in JS as it's not supported for ARC.

2. Compile with "-mlong-calls" so relocations with offsets larger than 25 bits are used, otherwise linker fails to link final binaries.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Alexander Kanavin <alex.kanavin at gmail.com>
Cc Hongxu Jia <hongxu.jia at windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +0 -0
index fc56822f7a..56f69c7a30 100644

meta/recipes-sato/webkit/webkitgtk_2.22.5.bb EXTRA_OECMAKE = " \ · line 77

Quoted 9 lines
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +6 -0
@@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \
 EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF "
 EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF "
 
+# Javascript JIT is not supported on ARC
+EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
+# By default 25-bit "medium" calls are used on ARC
+# which is not enough for binaries larger than 32 MiB
+CFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_append_arc = " -mlong-calls"

perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases

Quoted 7 lines
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +1 -1
+
 # Javascript JIT is not supported on powerpc
 EXTRA_OECMAKE_append_powerpc = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_powerpc64 = " -DENABLE_JIT=OFF "
--

2.16.2

#3 lore raw

PATCH 1/1 webkitgtk: Enable building for ARC architecture

Hi Khem,

Quoted 36 lines

-----Original Message-----
From: Khem Raj [mailto:raj.khem at gmail.com]
Sent: Friday, January 11, 2019 6:32 PM
To: Alexey Brodkin <alexey.brodkin at synopsys.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core at lists.openembedded.org>; Richard Purdie <richard.purdie at linuxfoundation.org>; Ross Burton <ross.burton at intel.com>; linux-snps- arc at lists.infradead.org; Alexander Kanavin <alex.kanavin at gmail.com>; Hongxu Jia <hongxu.jia at windriver.com>
Subject: Re: [PATCH] webkitgtk: Enable building for ARC architecture

meta/recipes-

Quoted 16 lines · Alexey Brodkin

For that we need 2 things:
1. Disable JIT in JS as it's not supported for ARC.

2. Compile with "-mlong-calls" so relocations with offsets larger than 25 bits are used, otherwise linker fails to link final binaries.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Alexander Kanavin <alex.kanavin at gmail.com>
Cc Hongxu Jia <hongxu.jia at windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +0 -0

sato/webkit/webkitgtk_2.22.5.bb

Quoted 7 lines

index fc56822f7a..56f69c7a30 100644

meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +0 -0
@@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \
 EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF "
 EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF "
 
Quoted 8 lines

meta/recipes-sato/webkit/webkitgtk_2.22.5.bb EXTRA_OECMAKE = " \ · line 77

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +6 -0
+# Javascript JIT is not supported on ARC
+EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
+# By default 25-bit "medium" calls are used on ARC
+# which is not enough for binaries larger than 32 MiB
+CFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_append_arc = " -mlong-calls"

perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases

Just tried that (only CPPFLAGS_append_arc = " -mlong-calls") and
I don't see "-mlong-calls" used during compilation at all
(I'm looking at .../oe/build/tmp-glibc/work/archs-oe-linux/webkitgtk/2.22.5-r0/temp/log.do_compile).

So I may guess webkitgtk doesn't copy CPPFLAGS to CFLAGS and CXXFLAGS.

-Alexey

#4 lore raw

PATCH 1/1 webkitgtk: Enable building for ARC architecture

Quoted 48 lines · Alexey Brodkin

Hi Khem,

Quoted 36 lines

-----Original Message-----
From: Khem Raj [mailto:raj.khem at gmail.com]
Sent: Friday, January 11, 2019 6:32 PM
To: Alexey Brodkin <alexey.brodkin at synopsys.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core at lists.openembedded.org>; Richard Purdie <richard.purdie at linuxfoundation.org>; Ross Burton <ross.burton at intel.com>; linux-snps- arc at lists.infradead.org; Alexander Kanavin <alex.kanavin at gmail.com>; Hongxu Jia <hongxu.jia at windriver.com>
Subject: Re: [PATCH] webkitgtk: Enable building for ARC architecture

meta/recipes-

Quoted 16 lines · Alexey Brodkin

For that we need 2 things:
1. Disable JIT in JS as it's not supported for ARC.

2. Compile with "-mlong-calls" so relocations with offsets larger than 25 bits are used, otherwise linker fails to link final binaries.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
Cc Alexander Kanavin <alex.kanavin at gmail.com>
Cc Hongxu Jia <hongxu.jia at windriver.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.22.5.bb | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes- renamed from meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +0 -0

sato/webkit/webkitgtk_2.22.5.bb

Quoted 7 lines

index fc56822f7a..56f69c7a30 100644

meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +0 -0
@@ -69,6 +69,13 @@ EXTRA_OECMAKE = " \
 EXTRA_OECMAKE_append_x86 = " -DUSE_GSTREAMER_GL=OFF "
 EXTRA_OECMAKE_append_x86-x32 = " -DUSE_GSTREAMER_GL=OFF "
 
Quoted 8 lines

meta/recipes-sato/webkit/webkitgtk_2.22.5.bb EXTRA_OECMAKE = " \ · line 77

Quoted 6 lines
meta/recipes-sato/webkit/webkitgtk_2.22.5.bb +6 -0
+# Javascript JIT is not supported on ARC
+EXTRA_OECMAKE_append_arc = " -DENABLE_JIT=OFF "
+# By default 25-bit "medium" calls are used on ARC
+# which is not enough for binaries larger than 32 MiB
+CFLAGS_append_arc = " -mlong-calls"
+CXXFLAGS_append_arc = " -mlong-calls"

perhaps adding to CPPFLAGS is going to be enough for both c/c++ cases

Quoted 6 lines

Just tried that (only CPPFLAGS_append_arc = " -mlong-calls") and
I don't see "-mlong-calls" used during compilation at all
(I'm looking at .../oe/build/tmp-glibc/work/archs-oe-linux/webkitgtk/2.22.5-r0/temp/log.do_compile).

So I may guess webkitgtk doesn't copy CPPFLAGS to CFLAGS and CXXFLAGS.

yes its possible. Thanks for additional verifications

Quoted 1 line

-Alexey