drm/cirrus: fix connector leak at unload
Subsystems (3)
PATCH 1/1 drm/cirrus: fix connector leak at unload
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
---
Similar case to the issue that was fixed recently in drm/ast
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/cirrus/cirrus_fbdev.c +2 -0
@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, {struct drm_framebuffer *gfb = gfbdev->gfb; +drm_crtc_force_disable_all (dev); +drm_fb_helper_unregister_fbi (&gfbdev->helper);vfree (gfbdev->sysram);
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/ast
Quoted 24 lines
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/cirrus/cirrus_fbdev.c +2
-0@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, {struct drm_framebuffer *gfb = gfbdev->gfb; +drm_crtc_force_disable_all (dev); +drm_fb_helper_unregister_fbi (&gfbdev->helper);vfree (gfbdev->sysram);Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/ast
Quoted 24 lines
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/cirrus/cirrus_fbdev.c +2
-0@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, {struct drm_framebuffer *gfb = gfbdev->gfb; +drm_crtc_force_disable_all (dev); +drm_fb_helper_unregister_fbi (&gfbdev->helper);vfree (gfbdev->sysram);Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 8 lines · Daniel Vetter
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/astReviewed-by Daniel Vetter <[email protected]>
Actually I just pushed a patch to drm-misc-next to rename this function to drm_helper_force_disable_all(), so you need to respin ... My r-b still holds.
-Daniel
Quoted 30 lines
Quoted 25 lines
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/cirrus/cirrus_fbdev.c +2
-0@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, {struct drm_framebuffer *gfb = gfbdev->gfb; +drm_crtc_force_disable_all (dev); +drm_fb_helper_unregister_fbi (&gfbdev->helper);vfree (gfbdev->sysram);Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 8 lines · Daniel Vetter
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/astReviewed-by Daniel Vetter <[email protected]>
Actually I just pushed a patch to drm-misc-next to rename this function to drm_helper_force_disable_all(), so you need to respin ... My r-b still holds.
-Daniel
Quoted 30 lines
Quoted 25 lines
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/cirrus/cirrus_fbdev.c +2
-0@@ -256,6 +256,8 @@ static int cirrus_fbdev_destroy(struct drm_device *dev, {struct drm_framebuffer *gfb = gfbdev->gfb; +drm_crtc_force_disable_all (dev); +drm_fb_helper_unregister_fbi (&gfbdev->helper);vfree (gfbdev->sysram);Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 8 lines · Daniel Vetter
Quoted 7 lines · Daniel Vetter
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/ast
Quoted 5 lines
Quoted 1 line
Reviewed-by Daniel Vetter <[email protected]>Actually I just pushed a patch to drm-misc-next to rename this function to
drm_helper_force_disable_all(), so you need to respin ... My r-b still holds.
Fixed and queued up.
thanks,
Gerd
Quoted 8 lines · Daniel Vetter
Quoted 7 lines · Daniel Vetter
Quoted 5 lines · Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload.
Signed-off-by Rob Clark <[email protected]>---
Similar case to the issue that was fixed recently in drm/ast
Quoted 5 lines
Quoted 1 line
Reviewed-by Daniel Vetter <[email protected]>Actually I just pushed a patch to drm-misc-next to rename this function to
drm_helper_force_disable_all(), so you need to respin ... My r-b still holds.
Fixed and queued up.
thanks,
Gerd
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel