Skip to contentSkip to conversation

scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

PATCH Applied Evan Green 3 participants 5 messages Jan 11, 2019 – Jan 14, 2019

Subsystems (2)
lore
Share & tools
lore

Evan Green

author
#0 lore raw

PATCH 1/1 scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the build.

---

 drivers/scsi/ufs/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/ufs/Kconfig +0 -1
index 2ddbb26d9c265..6db37cf306b05 100644
@@ -99,7 +99,6 @@ config SCSI_UFS_DWC_TC_PLATFORM
 config SCSI_UFS_QCOM
 	tristate "QCOM specific hooks to UFS controller platform driver"
 	depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
-	select PHY_QCOM_UFS
 	help
 	  This selects the QCOM specific additions to UFSHCD platform driver.
 	  UFS host on QCOM needs some vendor specific configuration before
Signature · 1 line
2.18.1
#1 lore raw

Evan,

Quoted 7 lines

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the build.

Applied to 5.1/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw

Hi,

Quoted 9 lines · Martin K. Petersen

Evan,

Quoted 5 lines

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused.

Quoted 4 lines
Quoted 2 lines

Remove the select, since for SDM845 it adds useless drivers to the build.

Applied to 5.1/scsi-queue.

Should this be accompanied by a change to arch/arm64/configs/defconfig that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any non-SDM845 devices to test on, but I'm sorta assuming they will all break without the defconfig update?

Added a few more people (and linux-arm-msm list) to this thread in case this matters to anyone.

-Doug

author
#3 lore raw
Quoted 17 lines · Doug Anderson

Hi,

Quoted 12 lines · Martin K. Petersen

Evan,

Quoted 7 lines

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the build.

Quoted 6 lines
Quoted 1 line

Applied to 5.1/scsi-queue.

Should this be accompanied by a change to arch/arm64/configs/defconfig that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any non-SDM845 devices to test on, but I'm sorta assuming they will all break without the defconfig update?

Right, thanks for pointing that out. I'll send out another patch to tweak the defconfig.
-Evan

author
#4 lore raw
Quoted 21 lines · Evan Green
Quoted 19 lines · Doug Anderson

Hi,

Quoted 13 lines · Martin K. Petersen

Evan,

Quoted 7 lines

CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that this was the only possible PHY driver Qualcomm's UFS controller would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, and phy-qcom-ufs is unused.

Remove the select, since for SDM845 it adds useless drivers to the build.

Applied to 5.1/scsi-queue.

Quoted 7 lines
Quoted 4 lines

Should this be accompanied by a change to arch/arm64/configs/defconfig that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any non-SDM845 devices to test on, but I'm sorta assuming they will all break without the defconfig update?

Right, thanks for pointing that out. I'll send out another patch to tweak the defconfig.

Sent out at:
https://lore.kernel.org/lkml/[email protected]/T/#u