Skip to contentSkip to conversation

pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

PATCH New Arnout Vandecappelle (Essensium/Mind) 4 participants 9 messages Jan 10, 2019 – Jan 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

Quoting the CMake documentation:

When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross compiling then the value of CMAKE_SYSTEM_VERSION must also be set explicitly to specify the target system version.

Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It is supposed to be set to the value of uname -r on the target. We don't have that exact value available (unless we build the kernel), but the value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on, so it should be OK for all practical purposes.

---
 package/pkg-cmake.mk                | 1 +
 support/misc/toolchainfile.cmake.in | 1 +
 2 files changed, 2 insertions(+)
package/pkg-cmake.mk +1 -0
index 51a1929ebb..dd048b0949 100644
@@ -264,6 +264,7 @@ define TOOLCHAIN_CMAKE_INSTALL_FILES
 		-e 's#@@TARGET_CC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CC)))#' \
 		-e 's#@@TARGET_CXX@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CXX)))#' \
 		-e 's#@@TARGET_FC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_FC)))#' \
+		-e 's#@@CMAKE_SYSTEM_VERSION@@#$(call qstrip,$(BR2_TOOLCHAIN_HEADERS_AT_LEAST))#' \
 		-e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \
 		-e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \
 		-e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_DEBUG),Debug,Release)#' \
support/misc/toolchainfile.cmake.in +1 -0
index 6f3c8ca971..276b36629f 100644
@@ -15,6 +15,7 @@ string(REPLACE "/share/buildroot" "" RELOCATED_HOST_DIR ${CMAKE_CURRENT_LIST_DIR
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
 
 set(CMAKE_SYSTEM_NAME Buildroot)
+set(CMAKE_SYSTEM_VERSION @@CMAKE_SYSTEM_VERSION@@)
 set(CMAKE_SYSTEM_PROCESSOR @@CMAKE_SYSTEM_PROCESSOR@@)
 
 # Set the {C,CXX}FLAGS appended by CMake depending on the build type
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 azure-iot-sdk-c: remove dummy value of CMAKE_SYSTEM_VERSION

Now CMAKE_SYSTEM_VERSION is properly set in toolchainfile.cmake, it is no longer necessary to set a dummy value in azure-iot-sdk-c.

---
 package/azure-iot-sdk-c/azure-iot-sdk-c.mk | 5 -----
 1 file changed, 5 deletions(-)
package/azure-iot-sdk-c/azure-iot-sdk-c.mk +0 -5
index 3618e591a9..8b3f670399 100644
@@ -14,11 +14,6 @@ AZURE_IOT_SDK_C_INSTALL_STAGING = YES
 AZURE_IOT_SDK_C_DEPENDENCIES = libxml2 openssl libcurl util-linux
 AZURE_IOT_SDK_C_CONF_OPTS = -Dskip_samples=ON
 
-# When cross-compiling, CMake doesn't internally pass any
-# CMAKE_SYSTEM_VERSION, so pass a dummy version to make the c-utility
-# WIN32 test happy.
-AZURE_IOT_SDK_C_CONF_OPTS += -DCMAKE_SYSTEM_VERSION=1.0
-
 # The project only supports building one kind of library.
 # Further the install target installs the wrong files, so we do it here:
 ifeq ($(BR2_STATIC_LIBS),y)
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

In reply to Arnout Vandecappelle (Essensium/Mind)

Arnout, All,

On 2019-01-11 00:05 +0100, Arnout Vandecappelle (Essensium/Mind) spake thusly:

Quoted 6 lines

Quoting the CMake documentation:

When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross compiling then the value of CMAKE_SYSTEM_VERSION must also be set explicitly to specify the target system version.

Quoted 7 lines

Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It is supposed to be set to the value of uname -r on the target. We don't have that exact value available (unless we build the kernel), but

the
value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on,

That is not true.

glibc for example will by default carry fallback mechanisms to emulate some features when it is running on a kernel older than the headers it was compiled against. In Buildroot we explictly disable that feature by passing --enable-kernel=$(BR2_TOOLCHAIN_HEADERS_AT_LEAST).

But for external toolchains, we don't know (and can't know) iw they did pass that option or not, and if they did, what version they requested, and if they did not, what version glibc uses.

This backward compatibility of glibc can extend quite a bit in the past, so kernels we would consider pretty old might still be usable with such toolchains. For example, on glibc-2.24, the minimum required headers were 3.2, but the runtime could be 2.6.32 on x86_64.

So, we could very well end up building a Buildroot system that runs on a kernel older than the headers of the toolchain.

Regards,
Yann E. MORIN.

Quoted 41 lines

so it should be OK for all practical
purposes.

---
 package/pkg-cmake.mk                | 1 +
 support/misc/toolchainfile.cmake.in | 1 +
 2 files changed, 2 insertions(+)
package/pkg-cmake.mk +1 -0
index 51a1929ebb..dd048b0949 100644
@@ -264,6 +264,7 @@ define TOOLCHAIN_CMAKE_INSTALL_FILES
 		-e 's#@@TARGET_CC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CC)))#' \
 		-e 's#@@TARGET_CXX@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_CXX)))#' \
 		-e 's#@@TARGET_FC@@#$(subst $(HOST_DIR)/,,$(call qstrip,$(TARGET_FC)))#' \
+		-e 's#@@CMAKE_SYSTEM_VERSION@@#$(call qstrip,$(BR2_TOOLCHAIN_HEADERS_AT_LEAST))#' \
 		-e 's#@@CMAKE_SYSTEM_PROCESSOR@@#$(call qstrip,$(CMAKE_SYSTEM_PROCESSOR))#' \
 		-e 's#@@TOOLCHAIN_HAS_FORTRAN@@#$(if $(BR2_TOOLCHAIN_HAS_FORTRAN),1,0)#' \
 		-e 's#@@CMAKE_BUILD_TYPE@@#$(if $(BR2_ENABLE_DEBUG),Debug,Release)#' \
support/misc/toolchainfile.cmake.in +1 -0
index 6f3c8ca971..276b36629f 100644
@@ -15,6 +15,7 @@ string(REPLACE "/share/buildroot" "" RELOCATED_HOST_DIR ${CMAKE_CURRENT_LIST_DIR
 list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
 
 set(CMAKE_SYSTEM_NAME Buildroot)
+set(CMAKE_SYSTEM_VERSION @@CMAKE_SYSTEM_VERSION@@)
 set(CMAKE_SYSTEM_PROCESSOR @@CMAKE_SYSTEM_PROCESSOR@@)
 
 # Set the {C,CXX}FLAGS appended by CMake depending on the build type
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

Hello,

Quoted 15 lines · Yann E. MORIN
Quoted 3 lines

the
value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on,

That is not true.

glibc for example will by default carry fallback mechanisms to emulate some features when it is running on a kernel older than the headers it was compiled against. In Buildroot we explictly disable that feature by passing --enable-kernel=$(BR2_TOOLCHAIN_HEADERS_AT_LEAST).

But for external toolchains, we don't know (and can't know) iw they did pass that option or not, and if they did, what version they requested, and if they did not, what version glibc uses.

Quoted 7 lines

This backward compatibility of glibc can extend quite a bit in the past, so kernels we would consider pretty old might still be usable with such toolchains. For example, on glibc-2.24, the minimum required headers were 3.2, but the runtime could be 2.6.32 on x86_64.

So, we could very well end up building a Buildroot system that runs on a kernel older than the headers of the toolchain.

While this is true, what can we do in practice ? We have no way to know what will be the version of the kernel running on the target when we're not building it, and still we have to provide this CMAKE_SYSTEM_VERSION value. I am not really sure what packages are doing with CMAKE_SYSTEM_VERSION. For example, azure-iot-sdk was simply testing whether it was empty or not.

So for the time being, it seems like using the kernel headers version is a good enough solution, even if not perfect.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

Thomas, Arnout, All,

On 2019-01-12 16:06 +0100, Thomas Petazzoni spake thusly:

Quoted 32 lines · Yann E. MORIN
Quoted 16 lines
Quoted 4 lines

the
value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on,

That is not true.

glibc for example will by default carry fallback mechanisms to emulate some features when it is running on a kernel older than the headers it was compiled against. In Buildroot we explictly disable that feature by passing --enable-kernel=$(BR2_TOOLCHAIN_HEADERS_AT_LEAST).

But for external toolchains, we don't know (and can't know) iw they did pass that option or not, and if they did, what version they requested, and if they did not, what version glibc uses.

Quoted 7 lines

This backward compatibility of glibc can extend quite a bit in the past, so kernels we would consider pretty old might still be usable with such toolchains. For example, on glibc-2.24, the minimum required headers were 3.2, but the runtime could be 2.6.32 on x86_64.

So, we could very well end up building a Buildroot system that runs on a kernel older than the headers of the toolchain.

While this is true, what can we do in practice ? We have no way to know what will be the version of the kernel running on the target when we're not building it, and still we have to provide this CMAKE_SYSTEM_VERSION value. I am not really sure what packages are doing with CMAKE_SYSTEM_VERSION. For example, azure-iot-sdk was simply testing whether it was empty or not.

Quoted 2 lines

So for the time being, it seems like using the kernel headers version is a good enough solution, even if not perfect.

Well, random lookups on the internet for CMAKE_SYSTEM_VERSION mostly tuen up windows- or mac-related questions, so irrelevant to us. The only seemingly-relevant ones are dealing with android.

There are various pieces of crap here and there that just set the thing to 1., or some variants of 1, like 1.0 or 1.0.0.

Even the official cmake wiki [0] states:

CMAKE_SYSTEM_VERSION : optional, version of your target system, not used very much.

[...]

* CMAKE_TOOLCHAIN_FILE : absolute or relative path to a cmake script which sets up all the toolchain related variables mentioned above

For instance for crosscompiling from Linux to Embedded Linux on PowerPC this file could look like this:

# this one is important
SET(CMAKE_SYSTEM_NAME Linux)
#this one not so much
SET(CMAKE_SYSTEM_VERSION 1)
[...]

So my opinion would be that we do exactly what is done in the wiki: set it to 1 (and add a pointer to the wiki) and be done with it.

Then, if/when there are issues we can re-assess the situation.

[0] https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/CrossCompiling

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

Hello,

Quoted 20 lines · Yann E. MORIN

Well, random lookups on the internet for CMAKE_SYSTEM_VERSION mostly tuen up windows- or mac-related questions, so irrelevant to us. The only seemingly-relevant ones are dealing with android.

There are various pieces of crap here and there that just set the thing to 1., or some variants of 1, like 1.0 or 1.0.0.

Even the official cmake wiki [0] states:

CMAKE_SYSTEM_VERSION : optional, version of your target system, not used very much.

[...]

* CMAKE_TOOLCHAIN_FILE : absolute or relative path to a cmake script which sets up all the toolchain related variables mentioned above

For instance for crosscompiling from Linux to Embedded Linux on PowerPC this file could look like this:

Quoted 8 lines

# this one is important
SET(CMAKE_SYSTEM_NAME Linux)
#this one not so much
SET(CMAKE_SYSTEM_VERSION 1)
[...]

So my opinion would be that we do exactly what is done in the wiki: set it to 1 (and add a pointer to the wiki) and be done with it.

That would be fine for me as well. If Arnout agrees, I'll happily take a patch changing to just "1".

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

In reply to Arnout Vandecappelle (Essensium/Mind)

Hello,

Quoted 13 lines · Arnout Vandecappelle (Essensium/Mind)

Quoting the CMake documentation:

When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross compiling then the value of CMAKE_SYSTEM_VERSION must also be set explicitly to specify the target system version.

Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It is supposed to be set to the value of uname -r on the target. We don't have that exact value available (unless we build the kernel), but the value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on, so it should be OK for all practical purposes.

Quoted 6 lines
---
 package/pkg-cmake.mk                | 1 +
 support/misc/toolchainfile.cmake.in | 1 +
 2 files changed, 2 insertions(+)

Both applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

Thomas, All,

On 2019-01-12 16:07 +0100, Thomas Petazzoni spake thusly:

Quoted 15 lines
Quoted 13 lines · Arnout Vandecappelle (Essensium/Mind)

Quoting the CMake documentation:

When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross compiling then the value of CMAKE_SYSTEM_VERSION must also be set explicitly to specify the target system version.

Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It is supposed to be set to the value of uname -r on the target. We don't have that exact value available (unless we build the kernel), but the value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on, so it should be OK for all practical purposes.

Quoted 8 lines
Quoted 6 lines
---
 package/pkg-cmake.mk                | 1 +
 support/misc/toolchainfile.cmake.in | 1 +
 2 files changed, 2 insertions(+)

Both applied, thanks!

Well, you did not give me the opportunity to reply to your question about the first patch...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#8 lore raw

PATCH 1/2 pkg-cmake: add CMAKE_SYSTEM_VERSION to toolchainfile.cmake

In reply to Thomas Petazzoni
Quoted 24 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 19 lines · Arnout Vandecappelle (Essensium/Mind)

Quoting the CMake documentation:

When the CMAKE_SYSTEM_NAME variable is set explicitly to enable cross compiling then the value of CMAKE_SYSTEM_VERSION must also be set explicitly to specify the target system version.

Thus, we should also set CMAKE_SYSTEM_VERSION in toolchainfile.cmake. It is supposed to be set to the value of uname -r on the target. We don't have that exact value available (unless we build the kernel), but the value of BR2_TOOLCHAIN_HEADERS_AT_LEAST contains the (minimum) version of the kernel it will run on, so it should be OK for all practical purposes.

---
package/pkg-cmake.mk | 1 +
support/misc/toolchainfile.cmake.in | 1 +

2 files changed, 2 insertions(+)

Committed to 2018.02.x and 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard