Skip to contentSkip to conversation

syslog-ng: depend on !BR2_STATIC_LIBS

PATCH New Chris Packham 3 participants 3 messages Jan 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 syslog-ng: depend on !BR2_STATIC_LIBS

Upstream now unconditionally requires dlfcn.h:
- https://github.com/balabit/syslog-ng/commit/01258e56abc5804f8ea977ff9ab98cc8e2fd4702

Fixes:
- http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333

---
Changes in v2:
- update comment when toolchain prerequisites are not met (thanks Baruch)

 package/syslog-ng/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/syslog-ng/Config.in +4 -2
index fbc236221a..6407645974 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_SYSLOG_NG
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_STATIC_LIBS # dlfcn.h
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_EVENTLOG
 	select BR2_PACKAGE_LIBGLIB2
@@ -15,7 +16,8 @@ config BR2_PACKAGE_SYSLOG_NG
 
 	  https://syslog-ng.org/
 
-comment "syslog-ng needs a toolchain w/ wchar, threads"
+comment "syslog-ng needs a toolchain w/ dynamic library, wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 syslog-ng: depend on !BR2_STATIC_LIBS

Quoted 46 lines

From: "Chris Packham" <[email protected]>
To: "buildroot" <[email protected]>
Cc: "Carlos Santos" <[email protected]>, "Chris Packham" <[email protected]>
Sent: Domingo, 13 de janeiro de 2019 6:47:22
Subject: [PATCH v2] syslog-ng: depend on !BR2_STATIC_LIBS

Upstream now unconditionally requires dlfcn.h:
-
https://github.com/balabit/syslog-ng/commit/01258e56abc5804f8ea977ff9ab98cc8e2fd4702

Fixes:
-
http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333

---
Changes in v2:
- update comment when toolchain prerequisites are not met (thanks Baruch)

package/syslog-ng/Config.in | 6 ++++--

1 file changed, 4 insertions(+), 2 deletions(-)
package/syslog-ng/Config.in +4 -3
index fbc236221a..6407645974 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_SYSLOG_NG
 	depends on BR2_USE_WCHAR # glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on !BR2_STATIC_LIBS # dlfcn.h
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_EVENTLOG
 	select BR2_PACKAGE_LIBGLIB2
@@ -15,7 +16,8 @@ config BR2_PACKAGE_SYSLOG_NG
 
 	  https://syslog-ng.org/
 
-comment "syslog-ng needs a toolchain w/ wchar, threads"
+comment "syslog-ng needs a toolchain w/ dynamic library, wchar, threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_STATIC_LIBS
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
--
Quoted 1 line

2.20.1

Signature · 1 line
Carlos Santos (Casantos) - DATACOM, P&D
#2 lore raw

PATCH v2 1/1 syslog-ng: depend on !BR2_STATIC_LIBS

In reply to Chris Packham

Hello,

Quoted 10 lines · Chris Packham

Upstream now unconditionally requires dlfcn.h:
- https://github.com/balabit/syslog-ng/commit/01258e56abc5804f8ea977ff9ab98cc8e2fd4702

Fixes:
- http://autobuild.buildroot.net/results/c0bca852e053cd0e021205b3a949e750ae602333

---
Changes in v2:
- update comment when toolchain prerequisites are not met (thanks Baruch)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com