Skip to contentSkip to conversation

drm/amd/display: Include names of all PP clock types

PATCH Applied Rafał Miłecki 2 participants 2 messages Jan 13, 2019 – Jan 14, 2019 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Include names of all PP clock types

From: Rafał Miłecki <[email protected]>

This fixes printing clock names in cases like:

[    5.352311] [drm] DM_PPLIB: values for Invalid clock
[    5.352313] [drm] DM_PPLIB:   400000 in kHz
[    5.352313] [drm] DM_PPLIB:   933000 in kHz
[    5.352314] [drm] DM_PPLIB:   1067000 in kHz
[    5.352315] [drm] DM_PPLIB:   1200000 in kHz
[    5.352317] [drm] DM_PPLIB: values for Invalid clock
[    5.352318] [drm] DM_PPLIB:   300000 in kHz
[    5.352318] [drm] DM_PPLIB:   600000 in kHz
[    5.352319] [drm] DM_PPLIB:   626000 in kHz
[    5.352320] [drm] DM_PPLIB:   654000 in kHz

(source: HP EliteBook 745 G5 w. RAVEN 0x1002:0x15DD 0x103C:0x83D5 0xD1)

On my system above "Invalid" names got replaced by "F" and "DCF".

The same problem was occurring on Huawei Matebook D with just 667000 kHz instead of 400000 kHz.

---
 drivers/gpu/drm/amd/display/dc/dm_services_types.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dm_services_types.h +9 -1
index 1af8c777b3ac..9afd36a031a9 100644
@@ -82,7 +82,15 @@ enum dm_pp_clock_type {
 #define DC_DECODE_PP_CLOCK_TYPE(clk_type) \
 	(clk_type) == DM_PP_CLOCK_TYPE_DISPLAY_CLK ? "Display" : \
 	(clk_type) == DM_PP_CLOCK_TYPE_ENGINE_CLK ? "Engine" : \
-	(clk_type) == DM_PP_CLOCK_TYPE_MEMORY_CLK ? "Memory" : "Invalid"
+	(clk_type) == DM_PP_CLOCK_TYPE_MEMORY_CLK ? "Memory" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_DCFCLK ? "DCF" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_DCEFCLK ? "DCEF" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_SOCCLK ? "SoC" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_PIXELCLK ? "Pixel" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_DISPLAYPHYCLK ? "Display PHY" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_DPPCLK ? "DPP" : \
+	(clk_type) == DM_PP_CLOCK_TYPE_FCLK ? "F" : \
+	"Invalid"
 
 #define DM_PP_MAX_CLOCK_LEVELS 8
 
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190113132407.13169-1-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Applied
#2 lore raw
Quoted 14 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This fixes printing clock names in cases like:

[    5.352311] [drm] DM_PPLIB: values for Invalid clock
[    5.352313] [drm] DM_PPLIB:   400000 in kHz
[    5.352313] [drm] DM_PPLIB:   933000 in kHz
[    5.352314] [drm] DM_PPLIB:   1067000 in kHz
[    5.352315] [drm] DM_PPLIB:   1200000 in kHz
[    5.352317] [drm] DM_PPLIB: values for Invalid clock
[    5.352318] [drm] DM_PPLIB:   300000 in kHz
[    5.352318] [drm] DM_PPLIB:   600000 in kHz
[    5.352319] [drm] DM_PPLIB:   626000 in kHz
[    5.352320] [drm] DM_PPLIB:   654000 in kHz
Quoted 8 lines

(source: HP EliteBook 745 G5 w. RAVEN 0x1002:0x15DD 0x103C:0x83D5 0xD1)

On my system above "Invalid" names got replaced by "F" and "DCF".

The same problem was occurring on Huawei Matebook D with just 667000 kHz instead of 400000 kHz.

Applied. thanks!

Alex

Quoted 26 lines
---
 drivers/gpu/drm/amd/display/dc/dm_services_types.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dm_services_types.h +9 -2
index 1af8c777b3ac..9afd36a031a9 100644
@@ -82,7 +82,15 @@ enum dm_pp_clock_type {
 #define DC_DECODE_PP_CLOCK_TYPE(clk_type) \
        (clk_type) == DM_PP_CLOCK_TYPE_DISPLAY_CLK ? "Display" : \
        (clk_type) == DM_PP_CLOCK_TYPE_ENGINE_CLK ? "Engine" : \
-       (clk_type) == DM_PP_CLOCK_TYPE_MEMORY_CLK ? "Memory" : "Invalid"
+       (clk_type) == DM_PP_CLOCK_TYPE_MEMORY_CLK ? "Memory" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_DCFCLK ? "DCF" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_DCEFCLK ? "DCEF" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_SOCCLK ? "SoC" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_PIXELCLK ? "Pixel" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_DISPLAYPHYCLK ? "Display PHY" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_DPPCLK ? "DPP" : \
+       (clk_type) == DM_PP_CLOCK_TYPE_FCLK ? "F" : \
+       "Invalid"
 
 #define DM_PP_MAX_CLOCK_LEVELS 8
 
--
Quoted 2 lines

2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx