Skip to contentSkip to conversation

ARM: bcm283x: Fix definition of MBOX_TAG_TEST_PIXEL_ORDER

PATCH New Alexander Graf 1 participant 1 message Jan 13, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: bcm283x: Fix definition of MBOX_TAG_TEST_PIXEL_ORDER

From: Berkus Decker <[email protected]>

The MBOX_TAG_TEST_PIXEL_ORDER define is incorrect. According to official documentation it has a slightly different numbering.

Correct mailbox constants are defined in e.g.
linux raspberry-firmware https://code.woboq.org/linux/linux/include/soc/bcm2835/raspberrypi-firmware.h.html#RPI_FIRMWARE_FRAMEBUFFER_TEST_PIXEL_ORDER

These are obtained from the bcm2835 documentation
e.g. https://github.com/raspberrypi/firmware/wiki/Mailbox-property-interface#test-pixel-order

Fix the define to get us back in sync with the spec.

[agraf: clarify subject, extend commit message]
---
 arch/arm/mach-bcm283x/include/mach/mbox.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-bcm283x/include/mach/mbox.h +1 -1
index 2776a396c7..e3a893e49c 100644
@@ -348,7 +348,7 @@ struct bcm2835_mbox_tag_depth {
 };
 
 #define BCM2835_MBOX_TAG_GET_PIXEL_ORDER	0x00040006
-#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER	0x00044005
+#define BCM2835_MBOX_TAG_TEST_PIXEL_ORDER	0x00044006
 #define BCM2835_MBOX_TAG_SET_PIXEL_ORDER	0x00048006
 
 #define BCM2835_MBOX_PIXEL_ORDER_BGR		0
Signature · 1 line
2.12.3