drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
Subsystems (3)
PATCH 1/1 drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
The etnaviv_gem_get_pages() never returns NULL. It returns error pointers on error.
Fixes a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/etnaviv/etnaviv_dump.c +1 -1
@@ -215,7 +215,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu)mutex_lock (&obj->lock); pages =etnaviv_gem_get_pages (obj);mutex_unlock (&obj->lock); -if (pages) { +if (!IS_ERR (pages)) {int j; iter.hdr->data[0 ] = bomap - bomap_start;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am Montag, den 14.01.2019, 13:49 +0300 schrieb Dan Carpenter:
Quoted 5 lines
The
etnaviv_gem_get_pages()never returns NULL. It returns error pointers on error.Fixes a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")Signed-off-by Dan Carpenter <[email protected]>
Thanks, applied to etnaviv/next.
Quoted 18 lines
---
drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/etnaviv/etnaviv_dump.c +1
-1@@ -215,7 +215,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) mutex_lock(&obj->lock); pages = etnaviv_gem_get_pages(obj); mutex_unlock(&obj->lock); -if (pages) { +if (!IS_ERR (pages)) { int j;
iter.hdr->data[0] = bomap -bomap_start;