Skip to contentSkip to conversation

Fix cgroup_lib.sh helper

PATCH New Cristian Marussi 2 participants 3 messages Jan 11, 2019 – Jan 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix cgroup_lib.sh helper

A typo compromised get_cgroup_mountpoint() effectiveness leading to cgroup_regression test_5 systematic failure.

---
 testcases/kernel/controllers/cgroup_lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/controllers/cgroup_lib.sh +1 -1
index 8c19c6c3e..45ab51b87 100644
@@ -16,7 +16,7 @@ get_cgroup_mountpoint()
 	[ $# -eq 0 ] && tst_brk TBROK "get_cgroup_mountpoint: subsystem not defined"
 
 	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
-	[ -z "$mountpoint" ] && return 1
+	[ -z "$mntpoint" ] && return 1
 
 	echo $mntpoint
 	return 0
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Fix cgroup_lib.sh helper

Hi Cristian,

...

testcases/kernel/controllers/cgroup_lib.sh get_cgroup_mountpoint() · line 19

Quoted 3 lines
testcases/kernel/controllers/cgroup_lib.sh +1 -1
 	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
-	[ -z "$mountpoint" ] && return 1
+	[ -z "$mntpoint" ] && return 1

Thanks for fix, merged.

I'm sorry, that was introduced by me, while do some changes in your commit.

Kind regards,
Petr

#2 lore raw

PATCH 1/1 Fix cgroup_lib.sh helper

Hi

Quoted 9 lines · Petr Vorel

Hi Cristian,

...

testcases/kernel/controllers/cgroup_lib.sh get_cgroup_mountpoint() · line 19

Quoted 3 lines
testcases/kernel/controllers/cgroup_lib.sh +1 -1
 	mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
-	[ -z "$mountpoint" ] && return 1
+	[ -z "$mntpoint" ] && return 1

Thanks for fix, merged.

I'm sorry, that was introduced by me, while do some changes in your commit.

No problem.

Quoted 5 lines

Kind regards,
Petr

Thanks

Regards

Cristian