Skip to contentSkip to conversation

imx8mq_evk_defconfig: Move file system options to Kconfig

PATCH Superseded Fabio Estevam 2 participants 3 messages Dec 29, 2018 – Jan 14, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

            ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

---
Changes since v1:
- Added missing y to CONFIG_CMD_FAT

 configs/imx8mq_evk_defconfig | 5 +++++
 include/configs/imx8mq_evk.h | 6 ------
 2 files changed, 5 insertions(+), 6 deletions(-)
configs/imx8mq_evk_defconfig +5 -0
index f216d46a8f..b473fcd61b 100644
@@ -15,6 +15,11 @@ CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL=y
 CONFIG_SPL_BOARD_INIT=y
 CONFIG_HUSH_PARSER=y
+CONFIG_DOS_PARTITION=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_CACHE=y
include/configs/imx8mq_evk.h +0 -6
index 35f81152f2..f0430224cb 100644
@@ -226,12 +226,6 @@
 #define CONFIG_SYS_FSL_USDHC_NUM	2
 #define CONFIG_SYS_FSL_ESDHC_ADDR       0
 
-#define CONFIG_DOS_PARTITION
-#define CONFIG_CMD_EXT2
-#define CONFIG_CMD_EXT4
-#define CONFIG_CMD_EXT4_WRITE
-#define CONFIG_CMD_FAT
-
 #define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH v2 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

Hi Tom/Stefano,

Quoted 7 lines · Fabio Estevam

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

Quoted 6 lines
            ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

Can we have this one applied on 2019.01?

Thanks

#2 lore raw

PATCH v2 1/1 imx8mq_evk_defconfig: Move file system options to Kconfig

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

Chris Spencer reports that when enabling ext4 read support without also enabling write support the following error is seen:

fs/fs.c:198:12: error: 'ext4_write_file' undeclared here (not in a function); did you mean 'ext4_read_file'?
.write = ext4_write_file,

Quoted 6 lines
            ^~~~~~~~~~~~~~~

Fix this problem by moving these options to Kconfig.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190114/f6a1aaa2/attachment.sig>