capabilities:: annotate implicit fall through
Subsystems (2)
PATCH 1/1 capabilities:: annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case change put the fall through comment on a single line so as to match the regular expression expected by GCC.
This commit remove the following warning:
kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
--- kernel/capability.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/capability.c +1 -3
@@ -93,9 +93,7 @@ static int cap_validate_magic(cap_user_header_t header, unsigned *tocopy)break ;case _LINUX_CAPABILITY_VERSION_2:warn_deprecated_v2 (); -/* -* fall through - v3 is otherwise equivalent to v2. -*/ +/* fall through - v3 is otherwise equivalent to v2. */ case _LINUX_CAPABILITY_VERSION_3: *tocopy = _LINUX_CAPABILITY_U32S_3;break ;
Signature · 1 line
2.19.2
Quoted 11 lines · Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case change put the fall through comment on a single line so as to match the regular expression expected by GCC.
This commit remove the following warning:
kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=]Signed-off-by Mathieu Malaterre <[email protected]>
Thanks
Quoted 20 lines
--- kernel/capability.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)kernel/capability.c +1
-3@@ -93,9 +93,7 @@ static int cap_validate_magic(cap_user_header_t header, unsigned *tocopy)break ;case _LINUX_CAPABILITY_VERSION_2:warn_deprecated_v2 (); -/* -* fall through - v3 is otherwise equivalent to v2. -*/ +/* fall through - v3 is otherwise equivalent to v2. */ case _LINUX_CAPABILITY_VERSION_3: *tocopy = _LINUX_CAPABILITY_U32S_3;break ;
James Morris
maintainerQuoted 11 lines · Mathieu Malaterre
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case change put the fall through comment on a single line so as to match the regular expression expected by GCC.
This commit remove the following warning:
kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=]Signed-off-by Mathieu Malaterre <[email protected]>
Applied togit://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
Signature · 2 lines
James Morris <[email protected]>