Skip to contentSkip to conversation

blkcg: annotate implicit fall through

PATCH Applied Mathieu Malaterre 2 participants 3 messages Jan 14, 2019 – Mar 13, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blkcg: annotate implicit fall through

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 kernel/trace/blktrace.c | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/blktrace.c +1 -0
index fac0ddf8a8e2..e1c6d79fb4cc 100644
@@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
 #endif
 	case BLKTRACESTART:
 		start = 1;
+		/* fall through */
 	case BLKTRACESTOP:
 		ret = __blk_trace_startstop(q, start);
 		break;
Signature · 1 line
2.19.2
#1 lore raw

ping ?

Quoted 28 lines · Mathieu Malaterre

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]

---
 kernel/trace/blktrace.c | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/blktrace.c +1 -1
index fac0ddf8a8e2..e1c6d79fb4cc 100644
@@ -723,6 +723,7 @@ int blk_trace_ioctl(struct block_device *bdev, unsigned cmd, char __user *arg)
 #endif
        case BLKTRACESTART:
                start = 1;
+               /* fall through */
        case BLKTRACESTOP:
                ret = __blk_trace_startstop(q, start);
                break;
--

2.19.2

maintainer Applied
#2 lore raw
In reply to Mathieu Malaterre
Quoted 6 lines · Mathieu Malaterre

There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).

This commit remove the following warning:

kernel/trace/blktrace.c:725:9: warning: this statement may fall through [-Wimplicit-fallthrough=]

Applied, thanks.

Signature · 1 line
Jens Axboe