irq: annotate implicit fall through
PATCH 1/1 irq: annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1).
In this particular case add a ‘-’ so as to match the regular expression expected by GCC.
This commit remove the following warning:
kernel/irq/handle.c:167:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
--- kernel/irq/handle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/handle.c +1 -1
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags__irq_wake_thread (desc, action); -/* Fall through to add to randomness */ +/* Fall through - to add to randomness */ case IRQ_HANDLED : *flags |= action->flags;break ;
Signature · 1 line
2.19.2
tip-bot for Mathieu Malaterre
merge bot[tip:irq/core] genirq: Correctly annotate implicit fall through
genirq: Correctly annotate implicit fall through
Commit-ID: 01cdfa912f1004c463586f52f1dfcbec1274b1f2 Gitweb: https://git.kernel.org/tip/01cdfa912f1004c463586f52f1dfcbec1274b1f2 Author: Mathieu Malaterre <[email protected]> AuthorDate: Mon, 14 Jan 2019 21:36:33 +0100 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 15 Jan 2019 10:40:53 +0100
genirq: Correctly annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough. The fallthrough in __handle_irq_event_percpu() has a fallthrough annotation which is followed by an additional comment and is not recognized by GCC.
Separate the 'fall through' and the rest of the comment with a dash so the regular expression used by GCC matches.
--- kernel/irq/handle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/handle.c +1 -1
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags__irq_wake_thread (desc, action); -/* Fall through to add to randomness */ +/* Fall through - to add to randomness */ case IRQ_HANDLED : *flags |= action->flags;break ;